[jira] [Commented] (SOLR-13674) NodeAddedTrigger does not support configuration of relica type hint

2019-08-05 Thread Irena Shaigorodsky (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900414#comment-16900414
 ] 

Irena Shaigorodsky commented on SOLR-13674:
---

[~shalinmangar], I fixed the test case.

> NodeAddedTrigger does not support configuration of relica type hint
> ---
>
> Key: SOLR-13674
> URL: https://issues.apache.org/jira/browse/SOLR-13674
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.6
>Reporter: Irena Shaigorodsky
>Assignee: Shalin Shekhar Mangar
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current code 
> org.apache.solr.cloud.autoscaling.ComputePlanAction#getNodeAddedSuggester 
> only sets COLL_SHARD hint, as a result any added replica will be NRT one.
> Our current setup has TLOG nodes on physical hardware and PULL nodes on k8s 
> that are recycled periodically. An attempt to add those will bring the nodes 
> in the cluster as NRT one.
> The root cause is 
> org.apache.solr.client.solrj.cloud.autoscaling.AddReplicaSuggester#tryEachNode
>  that expects to find the hint REPLICATYPE and defaults to NRT one.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13674) NodeAddedTrigger does not support configuration of relica type hint

2019-08-05 Thread Shalin Shekhar Mangar (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899877#comment-16899877
 ] 

Shalin Shekhar Mangar commented on SOLR-13674:
--

Thank you [~ishaigor] for the PR. The changes look good except that the new 
test fails with:
{code}
82359 ERROR 
(OverseerThreadFactory-437-thread-4-processing-n:127.0.0.1:43511_solr) 
[n:127.0.0.1:43511_solr ] o.a.s.c.a.c.OverseerCollectionMessageHandler 
Collection: testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0 
operation: create failed:org.apache.solr.common.SolrException: Error getting 
replica locations :  No node can satisfy the rules "[{replica=#ALL, type=PULL, 
sysprop.solrNodeType=PULL, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=TLOG, sysprop.solrNodeType=TLOG, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=NRT, sysprop.solrNodeType=NRT, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{nodeRole=overseer, replica=0, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{cores=<6, node=#ANY}, {replica=<2, shard=#EACH, node=#ANY, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}] 
More details from logs in node : 127.0.0.1:43511_solr, errorId : 
AutoScaling.error.diagnostics.14915037535846"
at 
org.apache.solr.cloud.api.collections.CreateCollectionCmd.call(CreateCollectionCmd.java:195)
at 
org.apache.solr.cloud.api.collections.OverseerCollectionMessageHandler.processMessage(OverseerCollectionMessageHandler.java:263)
at 
org.apache.solr.cloud.OverseerTaskProcessor$Runner.run(OverseerTaskProcessor.java:505)
at 
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:209)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.solr.common.SolrException:  No node can satisfy the rules 
"[{replica=#ALL, type=PULL, sysprop.solrNodeType=PULL, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=TLOG, sysprop.solrNodeType=TLOG, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=NRT, sysprop.solrNodeType=NRT, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{nodeRole=overseer, replica=0, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{cores=<6, node=#ANY}, {replica=<2, shard=#EACH, node=#ANY, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}] 
More details from logs in node : 127.0.0.1:43511_solr, errorId : 
AutoScaling.error.diagnostics.14915037535846"
at 
org.apache.solr.client.solrj.cloud.autoscaling.PolicyHelper.getReplicaLocations(PolicyHelper.java:185)
at 
org.apache.solr.cloud.api.collections.Assign.getPositionsUsingPolicy(Assign.java:382)
at 
org.apache.solr.cloud.api.collections.Assign$PolicyBasedAssignStrategy.assign(Assign.java:630)
at 
org.apache.solr.cloud.api.collections.CreateCollectionCmd.buildReplicaPositions(CreateCollectionCmd.java:410)
at 
org.apache.solr.cloud.api.collections.CreateCollectionCmd.call(CreateCollectionCmd.java:190)
... 6 more

NOTE: reproduce with: ant test  -Dtestcase=ComputePlanActionTest 
-Dtests.method=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard 
-Dtests.seed=1363057E7AA562F7 -Dtests.slow=true -Dtests.badapples=true 
-Dtests.locale=brx-IN -Dtests.timezone=Antarctica/Rothera -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8


org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error 
from server at http://127.0.0.1:43511/solr: Error getting replica locations :  
No node can satisfy the rules "[{replica=#ALL, type=PULL, 
sysprop.solrNodeType=PULL, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=TLOG, sysprop.solrNodeType=TLOG, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{replica=#ALL, type=NRT, sysprop.solrNodeType=NRT, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{nodeRole=overseer, replica=0, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}, 
{cores=<6, node=#ANY}, {replica=<2, shard=#EACH, node=#ANY, 
collection=testNodeAddedTriggerWithAddReplicaPreferredOpReplicaType_1Shard_0}] 
More details from logs in node : 127.0.0.1:43511_solr, errorId : 
AutoScaling.error.diagnostics.14915037535846"
{code}

Can you please fix?

> NodeAddedTrigger does not sup

[jira] [Commented] (SOLR-13674) NodeAddedTrigger does not support configuration of relica type hint

2019-08-02 Thread Irena Shaigorodsky (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899345#comment-16899345
 ] 

Irena Shaigorodsky commented on SOLR-13674:
---

https://github.com/apache/lucene-solr/pull/821

> NodeAddedTrigger does not support configuration of relica type hint
> ---
>
> Key: SOLR-13674
> URL: https://issues.apache.org/jira/browse/SOLR-13674
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 7.6
>Reporter: Irena Shaigorodsky
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current code 
> org.apache.solr.cloud.autoscaling.ComputePlanAction#getNodeAddedSuggester 
> only sets COLL_SHARD hint, as a result any added replica will be NRT one.
> Our current setup has TLOG nodes on physical hardware and PULL nodes on k8s 
> that are recycled periodically. An attempt to add those will bring the nodes 
> in the cluster as NRT one.
> The root cause is 
> org.apache.solr.client.solrj.cloud.autoscaling.AddReplicaSuggester#tryEachNode
>  that expects to find the hint REPLICATYPE and defaults to NRT one.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org