[jira] [Commented] (SOLR-13704) Return Correct Error code in ExpandComponent for Error cases
[ https://issues.apache.org/jira/browse/SOLR-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910997#comment-16910997 ] ASF subversion and git services commented on SOLR-13704: Commit e584c9d1405576fceceea3c10ec69582a7982b19 in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e584c9d ] SOLR-13704: correct error codes for client errors in expand component > Return Correct Error code in ExpandComponent for Error cases > - > > Key: SOLR-13704 > URL: https://issues.apache.org/jira/browse/SOLR-13704 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13704.patch, SOLR-13704.patch > > > This is spin-off from SOLR-12393 > In some error cases, wrong error code is returned like > * expand field is not specified > * parsing expand query or expand filters fails > In these cases, error code should 400 instead of 500 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13704) Return Correct Error code in ExpandComponent for Error cases
[ https://issues.apache.org/jira/browse/SOLR-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910996#comment-16910996 ] ASF subversion and git services commented on SOLR-13704: Commit 540de65e147728ad21352b8b9072ed0e0c9479bf in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=540de65 ] SOLR-13704: correct error codes for client errors in expand component > Return Correct Error code in ExpandComponent for Error cases > - > > Key: SOLR-13704 > URL: https://issues.apache.org/jira/browse/SOLR-13704 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13704.patch, SOLR-13704.patch > > > This is spin-off from SOLR-12393 > In some error cases, wrong error code is returned like > * expand field is not specified > * parsing expand query or expand filters fails > In these cases, error code should 400 instead of 500 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13704) Return Correct Error code in ExpandComponent for Error cases
[
https://issues.apache.org/jira/browse/SOLR-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910764#comment-16910764
]
Lucene/Solr QA commented on SOLR-13704:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
2m 0s{color} | {color:red} Check forbidden APIs check-forbidden-apis failed
{color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 2m 0s{color} | {color:red} Check forbidden APIs
check-forbidden-apis failed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 34m
14s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13704 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977993/SOLR-13704.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 6eae96c34c |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-SOLR-Build/535/artifact/out/patch-check-forbidden-apis-solr.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-SOLR-Build/535/artifact/out/patch-check-forbidden-apis-solr.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/535/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/535/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Return Correct Error code in ExpandComponent for Error cases
> -
>
> Key: SOLR-13704
> URL: https://issues.apache.org/jira/browse/SOLR-13704
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-13704.patch, SOLR-13704.patch
>
>
> This is spin-off from SOLR-12393
> In some error cases, wrong error code is returned like
> * expand field is not specified
> * parsing expand query or expand filters fails
> In these cases, error code should 400 instead of 500
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13704) Return Correct Error code in ExpandComponent for Error cases
[ https://issues.apache.org/jira/browse/SOLR-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910633#comment-16910633 ] Munendra S N commented on SOLR-13704: - [^SOLR-13704.patch] Correct status code when * expand field is not specified * parsing expand query or expand filters fails * invalid fieldtype is specified. Some of the existing checks in expand assumes that expand is combination with collapsing which may not be the case. Also, when expand.field is date field request fails with status 500 > Return Correct Error code in ExpandComponent for Error cases > - > > Key: SOLR-13704 > URL: https://issues.apache.org/jira/browse/SOLR-13704 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SearchComponents - other >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13704.patch > > > This is spin-off from SOLR-12393 > In some error cases, wrong error code is returned like > * expand field is not specified > * parsing expand query or expand filters fails > In these cases, error code should 400 instead of 500 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
