[jira] [Commented] (SOLR-13711) remove dead sort==null code paths in QueryCommand.java
[
https://issues.apache.org/jira/browse/SOLR-13711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913875#comment-16913875
]
Lucene/Solr QA commented on SOLR-13711:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 35m
13s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13711 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12978336/SOLR-13711.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1cbc5eaf51 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/536/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/536/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> remove dead sort==null code paths in QueryCommand.java
> --
>
> Key: SOLR-13711
> URL: https://issues.apache.org/jira/browse/SOLR-13711
> Project: Solr
> Issue Type: Wish
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13711.patch
>
>
> This ticket proposes to remove 'dead' QueryCommand.java paths associated with
> a 'null' sort value.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13711) remove dead sort==null code paths in QueryCommand.java
[ https://issues.apache.org/jira/browse/SOLR-13711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913635#comment-16913635 ] Christine Poerschke commented on SOLR-13711: Looking at the current https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.2.0/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/QueryCommand.java#L97-L103 implementation: * the sort member is final * the QueryCommand constructor is private * the QueryCommand.Builder.build method rejects null sort values. Therefore the sort value cannot be null and the create and result methods can be (slightly) simplified to not consider null-ness. Will attach proposed patch. Reviews, questions, comments, etc. welcome as usual. Thank you. > remove dead sort==null code paths in QueryCommand.java > -- > > Key: SOLR-13711 > URL: https://issues.apache.org/jira/browse/SOLR-13711 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > This ticket proposes to remove 'dead' QueryCommand.java paths associated with > a 'null' sort value. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
