[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257325#comment-13257325 ] Sami Siren commented on SOLR-2020: -- bq. I also just added a simple test to TestDistributedSearch and also manually verified that the resulting POST is not multi-part. Great! I am also going to file a new jira to add some more junit tests because obviously there was lack of coverage in this area. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Assignee: Sami Siren Priority: Minor Fix For: 3.6, 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257535#comment-13257535 ] Shawn Heisey commented on SOLR-2020: If this is a problem for 3.6 as well can you commit the fix there? I plan to upgrade to 3.6 in the near future and I would like to use the new client. If it is a problem on 3.6, I am wondering if this is an important enough problem to release 3.6.1. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Assignee: Sami Siren Priority: Minor Fix For: 3.6, 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257637#comment-13257637 ] Robert Muir commented on SOLR-2020: --- FYI: 3.6 branch is already setup for 3.6.1 backports here: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene_solr_3_6/ just don't forget to test with java5 :) HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Assignee: Sami Siren Priority: Minor Fix For: 3.6, 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257082#comment-13257082 ] Roger HÃ¥kansson commented on SOLR-2020: --- Also, have a look at SOLR-3375, seems to be related to SOLR-3362 HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Assignee: Sami Siren Priority: Minor Fix For: 3.6, 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257091#comment-13257091 ] Yonik Seeley commented on SOLR-2020: Thanks Sami, your last commit today seems to have fixed the issue. I also just added a simple test to TestDistributedSearch and also manually verified that the resulting POST is not multi-part. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Assignee: Sami Siren Priority: Minor Fix For: 3.6, 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239484#comment-13239484 ] Sami Siren commented on SOLR-2020: -- bq. Solrj compilation fails under Maven: see today's Jenkins Maven 3.x build. Sorry about that. bq. I've committed the following changes - tests now succeed for me locally under the Maven build: Great! I tried to compile with maven myself but solrj failed to compile. Trunk seems to have similar problem with this patch applied. I am pretty sure it used to work at some point {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project solr-solrj: Compilation failure: Compilation failure: [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java:[34,22] cannot find symbol [ERROR] symbol : class SolrTestCaseJ4 [ERROR] location: package org.apache.solr [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java:[35,44] cannot find symbol [ERROR] symbol : class JettySolrRunner [ERROR] location: package org.apache.solr.client.solrj.embedded [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java:[41,27] package org.apache.solr.util does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java:[211,4] cannot find symbol [ERROR] symbol : class JettySolrRunner [ERROR] location: class org.apache.solr.client.solrj.TestLBHttpSolrServer.SolrInstance [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/MultiCoreExampleTestBase.java:[27,27] package org.apache.solr.core does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/MultiCoreExampleTestBase.java:[28,27] package org.apache.solr.core does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/MultiCoreExampleTestBase.java:[29,27] package org.apache.solr.util does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTestBase.java:[21,27] package org.apache.solr.util does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTestBase.java:[31,50] cannot find symbol [ERROR] symbol: class AbstractSolrTestCase [ERROR] abstract public class SolrExampleTestBase extends AbstractSolrTestCase [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/MultiCoreExampleTestBase.java:[41,19] cannot find symbol [ERROR] symbol : class CoreContainer [ERROR] location: class org.apache.solr.client.solrj.MultiCoreExampleTestBase [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/StartSolrJetty.java:[20,24] package org.mortbay.jetty does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/StartSolrJetty.java:[21,24] package org.mortbay.jetty does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/StartSolrJetty.java:[22,28] package org.mortbay.jetty.bio does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/StartSolrJetty.java:[23,31] package org.mortbay.jetty.webapp does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[27,22] cannot find symbol [ERROR] symbol : class SolrTestCaseJ4 [ERROR] location: package org.apache.solr [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[28,27] package org.apache.solr.util does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[32,24] package org.mortbay.jetty does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[33,24] package org.mortbay.jetty does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[34,28] package org.mortbay.jetty.bio does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[35,32] package org.mortbay.jetty.servlet does not exist [ERROR] /home/sam/workspace/lucene-solr-3.x-rw/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:[36,31] package
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239501#comment-13239501 ] Steven Rowe commented on SOLR-2020: --- Sami, [today's Jenkins Maven 3.x build|https://builds.apache.org/job/Lucene-Solr-Maven-3.x/439/] succeeded, including the changes I made, so I suspect your compilation issues are as a result of stale artifacts in your local repository. Before I run tests, I usually do {{mvn -N -P bootstrap install}} and then {{mvn -DskipTests install}} from the top level. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239535#comment-13239535 ] Sami Siren commented on SOLR-2020: -- I think the problem was with maven version. I first tried with maven 3.0.4 and saw those failures but it sure compiles with 2.2.1. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239543#comment-13239543 ] Steven Rowe commented on SOLR-2020: --- bq. I think the problem was with maven version. I first tried with maven 3.0.4 and saw those failures but it sure compiles with 2.2.1. Thanks for tracking down the problem, Sami. Last time I checked, the Maven build worked under Maven 3.0.4. I use Maven 2.2.1, though, so I don't regularly test with 3.0.4. I should set up another Jenkins job that runs the build under Maven 3.0.X. In the mean time, though, I'll look into why 3.0.4 doesn't like the build and make it work for both 2.2.1 and 3.0.4. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239020#comment-13239020 ] Steven Rowe commented on SOLR-2020: --- Sami, Solrj compilation fails under Maven: see [today's Jenkins Maven 3.x build|https://builds.apache.org/job/Lucene-Solr-Maven-3.x/438/]. I've committed the following changes - tests now succeed for me locally under the Maven build: * Switched the scope from runtime to compile for the two {{httpcomponents}} dependencies in the {{solrj}} POM - compilation fails unless these are on the classpath. * Removed {{commons-httpclient}} dependency from the {{solr-core}} POM. It gets this dependency transitively through {{solrj}}. * Added the two {{httpcomponents}} dependencies with test scope to the POM for {{solr-core}} (under which all Solr tests are run in the Maven build, including those of {{solrj}}); otherwise tests fail, because these are *optional* dependencies of {{solrj}}, and are not transitively included on the test classpath. * Added a {{httpcomponents.version}} property to the Lucene/Solr grandparent POM, and used it in the {{dependencyManagement}} declarations for the two {{httpcomponents}} dependencies. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237916#comment-13237916 ] Sami Siren commented on SOLR-2020: -- In 3.x I added some tests for the new client, I think most of the existing (3.x) client tests are now run with the new client too. I also noticed that StreamingUpdateSolrServer extended CommonsHttpSolrServer so I had to add hc 4.x compatible replacement for that too. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236635#comment-13236635 ] Robert Muir commented on SOLR-2020: --- I like this approach for 3.x: since the CommonsHttpSolrServer is deprecated (linking to HttpSolrServer), we might add a little javadoc header explaining that its the http client 4.x implementation. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236647#comment-13236647 ] Linbin Chen commented on SOLR-2020: --- good job. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236740#comment-13236740 ] Ryan McKinley commented on SOLR-2020: - looks good HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-3x.patch, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233434#comment-13233434 ] Sami Siren commented on SOLR-2020: -- bq. I assume this means we'll be able to switch to using NIO for the distributed search sub-requests! Yeah, that should be possible. HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Fix For: 4.0 Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java, SOLR-2020-HttpSolrServer.patch, SOLR-2020.patch, SOLR-2020.patch Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894112#action_12894112 ] Chantal Ackermann commented on SOLR-2020: - The HttpComponentsSolrServer.java requires the following libraries in the classpath: httpcore-4.0.1.jar httpclient-4.0.1.jar httpmime-4.0.1.jar HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894142#action_12894142 ] Chantal Ackermann commented on SOLR-2020: - Hi Yonik, I had a look at the sources of SearchHandler and ResponseBuilder. It think it would work replacing the CommonsHttpSolrServer with the HttpComponentsSolrServer and replace the part where the HttpClient is initialized with the new initialization procedure for version 4. While contemplating these comments from SearchHandler/HttpCommComponent I wonder whether upgrading to Http Components would not be a good time to address these TODOs: // TODO: generalize how a comm component can fit into search component framework // TODO: statics should be per-core singletons class HttpCommComponent { // We want an executor that doesn't take up any resources if // it's not used, so it could be created statically for // the distributed search component if desired. Have there already been ideas on how to generalize that comm component? I'm not sure I understand that comment correctly. I also wondered why there aren't specialized classes for the shard requests? Something like: - subclass ShardSearchHandler extends SearchHandler - subclass ShardResponseBuilder extends ResponseBuilder containing all code handling distributed requests, including the HttpCommComponent. Maybe the plugin framework does not allow these subclasses without breaking a lot - if at all possible? Or some kind of ShardingService that takes over the work for the SearchHandler when it comes to distributed requests. Maybe this could be what is called generalized comm component in the comment? If a request is distributed the SearchHandler (and others?) delegates to the ShardingService. This ShardingService could be configurable to use any implementation of SolrServer. (Does that make sense? Using an embedded SolrServer for distributed requests? Not really - but maybe using their own SolrServer implementations?) HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894174#action_12894174 ] Chantal Ackermann commented on SOLR-2020: - Concerning StreamingUpdateSolrServer's RequestEntity: The replacement is probably EntityTemplate which takes a ContentProducer as argument. http://hc.apache.org/httpcomponents-core/httpcore/apidocs/org/apache/http/entity/EntityTemplate.html http://hc.apache.org/httpcomponents-core/httpcore/apidocs/org/apache/http/entity/ContentProducer.html EntityTemplate entity = new EntityTemplate(new ContentProducer() { public void writeTo(OutputStream out) { // the current implementation of RequestEntity.writeRequest(OutputStream) in StreamingUpdateSolrServer } } The following lines (lines 149pp) need to be changed, as well. I can have a look at that (next days?). HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2020) HttpComponentsSolrServer
[ https://issues.apache.org/jira/browse/SOLR-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893660#action_12893660 ] Yonik Seeley commented on SOLR-2020: Also see HttpCommComponent below Solr's SearchHandler class here: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/handler/component/SearchHandler.java?view=markup HttpComponentsSolrServer Key: SOLR-2020 URL: https://issues.apache.org/jira/browse/SOLR-2020 Project: Solr Issue Type: New Feature Components: clients - java Affects Versions: 1.4.1 Environment: Any Reporter: Chantal Ackermann Priority: Minor Attachments: HttpComponentsSolrServer.java, HttpComponentsSolrServerTest.java Implementation of SolrServer that uses the Apache Http Components framework. Http Components (http://hc.apache.org/) is the successor of Commons HttpClient and thus HttpComponentsSolrServer would be a successor of CommonsHttpSolrServer, in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org