[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257348#comment-13257348 ] Stefan Matheis (steffkes) commented on SOLR-3330: - Style-Changes committed in r1327854 - will check your updates and see how we could integrate them Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch, SOLR-3330-ui-update.patch, SOLR-3330.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256269#comment-13256269 ] Ryan McKinley commented on SOLR-3330: - bq. fetching the 'reference xml' is now done right after loading the initial page. eeep. I would expect the changes to be based on when I click the button. I think the way to solve our issue is for the diff request to return the things that did not change as well. I'll make a patch for that and see if we can make that work Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch, SOLR-3330-ui-update.patch, SOLR-3330.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257155#comment-13257155 ] Ryan McKinley commented on SOLR-3330: - In r1327775 I added an option to get back all the ref elements as well. Add all=true as a param, and you will get everything back. It now appends a field to the changed items: _changed_: true The thought is you can update everything, but only highlight the elements that have _changed_ stefan, go ahead and commit the style changes to make the highlight more prominent Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch, SOLR-3330-ui-update.patch, SOLR-3330.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253703#comment-13253703 ] Hoss Man commented on SOLR-3330: can we change this to use an HTTP POST body instead of stream.body request param? ... it's sending some really long ass request URLs that might not work if a servlet container is configured to limit the URL length. Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253724#comment-13253724 ] Ryan McKinley commented on SOLR-3330: - It is already using POST with stream.body as a application/x-www-form-urlencoded param Are you seeing the long URL in the logs, or in your browser? Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253754#comment-13253754 ] Hoss Man commented on SOLR-3330: Sorry .. i was looking at the solr logging (SolrCore.execute) ... because it's using Content-Type: application/x-www-form-urlencoded and the stream.body param, it's all being included in the list of SolrParams that get logged. So my concern about extra long URLs breaking is a non-issue, but it's still kind of noisy as far as solr logging goes. If it was changed to use Content-Type: application/xml and send the xml directly then it wouldn't be counted as a solr param, but the handler would still get it as a ContentStream. --- as for how it looks: in my initial impression i didn't realize that it was recording values core all the categories of plugins (ie: i was looking at Query Handlers and didn't notice the little grey numbers indicating that Caches also had some changes) ... the #BBA500 color used to make the plugin names with changes standout is great (even if you remove the new icon completely) so maybe just using that same color on the category names (or at least the little numbers indicating that items in that category have changed) would be helpful to draw attention to them? Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252255#comment-13252255 ] Stefan Matheis (steffkes) commented on SOLR-3330: - bq. Right now the UI shows the values from 1, then updates the changes between 23 – the problem is that the values that may have changed between 12 are not reflected in the UI. (Not a huge deal, but not accurate) Ah yes, you're right. Hm, will think about that. perhaps there is a quick solution for that. Also for the 'new' icon .. yes, the icon set does not have an 'update' icon ;o Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251698#comment-13251698 ] Ryan McKinley commented on SOLR-3330: - sweet! Thanks Stefan. I commited this in r1324839 I think it makes sense to only show the changed elements. The values in the non-changed elements reflect the values when you first visited the page, not when you click Watch Changes I see two ways to resolve this: a. remove them from the UI b. change the diff handler so it returns all the values, not just the changed ones. It would add a marker for things that have changed I think it makes sense to add in a 'reload' button that will refresh all the stats Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[
https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251725#comment-13251725
]
Stefan Matheis (steffkes) commented on SOLR-3330:
-
I added the Images in r1324857.
{quote}I see two ways to resolve this:
a. remove them from the UI
b. change the diff handler so it returns all the values, not just the changed
ones. It would add a marker for things that have changed{quote}
Perhaps i don't get it .. but (b) is what we already have? The diff-handler
returns only the changed items, but i'm merging them into the Data we already
have from the first request. The Navigation on the left gets an (1)ish-Counter
for changed Items, and the List on the right gets an new icon for changed
Items.
One Thing regarding (a), i'm not sure if that would be a good one. Image you've
selected CORE and you're watching changes .. and the only change happens in
QUERYHANDLER (because at least, the mbean-handler will change) then you're
current view will change automatically ;/ if possible i'd like to avoid this
The Reload Link which is already in there has no functionally right know, but
i guess it's the easiest way to initiate an typical browser-reload to get the
typical view back.
Show changes in plugin statistics across multiple requests
--
Key: SOLR-3330
URL: https://issues.apache.org/jira/browse/SOLR-3330
Project: Solr
Issue Type: New Feature
Components: web gui
Reporter: Ryan McKinley
Fix For: 4.0
Attachments: SOLR-3330-pluggins-diff.patch,
SOLR-3330-pluggins-diff.patch, SOLR-3330-record-changes-ui.patch,
SOLR-3330-record-changes-ui.patch
When debugging configuration and performance, I often:
1. Look at stats values
2. run some queries
3. See how the stats values changed
This is fine, but is often a bit clunky and you have to really know what you
are looking for to see any changes.
It would be great if the 'plugins' page had a button that would make this
easier
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251738#comment-13251738 ] Ryan McKinley commented on SOLR-3330: - bq. but (b) is what we already have? No, right now it *only* returns the changed items. There are three points in time: 1. When the page first loads 2. When you click 'Watch Changes' 3. When you click 'Show Changes' Right now the UI shows the values from 1, then updates the changes between 23 -- the problem is that the values that may have changed between 12 are not reflected in the UI. (Not a huge deal, but not accurate) I think the highlight you already added looks good -- the New icon is a bit misleading because it implies that it is a new value (not just a changed one) Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-plugins.png, SOLR-3330-record-changes-ui.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[
https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249801#comment-13249801
]
Stefan Matheis (steffkes) commented on SOLR-3330:
-
Ryan, the Handler normally returns data structured like this:
{code}solr-mbeans: [
QUERYHANDLER
{
/admin/mbeans:
{
class:
org.apache.solr.handler.admin.SolrInfoMBeanHandler,
version: 4.0.0.2012.04.07.21.36.12
}
}
]{code}
but the diff-response looks like this:
{code}solr-mbeans: [
QUERYHANDLER
[
/admin/mbeans,
[
class
org.apache.solr.handler.admin.SolrInfoMBeanHandler
version
4.0.0.2012.04.07.21.36.12
]
]
]{code}
if we could change this latter one and use the same format that we have on the
first request, would be easy to merge and show the differences on the page? In
the meantime i'll cleanup the js-code a little bit and integrate highlights of
changed informations
Show changes in plugin statistics across multiple requests
--
Key: SOLR-3330
URL: https://issues.apache.org/jira/browse/SOLR-3330
Project: Solr
Issue Type: New Feature
Components: web gui
Reporter: Ryan McKinley
Fix For: 4.0
Attachments: SOLR-3330-pluggins-diff.patch,
SOLR-3330-pluggins-diff.patch, SOLR-3330-record-changes-ui.patch
When debugging configuration and performance, I often:
1. Look at stats values
2. run some queries
3. See how the stats values changed
This is fine, but is often a bit clunky and you have to really know what you
are looking for to see any changes.
It would be great if the 'plugins' page had a button that would make this
easier
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3330) Show changes in plugin statistics across multiple requests
[ https://issues.apache.org/jira/browse/SOLR-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249897#comment-13249897 ] Ryan McKinley commented on SOLR-3330: - Changed NamedList to SimpleOrderedMap in revision 1311292 It should now look the same in JSON Show changes in plugin statistics across multiple requests -- Key: SOLR-3330 URL: https://issues.apache.org/jira/browse/SOLR-3330 Project: Solr Issue Type: New Feature Components: web gui Reporter: Ryan McKinley Fix For: 4.0 Attachments: SOLR-3330-pluggins-diff.patch, SOLR-3330-pluggins-diff.patch, SOLR-3330-record-changes-ui.patch When debugging configuration and performance, I often: 1. Look at stats values 2. run some queries 3. See how the stats values changed This is fine, but is often a bit clunky and you have to really know what you are looking for to see any changes. It would be great if the 'plugins' page had a button that would make this easier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
