[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056191#comment-16056191 ] David Smiley commented on SOLR-3346: [~janhoy] see SOLR-6807. I'd love to see this done as an initial step in 7.0. > qt Dispatching Request Handler > -- > > Key: SOLR-3346 > URL: https://issues.apache.org/jira/browse/SOLR-3346 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: David Smiley > > Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), > it would be better implemented as a request handler, with a suggested name of > DispatchingRequestHandler. This is better because: > * it keeps the servlet filter more focused / simplified (albeit just a little) > * it simplifies solrconfig.xml by removing/deprecating handleSelect="true". > 'qt' is less magic, it works more explicitly. > * if you don't want to use 'qt' dispatch, simply don't use > DispatchingRequestHandler > * DispatchingRequestHandler would get used by EmbeddedSolrServer but > SolrDispatchFilter is not. > Credit: Hoss's idea, Erik coded a first draft -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055307#comment-16055307 ] Jan Høydahl commented on SOLR-3346: --- Do people still think we should keep "qt" and "handleSelect" around forever? I'd vote for ripping it all out for 8.0 and provide this Handler if there is a user demand for it. > qt Dispatching Request Handler > -- > > Key: SOLR-3346 > URL: https://issues.apache.org/jira/browse/SOLR-3346 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: David Smiley > > Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), > it would be better implemented as a request handler, with a suggested name of > DispatchingRequestHandler. This is better because: > * it keeps the servlet filter more focused / simplified (albeit just a little) > * it simplifies solrconfig.xml by removing/deprecating handleSelect="true". > 'qt' is less magic, it works more explicitly. > * if you don't want to use 'qt' dispatch, simply don't use > DispatchingRequestHandler > * DispatchingRequestHandler would get used by EmbeddedSolrServer but > SolrDispatchFilter is not. > Credit: Hoss's idea, Erik coded a first draft -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[
https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278434#comment-13278434
]
Hoss Man commented on SOLR-3346:
bq. Credit: Hoss's idea
to be clear, i did not suggest that we should eliminate qt support from
SolrDispatchFilter.
what i said in SOLR-3161 was...
{quote}
change the example solrocnfig to use handleSelect=false
...
Bonus points: someone can write a DispatchingRequestHandler that can optionally
be configured with some name (such as /select) and does nothing put look for
a qt param and forward to the handler with that name – but it can have
configuration options indicating which names are permitted (and any other names
would be rejected)
{quote}
my entire point was that we should leave in support for 'handleSelect=true'
exactly as it is for the multitudes of existing users who are happy using qt
w/o any security concerns, but that we could _also_ offer an optional
DispatchingRequestHandler for people who want param based dispatching but want
to limit it to only certain handlers
qt Dispatching Request Handler
--
Key: SOLR-3346
URL: https://issues.apache.org/jira/browse/SOLR-3346
Project: Solr
Issue Type: New Feature
Components: search
Reporter: David Smiley
Fix For: 4.1
Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter),
it would be better implemented as a request handler, with a suggested name of
DispatchingRequestHandler. This is better because:
* it keeps the servlet filter more focused / simplified (albeit just a little)
* it simplifies solrconfig.xml by removing/deprecating handleSelect=true.
'qt' is less magic, it works more explicitly.
* if you don't want to use 'qt' dispatch, simply don't use
DispatchingRequestHandler
* DispatchingRequestHandler would get used by EmbeddedSolrServer but
SolrDispatchFilter is not.
Credit: Hoss's idea, Erik coded a first draft
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278453#comment-13278453 ] Erik Hatcher commented on SOLR-3346: I'm too overwhelmed with other stuff to battle this, but I entirely disagree. SolrDispatchFilter needs to have it's logic moved down a layer when it comes to determining which request handler to hit, in my opinion. Having this kind of logic at the web tier, for one thing, requires that folks using Solr embedded (or in direct connection kinda tests) have to recreate this logic. That's just one reason we should eliminate the handleSelect/qt business. As we've seen, though, it's a thorny topic that necessitates changes in 3rd party clients, etc to eliminate qt, and this is what this issue is about - keeping a backwards-compatible layer for qt support while making it trivial to enable or not. Hoss mentioned multitudes of existing users who are happy using 'qt' without security concerns - my assertion is that these users don't know the types of capabilities that are open (perhaps thinking if they just removed/blocked /admin that they'd be safer). qt Dispatching Request Handler -- Key: SOLR-3346 URL: https://issues.apache.org/jira/browse/SOLR-3346 Project: Solr Issue Type: New Feature Components: search Reporter: David Smiley Fix For: 4.1 Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), it would be better implemented as a request handler, with a suggested name of DispatchingRequestHandler. This is better because: * it keeps the servlet filter more focused / simplified (albeit just a little) * it simplifies solrconfig.xml by removing/deprecating handleSelect=true. 'qt' is less magic, it works more explicitly. * if you don't want to use 'qt' dispatch, simply don't use DispatchingRequestHandler * DispatchingRequestHandler would get used by EmbeddedSolrServer but SolrDispatchFilter is not. Credit: Hoss's idea, Erik coded a first draft -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250742#comment-13250742 ] Yonik Seeley commented on SOLR-3346: I think I would prefer leaving things as they are (as you say, it's just a small piece of code in the SolrDispatchFilter... and qt is all about dispatching!) It would seem to introduce extra overhead for anyone that wanted to use qt as they did before, and there's a good probability that it would introduce more bugs as well. qt Dispatching Request Handler -- Key: SOLR-3346 URL: https://issues.apache.org/jira/browse/SOLR-3346 Project: Solr Issue Type: New Feature Components: search Reporter: David Smiley Fix For: 4.0 Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), it would be better implemented as a request handler, with a suggested name of DispatchingRequestHandler. This is better because: * it keeps the servlet filter more focused / simplified (albeit just a little) * it simplifies solrconfig.xml by removing/deprecating handleSelect=true. 'qt' is less magic, it works more explicitly. * if you don't want to use 'qt' dispatch, simply don't use DispatchingRequestHandler * DispatchingRequestHandler would get used by EmbeddedSolrServer but SolrDispatchFilter is not. Credit: Hoss's idea, Erik coded a first draft -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
