[jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type

2012-12-10 Thread Commit Tag Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528536#comment-13528536
 ] 

Commit Tag Bot commented on SOLR-4071:
--

[trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revisionrevision=1419952

SOLR-4071: Validate that name is pass to Collections API create, and behave the 
same way as on startup when collection.configName is not explicitly passed.


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type
 -

 Key: SOLR-4071
 URL: https://issues.apache.org/jira/browse/SOLR-4071
 Project: Solr
  Issue Type: Bug
  Components: SolrCloud
Affects Versions: 4.0-BETA, 4.0
Reporter: Po Rui
Assignee: Mark Miller
Priority: Critical
 Fix For: 4.1, 5.0

 Attachments: SOLR-4071.patch


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type. numShards's type doesn't checked and parameter count maybe less than 
 required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type

2012-12-10 Thread Commit Tag Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528540#comment-13528540
 ] 

Commit Tag Bot commented on SOLR-4071:
--

[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revisionrevision=1419953

SOLR-4071: Validate that name is pass to Collections API create, and behave the 
same way as on startup when collection.configName is not explicitly passed.


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type
 -

 Key: SOLR-4071
 URL: https://issues.apache.org/jira/browse/SOLR-4071
 Project: Solr
  Issue Type: Bug
  Components: SolrCloud
Affects Versions: 4.0-BETA, 4.0
Reporter: Po Rui
Assignee: Mark Miller
Priority: Critical
 Fix For: 4.1, 5.0

 Attachments: SOLR-4071.patch


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type. numShards's type doesn't checked and parameter count maybe less than 
 required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type

2012-12-05 Thread Mark Miller (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1353#comment-1353
 ] 

Mark Miller commented on SOLR-4071:
---

I'll get to this soon Po!

 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type
 -

 Key: SOLR-4071
 URL: https://issues.apache.org/jira/browse/SOLR-4071
 Project: Solr
  Issue Type: Bug
  Components: SolrCloud
Affects Versions: 4.0-BETA, 4.0
Reporter: Po Rui
Assignee: Mark Miller
Priority: Critical
 Fix For: 4.1, 5.0

 Attachments: SOLR-4071.patch


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type. numShards's type doesn't checked and parameter count maybe less than 
 required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type

2012-11-15 Thread Po Rui (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497881#comment-13497881
 ] 

Po Rui commented on SOLR-4071:
--

yes. the null object got by SolrQueryRequest.getParams().get() will write into 
ZkNodeProps as a String null in Handler. e.g. 
request:http://127.0.0.1:8983/solr/admin/collections?action=CREATEname=collection2numShards=3numReplicas=2.
 this request miss parameter 'collection.configName'. but the finally message 
offer to distributed queue(/overseer/queque) like

{……
name : collection2;
numShards : 3;
collection.configName : null;
……
}
the String 'null' become the default value. all other args in any message maybe 
potentially assigned to value null

 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type
 -

 Key: SOLR-4071
 URL: https://issues.apache.org/jira/browse/SOLR-4071
 Project: Solr
  Issue Type: Bug
  Components: SolrCloud
Affects Versions: 4.0-BETA, 4.0
Reporter: Po Rui
Assignee: Mark Miller
Priority: Critical
 Fix For: 4.1, 5.0

 Attachments: SOLR-4071.patch


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type. numShards's type doesn't checked and parameter count maybe less than 
 required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type

2012-11-13 Thread Mark Miller (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496305#comment-13496305
 ] 

Mark Miller commented on SOLR-4071:
---

This is likely a general issue with most of the 'admin' type apis - something 
we should improve though.

 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type
 -

 Key: SOLR-4071
 URL: https://issues.apache.org/jira/browse/SOLR-4071
 Project: Solr
  Issue Type: Bug
  Components: SolrCloud
Affects Versions: 4.0-BETA, 4.0
Reporter: Po Rui
Assignee: Mark Miller
Priority: Critical
 Fix For: 4.1, 5.0

 Attachments: SOLR-4071.patch


 CollectionsHandler.handleCreateAction() doesn't validate parameter count and 
 type. numShards's type doesn't checked and parameter count maybe less than 
 required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org