[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642767#comment-13642767 ] Commit Tag Bot commented on SOLR-4766: -- [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revisionrevision=1476153 SOLR-4766: detect when maven war/jar has different contents (file name + size) from the corresponding binary release smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 4.3 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642768#comment-13642768 ] Commit Tag Bot commented on SOLR-4766: -- [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revisionrevision=1476154 SOLR-4766: detect when maven war/jar has different contents (file name + size) from the corresponding binary release smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 4.3 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642769#comment-13642769 ] Michael McCandless commented on SOLR-4766: -- I committed a fix that seems to catch the current problem ... but Steve if you get a chance can you review it? Thanks. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 4.3 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642770#comment-13642770 ] Robert Muir commented on SOLR-4766: --- Thank you Mike! smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 4.3 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642821#comment-13642821 ] Steve Rowe commented on SOLR-4766: -- bq. I committed a fix that seems to catch the current problem ... but Steve if you get a chance can you review it? Thanks. Looks good to me. I wonder if comparing file sizes will cause problems. When I tried a ways back to institute checks for identical artifacts, I ran into problems with differing timestamps in archive metadata; that is, since the build creates the same artifact multiple times, even though their contents are identical, their metadata isn't. It's possible that metadata differences will change file sizes. The real fix here is to change the build so that any given artifact is only built once when producing a release. This is not just an issue for the Maven artifacts - the Solr .war includes lucene .jars that are built separately from the Lucene release .jars. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642841#comment-13642841 ] Robert Muir commented on SOLR-4766: --- Maybe we can just compare filenames for now? Its an improvement and would find this bug. I think filesizes are unsafe at the moment, too. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642849#comment-13642849 ] Steve Rowe commented on SOLR-4766: -- bq. I think filesizes are unsafe at the moment, too. I ran the maven checks from the smoke tester with Mike's modifications, and then diff'd the maven and binary Solr .war contents, and the only differences are the extra files in the maven .war: WEB-INF/lib/jcl-over-slf4j-1.6.6.jar [17289 bytes] WEB-INF/lib/jul-to-slf4j-1.6.6.jar [4955 bytes] WEB-INF/lib/log4j-1.2.16.jar [481535 bytes] [...] WEB-INF/lib/slf4j-api-1.6.6.jar [26176 bytes] WEB-INF/lib/slf4j-log4j12-1.6.6.jar [9711 bytes] So at least for the current RC, differing file sizes are not a problem. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642854#comment-13642854 ] Robert Muir commented on SOLR-4766: --- Yeah im just trying to figure out if its safe in general. The zip size itself is unsafe because timestamps change in the META-INF (and will compress differently). But i dont know if the timestamps are fixed width, like i have no idea if this is always a consistent date format or maybe just uses default locale, etc: Implementation-Version: 4.4.0 1476154 - rmuir - *2013-04-26 08:16:05* emphasis on timestamp. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642855#comment-13642855 ] Robert Muir commented on SOLR-4766: --- yeah i think thats the issue. I think with the current RC you just got lucky. But depending on timestamps, the jars-within-the-war built from lucene and solr might compress differently. This means the wars will have different TOC because the jars within it have different sizes. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643067#comment-13643067 ] Steve Rowe commented on SOLR-4766: -- I ran the Maven checks from the smoke tester with Mike's modifications against the 4.1 and the 4.2 RCs (each had only one). The checks against 4.1 failed because the Maven Solr war has this: WEB-INF/lib/solr-solrj-4.1.0.jar [384476 bytes] while the binary Solr war has this: WEB-INF/lib/solr-solrj-4.1.0.jar [384475 bytes] So apparently the timestamp metadata can change file sizes in practice, not just in theory. I think we should remove the file size checks from smoke tester's maven/binary war file contents comparison. - The 4.2 check failed with a different message: RuntimeError: JAR file /Users/sarowe/temp/4.2/tmpDir/maven/org/apache/lucene/lucene-analyzers-common/4.2.0/lucene-analyzers-common-4.2.0-javadoc.jar is missing Created-By: 1.6 inside its META-INF/MANIFEST.MF The Created-By line from lucene-analyzers-common's manifest is: Created-By: 1.7.0_09-b05 (Oracle Corporation) smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643150#comment-13643150 ] Michael McCandless commented on SOLR-4766: -- bq. I think we should remove the file size checks from smoke tester's maven/binary war file contents comparison. +1, I'll remove the size check ... it will just check file names. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643212#comment-13643212 ] Commit Tag Bot commented on SOLR-4766: -- [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revisionrevision=1476385 SOLR-4766: don't compare file sizes of war/jar contents when comparing maven to binary release smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643213#comment-13643213 ] Commit Tag Bot commented on SOLR-4766: -- [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revisionrevision=1476386 SOLR-4766: don't compare file sizes of war/jar contents when comparing maven to binary release smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 5.0, 4.4 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
[ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642540#comment-13642540 ] Robert Muir commented on SOLR-4766: --- My initial idea is where we check jars and wars in checkIdenticalMavenArtifacts, to compare their zip TOCs and ensure they have the same sets of files. smoketester to check war files have the same contents - Key: SOLR-4766 URL: https://issues.apache.org/jira/browse/SOLR-4766 Project: Solr Issue Type: Test Components: Build Affects Versions: 4.3 Reporter: Robert Muir Fix For: 4.3 As Ryan points out on [VOTE] Lucene Solr 4.3.0 RC3 thread, somehow the .war file in the binary packaging has different contents than the maven one (in particular, one contains logging jars, the other does not). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
