[jira] [Commented] (SOLR-4934) Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy
[ https://issues.apache.org/jira/browse/SOLR-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688104#comment-13688104 ] Shawn Heisey commented on SOLR-4934: I was getting ready to file an issue, glad I found this before doing so. The only thing I knew was that LUCENE-5038 had caused Solr to make compound files and the useCompoundFile setting under indexConfig that I found in the branch_4x example wasn't turning it off. A connected discussion, for which I can file an issue if necessary: Assuming there are plenty of file descriptors available, will a user get better performance from compound files or separate files? Is it dependent on other factors like filesystem choice, or is one a clear winner? The outcome of that discussion should decide what Solr's default is when no related config options are used. Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy -- Key: SOLR-4934 URL: https://issues.apache.org/jira/browse/SOLR-4934 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Hoss Man Fix For: 5.0, 4.4 * LUCENE-5038 eliminated setUseCompoundFile(boolean) from the built in MergePolicies * existing users may have configs that use mergePolicy init args to try and call that setter * we already do some explicit checks for these MergePolices in SolrIndexConfig to deal with legacy syntax * update the existing logic to remove useCompoundFile from the MergePolicy initArgs for these known policies if found, and log a warning. (NOTE: i don't want to arbitrarily remove useCompoundFile from the initArgs regardless of class in case someone has a custom MergePolicy that implements that logic -- that would suck) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4934) Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy
[ https://issues.apache.org/jira/browse/SOLR-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688179#comment-13688179 ] Hoss Man commented on SOLR-4934: bq. The only thing I knew was that LUCENE-5038 had caused Solr to make compound files and the useCompoundFile setting under indexConfig that I found in the branch_4x example wasn't turning it off. Oh ... hmmm, yeah ... i hadn't noticed that. definitely a bug there. I've opened SOLR-4926 to track that, and we'll leave this issue specifically about the broken initargs config option. Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy -- Key: SOLR-4934 URL: https://issues.apache.org/jira/browse/SOLR-4934 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Hoss Man Fix For: 5.0, 4.4 * LUCENE-5038 eliminated setUseCompoundFile(boolean) from the built in MergePolicies * existing users may have configs that use mergePolicy init args to try and call that setter * we already do some explicit checks for these MergePolices in SolrIndexConfig to deal with legacy syntax * update the existing logic to remove useCompoundFile from the MergePolicy initArgs for these known policies if found, and log a warning. (NOTE: i don't want to arbitrarily remove useCompoundFile from the initArgs regardless of class in case someone has a custom MergePolicy that implements that logic -- that would suck) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4934) Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy
[ https://issues.apache.org/jira/browse/SOLR-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688190#comment-13688190 ] Uwe Schindler commented on SOLR-4934: - bq. Assuming there are plenty of file descriptors available, will a user get better performance from compound files or separate files? Searching on the index will have no negative impact. IndexInputSlicer returns optimized indexinputs that remove the whole file offset stuff. Indexing speed is identical, too, but merging (done in background) is more expensive. Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy -- Key: SOLR-4934 URL: https://issues.apache.org/jira/browse/SOLR-4934 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Hoss Man Fix For: 5.0, 4.4 * LUCENE-5038 eliminated setUseCompoundFile(boolean) from the built in MergePolicies * existing users may have configs that use mergePolicy init args to try and call that setter * we already do some explicit checks for these MergePolices in SolrIndexConfig to deal with legacy syntax * update the existing logic to remove useCompoundFile from the MergePolicy initArgs for these known policies if found, and log a warning. (NOTE: i don't want to arbitrarily remove useCompoundFile from the initArgs regardless of class in case someone has a custom MergePolicy that implements that logic -- that would suck) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4934) Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy
[ https://issues.apache.org/jira/browse/SOLR-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687310#comment-13687310 ] Hoss Man commented on SOLR-4934: Committed revision 1494348. The fix itself was fairly small, and the bulk of the change was svn copying of test configs so i just went ahead and committed to trunk instead of attaching a patch. If there are no objections, i'll backport to 4x later tonight or early tommorow. Prevent runtime failure if users use initargs useCompoundFile setting on LogMergePolicy or TieredMergePolicy -- Key: SOLR-4934 URL: https://issues.apache.org/jira/browse/SOLR-4934 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Hoss Man Fix For: 5.0, 4.4 * LUCENE-5038 eliminated setUseCompoundFile(boolean) from the built in MergePolicies * existing users may have configs that use mergePolicy init args to try and call that setter * we already do some explicit checks for these MergePolices in SolrIndexConfig to deal with legacy syntax * update the existing logic to remove useCompoundFile from the MergePolicy initArgs for these known policies if found, and log a warning. (NOTE: i don't want to arbitrarily remove useCompoundFile from the initArgs regardless of class in case someone has a custom MergePolicy that implements that logic -- that would suck) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
