[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ
[ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925232#comment-13925232 ] ASF subversion and git services commented on SOLR-5825: --- Commit 1575722 from [~erickoerickson] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575722 ] SOLR-5825, Separate http request creation and execution in SolrJ. Thanks Steve. Separate http request creation and execution in SolrJ - Key: SOLR-5825 URL: https://issues.apache.org/jira/browse/SOLR-5825 Project: Solr Issue Type: Improvement Components: clients - java Reporter: Steven Bower Assignee: Erick Erickson Attachments: SOLR-5825.patch, SOLR-5825.patch In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function. In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish.. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ
[ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924938#comment-13924938 ] ASF subversion and git services commented on SOLR-5825: --- Commit 1575576 from [~erickoerickson] in branch 'dev/trunk' [ https://svn.apache.org/r1575576 ] SOLR-5825, Separate http request creation and execution in SolrJ. Thanks Steve. Separate http request creation and execution in SolrJ - Key: SOLR-5825 URL: https://issues.apache.org/jira/browse/SOLR-5825 Project: Solr Issue Type: Improvement Components: clients - java Reporter: Steven Bower Assignee: Erick Erickson Attachments: SOLR-5825.patch, SOLR-5825.patch In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function. In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish.. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ
[ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923913#comment-13923913 ] Mark Miller commented on SOLR-5825: --- +1 Separate http request creation and execution in SolrJ - Key: SOLR-5825 URL: https://issues.apache.org/jira/browse/SOLR-5825 Project: Solr Issue Type: Improvement Components: clients - java Reporter: Steven Bower Attachments: SOLR-5825.patch In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function. In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish.. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ
[ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924642#comment-13924642 ] Erick Erickson commented on SOLR-5825: -- I took a brief look, my question is why pass the SolrRequest to executeMethod? It doesn't appear to be used. At least IntelliJ doesn't complain when I take it out. Running tests now with it removed.. And I'm all for splitting that _huge_ method up. Separate http request creation and execution in SolrJ - Key: SOLR-5825 URL: https://issues.apache.org/jira/browse/SOLR-5825 Project: Solr Issue Type: Improvement Components: clients - java Reporter: Steven Bower Assignee: Erick Erickson Attachments: SOLR-5825.patch In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function. In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish.. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ
[ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923520#comment-13923520 ] Steven Bower commented on SOLR-5825: Btw, this patch is fully backwards compatible as it leaves the existing request method signature alone and simply changes the internals to call 2 new functions. Separate http request creation and execution in SolrJ - Key: SOLR-5825 URL: https://issues.apache.org/jira/browse/SOLR-5825 Project: Solr Issue Type: Improvement Components: clients - java Reporter: Steven Bower Attachments: SOLR-5825.patch In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function. In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish.. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
