[jira] [Commented] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher, Grouping

2014-06-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025770#comment-14025770
 ] 

ASF subversion and git services commented on SOLR-6067:
---

Commit 1601511 from hoss...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1601511 ]

SOLR-6067: Refactor duplicate Collector code in SolrIndexSearcher

 add buildAndRunCollectorChain methods to reduce code duplication in 
 SolrIndexSearcher, Grouping
 ---

 Key: SOLR-6067
 URL: https://issues.apache.org/jira/browse/SOLR-6067
 Project: Solr
  Issue Type: Improvement
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6067.patch, SOLR-6067.patch


 https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher, Grouping

2014-06-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025833#comment-14025833
 ] 

ASF subversion and git services commented on SOLR-6067:
---

Commit 1601515 from hoss...@apache.org in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1601515 ]

SOLR-6067: Refactor duplicate Collector code in SolrIndexSearcher (merge 
r1601511)

 add buildAndRunCollectorChain methods to reduce code duplication in 
 SolrIndexSearcher, Grouping
 ---

 Key: SOLR-6067
 URL: https://issues.apache.org/jira/browse/SOLR-6067
 Project: Solr
  Issue Type: Improvement
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6067.patch, SOLR-6067.patch


 https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher, Grouping

2014-05-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013592#comment-14013592
 ] 

ASF GitHub Bot commented on SOLR-6067:
--

GitHub user cpoerschke opened a pull request:

https://github.com/apache/lucene-solr/pull/54

SOLR-6067: add methods to reduce code duplication in SolrIndexSearcher, 
Grouping

For ticket https://issues.apache.org/jira/i#browse/SOLR-6067 - baselined 
against trunk (previous pull request was against branch_4x).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bloomberg/lucene-solr trunk-solr-6067

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 2b4d92f1192c6a4126cc69b38f5026fa4bbb7304
Author: Christine Poerschke cpoersc...@bloomberg.net
Date:   2014-05-08T13:23:32Z

SOLR-6067: add buildAndRunCollectorChain methods to reduce code duplication 
in SolrIndexSearcher, Grouping




 add buildAndRunCollectorChain methods to reduce code duplication in 
 SolrIndexSearcher, Grouping
 ---

 Key: SOLR-6067
 URL: https://issues.apache.org/jira/browse/SOLR-6067
 Project: Solr
  Issue Type: Improvement
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6067.patch


 https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher, Grouping

2014-05-30 Thread Christine Poerschke (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013610#comment-14013610
 ] 

Christine Poerschke commented on SOLR-6067:
---

Hi [~hossman] - i have updated with 
https://github.com/apache/lucene-solr/pull/54, could you try applying that 
patch (instead of the earlier #48 one)? Thanks.

 add buildAndRunCollectorChain methods to reduce code duplication in 
 SolrIndexSearcher, Grouping
 ---

 Key: SOLR-6067
 URL: https://issues.apache.org/jira/browse/SOLR-6067
 Project: Solr
  Issue Type: Improvement
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6067.patch


 https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher, Grouping

2014-05-19 Thread Christine Poerschke (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002120#comment-14002120
 ] 

Christine Poerschke commented on SOLR-6067:
---

Added Grouping.java to this ticket, 
https://github.com/apache/lucene-solr/pull/48 updated with proposed change.

 add buildAndRunCollectorChain methods to reduce code duplication in 
 SolrIndexSearcher, Grouping
 ---

 Key: SOLR-6067
 URL: https://issues.apache.org/jira/browse/SOLR-6067
 Project: Solr
  Issue Type: Improvement
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6067.patch


 https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org