[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118737#comment-14118737
]
ASF subversion and git services commented on SOLR-6073:
---
Commit 1622121 from [~anshumg] in branch 'dev/trunk'
[ https://svn.apache.org/r1622121 ]
SOLR-6073: Deprecate helper methods for CollectionsAPI SolrJ calls. Move
towards using builder design for the calls.
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Assignee: Anshum Gupta
Fix For: 5.0, 4.11
Attachments: SOLR-6073-4x.patch, SOLR-6073-4x.patch, SOLR-6073.patch,
SOLR-6073.patch
In the process also cleanup the following: The CollectionAdminRequest has a
createCollection() method which has the following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118745#comment-14118745
]
ASF subversion and git services commented on SOLR-6073:
---
Commit 1622126 from [~anshumg] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1622126 ]
SOLR-6073: Deprecate helper methods for CollectionsAPI SolrJ calls. Move
towards using builder design for the calls.
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Assignee: Anshum Gupta
Fix For: 5.0, 4.11
Attachments: SOLR-6073-4x.patch, SOLR-6073-4x.patch, SOLR-6073.patch,
SOLR-6073.patch
In the process also cleanup the following: The CollectionAdminRequest has a
createCollection() method which has the following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118754#comment-14118754
]
ASF subversion and git services commented on SOLR-6073:
---
Commit 1622129 from [~anshumg] in branch 'dev/trunk'
[ https://svn.apache.org/r1622129 ]
SOLR-6073: Adding names to CHANGES.txt
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Assignee: Anshum Gupta
Fix For: 5.0, 4.11
Attachments: SOLR-6073-4x.patch, SOLR-6073-4x.patch, SOLR-6073.patch,
SOLR-6073.patch
In the process also cleanup the following: The CollectionAdminRequest has a
createCollection() method which has the following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118756#comment-14118756
]
ASF subversion and git services commented on SOLR-6073:
---
Commit 1622131 from [~anshumg] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1622131 ]
SOLR-6073: Adding names to CHANGES.txt
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Assignee: Anshum Gupta
Fix For: 5.0, 4.11
Attachments: SOLR-6073-4x.patch, SOLR-6073-4x.patch, SOLR-6073.patch,
SOLR-6073.patch
In the process also cleanup the following: The CollectionAdminRequest has a
createCollection() method which has the following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1451#comment-1451
]
Varun Thacker commented on SOLR-6073:
-
bq. Removing the N create methods is enough.
This would be done on both trunk and branch_4x?
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Fix For: 4.9, 5.0
The CollectionAdminRequest has a createCollection() method which has the
following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998681#comment-13998681
]
Varun Thacker commented on SOLR-6073:
-
There are a few createCollection methods with hardcoded router=compositeId'
also.
Would this be a correct approach going forward ?
Rename Create to CreateCollection which takes the collection name and the
remaining params can be set using the setters.
Then have users create the CreateCollection object and the call
req.process(server);
Something like -
{noformat}
CreateCollection req = new CreateCollection(collection1);
req.setConfigName();
...
req.process(server)
{noformat}
We could then deprecate all the createCollection methods in 4.x
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Fix For: 4.9, 5.0
The CollectionAdminRequest has a createCollection() method which has the
following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997545#comment-13997545
]
Shalin Shekhar Mangar commented on SOLR-6073:
-
Actually, a Create class already exists inside CollectionAdminRequest.
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Fix For: 4.9, 5.0
The CollectionAdminRequest has a createCollection() method which has the
following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6073) CollectionAdminRequest has createCollection methods with hard-coded router=implicit
[
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997534#comment-13997534
]
Noble Paul commented on SOLR-6073:
--
There are 8 overloaded methods for createcollection. We should just get rid of
all of them and make users pass the Create Obect to a single createCollection
method
CollectionAdminRequest has createCollection methods with hard-coded
router=implicit
-
Key: SOLR-6073
URL: https://issues.apache.org/jira/browse/SOLR-6073
Project: Solr
Issue Type: Bug
Components: clients - java, SolrCloud
Affects Versions: 4.8
Reporter: Shalin Shekhar Mangar
Fix For: 4.9, 5.0
The CollectionAdminRequest has a createCollection() method which has the
following hard-coded:
{code}
req.setRouterName(implicit);
{code}
This is a bug and we should remove it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
