[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711411#comment-14711411 ] Scott Blum commented on SOLR-6629: -- Yay! Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Fix For: Trunk, 5.4 Attachments: SOLR-6629-new.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711236#comment-14711236 ] ASF subversion and git services commented on SOLR-6629: --- Commit 1697670 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697670 ] SOLR-6629: Watch /collections zk node on all nodes Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Fix For: Trunk, 5.4 Attachments: SOLR-6629-new.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709456#comment-14709456 ] Shalin Shekhar Mangar commented on SOLR-6629: - [~dragonsinth] - did you upload the right patch? I still see caching in LazyCollectionRef. Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Fix For: Trunk Attachments: SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710641#comment-14710641 ] ASF subversion and git services commented on SOLR-6629: --- Commit 1697562 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1697562 ] SOLR-6629: Watch /collections zk node on all nodes Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Fix For: Trunk Attachments: SOLR-6629-new.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch, SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705599#comment-14705599 ] Shalin Shekhar Mangar commented on SOLR-6629: - bq. In ZkStateReader#refreshCollectionList, how do you ensure that a stateFormat=1 collection which is not interesting to us, isn't put into the lazyCollectionStates map? Or does it not matter because constructState() will always give priority to the ones in shared cluster state? Hmm, answering my own question, this indeed looks deliberate and seems like a clever way of avoiding the ZK exists call for state.json! Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk Attachments: SOLR-6629.patch, SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702178#comment-14702178 ] Scott Blum commented on SOLR-6629: -- [~shalinmangar] ping for review Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk Attachments: SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700238#comment-14700238 ] Scott Blum commented on SOLR-6629: -- Added another patch, demonstrating the Lazy Collection caching. Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk Attachments: SOLR-6629.patch The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680507#comment-14680507 ] Scott Blum commented on SOLR-6629: -- Now that SOLR-5756 is landed, can we flesh this ticket out some more? Does this boil down to watchChildren on /collections at all times, and actively manage the lazy-loaded collection state list? Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680535#comment-14680535 ] Noble Paul commented on SOLR-6629: -- yes Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680780#comment-14680780 ] Scott Blum commented on SOLR-6629: -- Note: LegacyClusterStateWatcher.refreshAndWatch() is what currently triggers refreshLazyFormat2Collections(). In other words, refreshes on the lazy collection set are tied to changes in shared clusterstate.json. A better solution would be to do a child watch on /collections instead and completely decouple the lazy collection set from changes to clusterstate.json. This might also involve tracking down any overseer code that forces a now-unnecessary clusterstate.json mutation purely as a signal. Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6629) Watch /collections zk node on all nodes
[ https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652385#comment-14652385 ] Scott Blum commented on SOLR-6629: -- Might get some love as part of SOLR-5756 Watch /collections zk node on all nodes --- Key: SOLR-6629 URL: https://issues.apache.org/jira/browse/SOLR-6629 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Noble Paul Fix For: Trunk The main clusterstate.json is refreshed/used as a poor substitute for informing all nodes about new or deleted collections even when the collection being created or deleted has state format 1. When we move away from state format 1 then we should do away with this workaround and start watching the /collections zk node on all nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
