[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335093#comment-16335093
]
Ishan Chattopadhyaya commented on SOLR-6630:
bq. ping
Had dropped the ball on this; I'll pick it up next (after about 2-3 issues I'm
currently working on).
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Assignee: Ishan Chattopadhyaya
>Priority: Major
> Fix For: 7.0
>
> Attachments: SOLR-6630.patch, SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334890#comment-16334890
]
Jan Høydahl commented on SOLR-6630:
---
ping
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Assignee: Ishan Chattopadhyaya
>Priority: Major
> Fix For: 7.0
>
> Attachments: SOLR-6630.patch, SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099035#comment-16099035
]
Ishan Chattopadhyaya commented on SOLR-6630:
Anshum, unfortunately, I'll be unable to get to this until 28th August. I'm
unmarking this as a blocker as per Noble's comment [0].
[0] -
https://issues.apache.org/jira/browse/SOLR-6630?focusedCommentId=16062482=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16062482
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
> Fix For: 7.0
>
> Attachments: SOLR-6630.patch, SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099009#comment-16099009
]
Anshum Gupta commented on SOLR-6630:
[~ichattopadhyaya] are you actively working on this?
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-6630.patch, SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078306#comment-16078306
]
Yonik Seeley commented on SOLR-6630:
+1 for "manual". "explicit" doesn't really right when the route isn't
explicitly set in the document or on the update command, and "custom" or
"userDefined" suggest you need to configure/set something up.
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062482#comment-16062482
]
Noble Paul commented on SOLR-6630:
--
We can fix this even after 7.0 as long as it doesn't break backcompat. So,
IMHO, it doesn't have to be a blocker for 7.0 release
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032707#comment-16032707
]
Ishan Chattopadhyaya commented on SOLR-6630:
> Anything is better than "implicit".
I like "explicit" better than "manual", since "manual" has the implication than
it needs to be set "by hand", which is not exactly the case if done through
user's SolrJ program (which then becomes "programmatic" rather than "by hand").
I think this difference is subtle, and I'm -0 on "manual".
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975379#comment-15975379
]
David Smiley commented on SOLR-6630:
Anything is better than "implicit". Explicit, Manual, and Custom are all good
to me!
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975377#comment-15975377
]
Jan Høydahl commented on SOLR-6630:
---
I like "manual", let's stick to the original plan :-) It says it all, there is
nothing automatic about it, user/client has to *manually* take care of routing.
In my head, weirdly, even "explicit" would be better than "implicit", as the
user/client needs to explicitly define routing, Solr won't do it for you ;-)
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975331#comment-15975331
]
Shawn Heisey commented on SOLR-6630:
Thanks for the good discussion with names that I never thought of when I opened
this issue.
Although the length of "userDefined" worries me a little bit, and the mixed
case might lead to users mis-typing the configuration, I can only think of one
real concern: This wording implies that there is a configuration they can
examine/edit that configures the routing definition. Since my whole point was
to eliminate ambiguity, I think that using that particular term is no better
than "implicit". I think that "custom" carries the same implication.
Some of the suggestions put forth by [~steve_rowe] are intriguing. I really
like "null" ... but that particular string is something you want to completely
avoid in most programming environments, particularly Java.
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974752#comment-15974752
]
Steve Rowe commented on SOLR-6630:
--
bq. I'd suggest to rename the implicit router to "userDefined".
So this belongs to a third emphasis category:
* Emphasizing that routing is the client's responsibility, not the server's:
"manual", "custom", "userDefined"
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974743#comment-15974743
]
Trey Cahill commented on SOLR-6630:
---
I'd suggest to rename the implicit router to "userDefined".
I think it would provide the least amount of ambiguity to a new user, as when
using it, the user defines what shard documents are sent too.
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974683#comment-15974683
]
Steve Rowe commented on SOLR-6630:
--
bq. Another alternative to "manual" that came to mind was "custom".
To me "custom" implies configurable variability, which is not what's going on.
Some more alternatives:
* Emphasizing the fact the implicit router does nothing: "null", "void", "no-op"
* Emphasizing the non-displacing aspect of the implicit router's function:
"in-place", "in-situ", "static"
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Reporter: Shawn Heisey
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974048#comment-15974048
]
Ishan Chattopadhyaya commented on SOLR-6630:
I'd like to have this in by 7.0. Another alternative to "manual" that came to
mind was "custom".
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Affects Versions: 4.10
>Reporter: Shawn Heisey
> Fix For: 5.0, 6.0
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the "implicit" router and rename to "manual"
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946333#comment-14946333
]
Shawn Heisey commented on SOLR-6630:
A lot of the user confusion on this likely resulted from incorrect
documentation in the reference guide for the Collections API ... the
descriptions for "implicit" and "compositeId" were switched. That
documentation error has been corrected.
> Deprecate the "implicit" router and rename to "manual"
> --
>
> Key: SOLR-6630
> URL: https://issues.apache.org/jira/browse/SOLR-6630
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
>Affects Versions: 4.10
>Reporter: Shawn Heisey
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6630.patch
>
>
> I had this exchange with an IRC user named "kindkid" this morning:
> {noformat}
> 08:30 < kindkid> I'm using sharding with the implicit router, but I'm seeing
> all my documents end up on just one of my 24 shards. What
> might be causing this? (4.10.0)
> 08:35 <@elyograg> kindkid: you used the implicit router. that means that
> documents will be indexed on the shard you sent them
> to, not
> routed elsewhere.
> 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under the
> impression that implicit router would use a hash of the
> uniqueKey modulo number of shards to pick a shard.
> 08:38 <@elyograg> I think you probably wanted the compositeId router.
> 08:39 <@elyograg> implicit is not a very good name. It's technically
> correct,
> but the meaning of the word is not well known.
> 08:39 <@elyograg> "manual" would be a better name.
> {noformat}
> The word "implicit" has a very specific meaning, and I think it's
> absolutely correct terminology for what it does, but I don't think that
> it's very clear to a typical person. This is not the first time I've
> encountered the confusion.
> Could we deprecate the implicit name and use something much more
> descriptive and easily understood, like "manual" instead? Let's go
> ahead and accept implicit in 5.x releases, but issue a warning in the
> log. Maybe we can have a startup system property or a config option
> that will force the name to be updated in zookeeper and get rid of the
> warning. If we do this, my bias is to have an upgrade to 6.x force the
> name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207153#comment-14207153
]
Shawn Heisey commented on SOLR-6630:
Additional thoughts for what the change should accomplish:
* An attempt to create a collection with router.name=implicit should fail.
Ideally the error response would indicate that manual should be used instead,
if that's not really difficult to implement. I could be persuaded that this is
going too far, but 5.0 is the first release where this might happen, and it's a
new major version ... changes in external API should be expected.
* An existing collection with the implicit router should continue to work
through 5.x releases, with a warning in the log at startup.
* For 5.x, I'd like to have a run once option
(-DupdateDeprecatedZkConfig=true is one idea), admin UI button, and/or API call
that would force an update to deprecated data like this in zookeeper. Manually
editing ZK (perhaps with something like the ZK plugin for Eclipse) would always
be an option for an expert user.
* If a 6.x version finds implicit, it should immediately change it to manual.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207227#comment-14207227
]
Shalin Shekhar Mangar commented on SOLR-6630:
-
bq. An attempt to create a collection with router.name=implicit should fail.
Ideally the error response would indicate that manual should be used instead,
if that's not really difficult to implement. I could be persuaded that this is
going too far, but 5.0 is the first release where this might happen, and it's a
new major version ... changes in external API should be expected.
+1
bq. An existing collection with the implicit router should continue to work
through 5.x releases, with a warning in the log at startup.
+1 but a warning is not really required because the user didn't do anything
wrong here.
bq. For 5.x, I'd like to have a run once option
(-DupdateDeprecatedZkConfig=true is one idea), admin UI button, and/or API call
that would force an update to deprecated data like this in zookeeper. Manually
editing ZK (perhaps with something like the ZK plugin for Eclipse) would always
be an option for an expert user.
Instead of that we can support both implicit and manual as the router.name
in the clusterstate.json as you said and then in 5.1 the overseer can
automatically rename implicit to manual and things will just continue to
work.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207241#comment-14207241
]
Yonik Seeley commented on SOLR-6630:
bq. Instead of that we can support both implicit and manual as the
router.name in the clusterstate.json as you said and then in 5.1 the overseer
can automatically rename implicit to manual and things will just continue
to work.
Yep. Also, clusterstate is often re-written when something changes. If we
read implicit as manual on the read side, then conversion will quickly
happen automatically?
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207269#comment-14207269
]
Shalin Shekhar Mangar commented on SOLR-6630:
-
bq. If we read implicit as manual on the read side, then conversion will
quickly happen automatically?
Yes, I think we're talking about the same thing.
# Read side will map implicit and manual to the same router
# Overseer in 5.1 and beyond will rename implicit to manual automatically
# The read side will continue to handle both implicit and manual throughout
5.x and will be removed in 6.0. This has to be there to provide back-compat
because we can't guarantee that people will migrate to 5.0 - 5.1 and then to
further versions.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14184143#comment-14184143
]
Shawn Heisey commented on SOLR-6630:
I did not think about svn copy which is probably a better option than all the
renames. I will try it, see if I end up with the same svn stat output.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14184149#comment-14184149
]
Shawn Heisey commented on SOLR-6630:
Followup -- the commandline tool svn log on Windows does show appropriate
history when doing both svn copy and svn rename. That means that the pre-patch
operation is much simpler than I described earlier -- just a single svn copy:
{noformat}
svn copy
solr/solrj/src/java/org/apache/solr/common/cloud/ImplicitDocRouter.java
solr/solrj/src/java/org/apache/solr/common/cloud/ManualDocRouter.java
{noformat}
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
Attachments: SOLR-6630.patch
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178169#comment-14178169
]
Upayavira commented on SOLR-6630:
-
and rename compositeID to just 'id' or 'hashed-id' or something. composite ID
routing also handles IDs that *aren't* composite, which is a major brain bender.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178389#comment-14178389
]
Shawn Heisey commented on SOLR-6630:
[~upayavira], I would guess that the majority of SolrCloud users are either
using compositeId or have chosen to build a single-shard index -- defaulting to
implicit, but where the router choice doesn't really matter because there's one
shard. Renaming implicit will (hopefully) not directly impact a big chunk of
the installed userbase. A change to compositeId would have much greater user
impact.
The rename of implicit will already be a far-reaching change that might come
back to bite us in ways we never expected. A rename of compositeId, if we do
it at all, needs to be done later, after we figure out the pitfalls from THIS
rename.
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177480#comment-14177480
]
Jan Høydahl commented on SOLR-6630:
---
+1 to rename!
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6630) Deprecate the implicit router and rename to manual
[
https://issues.apache.org/jira/browse/SOLR-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173882#comment-14173882
]
Shawn Heisey commented on SOLR-6630:
My free time has been somewhat limited lately, but I will try to cook up some
initial ideas in a patch. If someone else wants to jump on it, feel free!
Deprecate the implicit router and rename to manual
--
Key: SOLR-6630
URL: https://issues.apache.org/jira/browse/SOLR-6630
Project: Solr
Issue Type: Task
Components: SolrCloud
Affects Versions: 4.10
Reporter: Shawn Heisey
Fix For: 5.0, Trunk
I had this exchange with an IRC user named kindkid this morning:
{noformat}
08:30 kindkid I'm using sharding with the implicit router, but I'm seeing
all my documents end up on just one of my 24 shards. What
might be causing this? (4.10.0)
08:35 @elyograg kindkid: you used the implicit router. that means that
documents will be indexed on the shard you sent them
to, not
routed elsewhere.
08:37 kindkid oh. wow. not sure where I got the idea, but I was under the
impression that implicit router would use a hash of the
uniqueKey modulo number of shards to pick a shard.
08:38 @elyograg I think you probably wanted the compositeId router.
08:39 @elyograg implicit is not a very good name. It's technically
correct,
but the meaning of the word is not well known.
08:39 @elyograg manual would be a better name.
{noformat}
The word implicit has a very specific meaning, and I think it's
absolutely correct terminology for what it does, but I don't think that
it's very clear to a typical person. This is not the first time I've
encountered the confusion.
Could we deprecate the implicit name and use something much more
descriptive and easily understood, like manual instead? Let's go
ahead and accept implicit in 5.x releases, but issue a warning in the
log. Maybe we can have a startup system property or a config option
that will force the name to be updated in zookeeper and get rid of the
warning. If we do this, my bias is to have an upgrade to 6.x force the
name change in zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
