[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266702#comment-14266702 ] ASF subversion and git services commented on SOLR-6766: --- Commit 1649939 from [~markrmil...@gmail.com] in branch 'dev/trunk' [ https://svn.apache.org/r1649939 ] SOLR-6766: Expose HdfsDirectoryFactory Block Cache statistics via JMX. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch, SOLR-6766.patch, SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266708#comment-14266708 ] ASF subversion and git services commented on SOLR-6766: --- Commit 1649941 from [~markrmil...@gmail.com] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649941 ] SOLR-6766: Expose HdfsDirectoryFactory Block Cache statistics via JMX. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Fix For: 5.0, Trunk Attachments: SOLR-6766.patch, SOLR-6766.patch, SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229845#comment-14229845 ] Mark Miller commented on SOLR-6766: --- bq. Is this aimed at 4.10.3? 4.10.3 is a bug fix release - the fact that the code exists but is not hooked up could allow one to try and stretch it to 4.10.3 - along with the idea that there will be no more 4.x releases. No plans on it right now though. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch, SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223491#comment-14223491 ] Mark Miller commented on SOLR-6766: --- +1 - shaping up nicely. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223754#comment-14223754 ] Otis Gospodnetic commented on SOLR-6766: Is this aimed at 4.10.3? Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch, SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223785#comment-14223785 ] Mike Drob commented on SOLR-6766: - I build the patch against trunk, but it could probably go into branch-5. I think it applies pretty cleanly to branch-4 as well, but I haven't looked at it that closely. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch, SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221011#comment-14221011 ] Mark Miller commented on SOLR-6766: --- The block cache should normally just be one now that the global block cache is enabled by default. The per directory version should be special case at best. Perhaps the HdfsDirectoryFactory could simply track all the Metrics objects and spit out the stats for the caches (normally 1) that it tracks. If everything is keyed on HdfsDirectoryFactory as the info bean, nothing else has to be changed. Just spitballing though. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221115#comment-14221115 ] Mark Miller commented on SOLR-6766: --- bq. I think it works for both the global cache and local cache options because it uses the same Metrics object for everything. Oh cool, well that simplifies things. I'll take a look at this shortly. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[ https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221124#comment-14221124 ] Mike Drob commented on SOLR-6766: - I didn't rename any of the metrics yet because that should be a fairly easy change to make. Trying to get the structure of the changeset correct, first. Switch o.a.s.store.blockcache.Metrics to use JMX Key: SOLR-6766 URL: https://issues.apache.org/jira/browse/SOLR-6766 Project: Solr Issue Type: Bug Reporter: Mike Drob Labels: metrics Attachments: SOLR-6766.patch The Metrics class currently reports to hadoop metrics, but it would be better to report to JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6766) Switch o.a.s.store.blockcache.Metrics to use JMX
[
https://issues.apache.org/jira/browse/SOLR-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219623#comment-14219623
]
Mike Drob commented on SOLR-6766:
-
[~markrmil...@gmail.com] - Continuing discussion from SOLR-6752...
{quote}
I fired up Solr on HDFS with JMX enabled and took a look at the exported mbeans
with JConsole. I did not see anything for the block cache.
I'd look at how SolrResourceLoader adds the plugins that it loads to the
JmxMonitoredMap.
{quote}
Been digging deeper into this... metrics are tracked on a per-core basis. Each
core has an {{infoRegistry}} that is populated in the constructor either
directly or from beans that the SolrResourceLoader had previously created. So
instead of creating a new Metrics object directly, we will need to create one
through the {{SolrResourceLoader.newInstance()}}, which is I think what you
were suggesting.
The trick here is that we need to create the bean before the {{SolrCore}}
finishes constructing, but after the {{HdfsDirectoryFactory}} (HDF) exists to
make sure that it gets registered in time. So basically, in the no-arg HDF
constructor is our only option. The problem is that HDF (or any implementation
of {{DirectoryFactory}}) is not aware of the resource loader or even a
{{SolrConfig}} to be able to acquire a reference to the resource loader. I'm
hesitant to add a {{setResourceLoader}} method or similar on
{{DirectoryFactory}} because that is starting to feel very intrusive, but I
also don't see another way to plumb this through.
Switch o.a.s.store.blockcache.Metrics to use JMX
Key: SOLR-6766
URL: https://issues.apache.org/jira/browse/SOLR-6766
Project: Solr
Issue Type: Bug
Reporter: Mike Drob
Labels: metrics
The Metrics class currently reports to hadoop metrics, but it would be better
to report to JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
