[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231325#comment-14231325 ] Per Steffensen commented on SOLR-6796: -- Maybe I can convince you to take a look at SOLR-6812 also, [~shalinmangar]? distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: fix.patch, fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231448#comment-14231448 ] Shalin Shekhar Mangar commented on SOLR-6796: - I'll take a look at SOLR-6812 and SOLR-6813 too but I know very little about ExpandComponent so if things get too hairy, I'll probably defer to someone else. distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: SOLR-6796.patch, fix.patch, fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231502#comment-14231502 ] ASF subversion and git services commented on SOLR-6796: --- Commit 1642873 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1642873 ] SOLR-6796: distrib.singlePass does not return correct set of fields for multi-fl-parameter requests distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: SOLR-6796.patch, fix.patch, fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231505#comment-14231505 ] ASF subversion and git services commented on SOLR-6796: --- Commit 1642874 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642874 ] SOLR-6796: distrib.singlePass does not return correct set of fields for multi-fl-parameter requests distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: SOLR-6796.patch, fix.patch, fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231521#comment-14231521 ] ASF subversion and git services commented on SOLR-6796: --- Commit 1642876 from sha...@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1642876 ] SOLR-6796: distrib.singlePass does not return correct set of fields for multi-fl-parameter requests distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: SOLR-6796.patch, fix.patch, fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226909#comment-14226909 ] Shalin Shekhar Mangar commented on SOLR-6796: - Thanks Per. I've assigned the other issue to myself too. I'm travelling today and tomorrow but I will review and commit the fixes by the weekend. distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226930#comment-14226930 ] Yonik Seeley commented on SOLR-6796: Both the original code and the patches seem more complex than needed why is it necessary to rebuild the fl parameter rather than just append another (it's multi-valued)? distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227348#comment-14227348 ] Per Steffensen commented on SOLR-6796: -- bq. Both the original code and the patches seem more complex than needed I agree. I didnt want to spend much time making it less complex. Just wanted it to work. When I have brought cleaned up code in the past, I hasnt been appreciated much. Some times it has been rejected with an argument about creating another issue for cleanup. distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: fix.patch, fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6796) distrib.singlePass does not return correct set of fields for multi-fl-parameter requests
[ https://issues.apache.org/jira/browse/SOLR-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225874#comment-14225874 ] Per Steffensen commented on SOLR-6796: -- Thanks for assigning yourself to this one [~shalinmangar]. Maybe you also want to take a look at SOLR-6795? SOLR-6795 is ready for commit. Lets make this SOLR-6796 about making distrib.singlePass work in every case. Believe the ugly patch will work in every case, but the less ugly patch will not. It will not work for e.g. val:sum(3,4). I will provide a less ugly patch very soon that will work in every case. distrib.singlePass does not return correct set of fields for multi-fl-parameter requests Key: SOLR-6796 URL: https://issues.apache.org/jira/browse/SOLR-6796 Project: Solr Issue Type: Bug Components: multicore, search Affects Versions: 5.0 Reporter: Per Steffensen Assignee: Shalin Shekhar Mangar Labels: distributed_search, search Attachments: fix.patch, fix.patch, test_that_reveals_the_problem.patch If I pass distrib.singlePass in a request that also has two fl-parameters, in some cases, I will not get the expected set of fields back for the returned documents -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
