[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264534#comment-14264534 ] ASF GitHub Bot commented on SOLR-6907: -- Github user andyetitmoves closed the pull request at: https://github.com/apache/lucene-solr/pull/124 URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907-2.patch, SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263929#comment-14263929 ] ASF subversion and git services commented on SOLR-6907: --- Commit 1649383 from [~erickoerickson] in branch 'dev/trunk' [ https://svn.apache.org/r1649383 ] SOLR-6907: URLEncode documents directory in MorphlineMapperTest to handle spaces etc in file name URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263937#comment-14263937 ] ASF subversion and git services commented on SOLR-6907: --- Commit 1649386 from [~erickoerickson] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649386 ] SOLR-6907: URLEncode documents directory in MorphlineMapperTest to handle spaces etc in file name URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Attachments: SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263953#comment-14263953 ] Ramkumar Aiyengar commented on SOLR-6907: - Erick, I think this contains the first version of the patch, without Uwe's suggestions.. URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264021#comment-14264021 ] Erick Erickson commented on SOLR-6907: -- OK, could you create a proper patch file and attach it then? That's the usual way patches are submitted, and it allows the author to insure that the right code is current. It also keeps a permanent record of the change not dependent on an external repo. Once you do I'll commit it. Please make it a delta to the newly-committed code rather than from the original. Thanks, URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264131#comment-14264131 ] ASF subversion and git services commented on SOLR-6907: --- Commit 1649455 from [~erickoerickson] in branch 'dev/trunk' [ https://svn.apache.org/r1649455 ] SOLR-6907, corrected patch, URLEncode documents directory in MorphlineMapperTest to handle spaces etc in file name URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907-2.patch, SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264133#comment-14264133 ] ASF subversion and git services commented on SOLR-6907: --- Commit 1649457 from [~erickoerickson] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649457 ] SOLR-6907, corrected patch, URLEncode documents directory in MorphlineMapperTest to handle spaces etc in file name URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907-2.patch, SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264134#comment-14264134 ] Erick Erickson commented on SOLR-6907: -- Done, thanks! URLEncode documents directory in MorphlineMapperTest to handle spaces etc. in file name --- Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Fix For: 5.0, Trunk Attachments: SOLR-6907-2.patch, SOLR-6907.patch Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263599#comment-14263599 ] wolfgang hoschek commented on SOLR-6907: +1 Looks reasonable to me. URLEncode documents directory in MorphlineMapperTest Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Priority: Minor Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263569#comment-14263569 ] ASF GitHub Bot commented on SOLR-6907: -- GitHub user andyetitmoves opened a pull request: https://github.com/apache/lucene-solr/pull/124 URLEncode documents directory in MorphlineMapperTest https://issues.apache.org/jira/browse/SOLR-6907 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-url-encode-hdfs-paths Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit ae0009e1c9077caebaef05adee8595bf4aef1e6e Author: Ramkumar Aiyengar andyetitmo...@gmail.com Date: 2015-01-03T14:41:28Z URLEncode documents directory in MorphlineMapperTest URLEncode documents directory in MorphlineMapperTest Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Priority: Minor Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest
[
https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263676#comment-14263676
]
Uwe Schindler commented on SOLR-6907:
-
I have never seen this issue on the famous Uwe Schindler username ... but
windows disabled those tests :-)
In fact, URLEncoder is not the correct way to do it, because it use + for
whitespace... Unfortunately, Java has no non-form-encoded URL encoder, so you
would do {{{.replace(+, %20)}} (not replaceAll The CharSequence one!!!)
URLEncode documents directory in MorphlineMapperTest
Key: SOLR-6907
URL: https://issues.apache.org/jira/browse/SOLR-6907
Project: Solr
Issue Type: Bug
Components: contrib - MapReduce, Tests
Reporter: Ramkumar Aiyengar
Assignee: Erick Erickson
Priority: Minor
Currently the test fails if the source is checked out on a directory whose
path contains, say spaces..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6907) URLEncode documents directory in MorphlineMapperTest
[ https://issues.apache.org/jira/browse/SOLR-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263686#comment-14263686 ] Ramkumar Aiyengar commented on SOLR-6907: - Thanks Uwe, updated the patch. Curiously though the test did pass the first time around.. URLEncode documents directory in MorphlineMapperTest Key: SOLR-6907 URL: https://issues.apache.org/jira/browse/SOLR-6907 Project: Solr Issue Type: Bug Components: contrib - MapReduce, Tests Reporter: Ramkumar Aiyengar Assignee: Erick Erickson Priority: Minor Currently the test fails if the source is checked out on a directory whose path contains, say spaces.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
