[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051577#comment-15051577
]
Shawn Heisey commented on SOLR-6992:
Go ahead. I'm finding my availability lately to be low. It's irritating when
$JOB and $LIFE intrude. :)
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch, SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050489#comment-15050489
]
Varun Thacker commented on SOLR-6992:
-
Hi [~elyograg],
I tried out the patch. The `managed-schema` file does come up but clicking on
it still doesn't show the data within it. Digging into why
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050571#comment-15050571
]
Upayavira commented on SOLR-6992:
-
This all looks good to me.
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch, SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050578#comment-15050578
]
Varun Thacker commented on SOLR-6992:
-
Thanks Upayavira !
Shawn, would you like to commit it? Else I can
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch, SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052216#comment-15052216
]
ASF subversion and git services commented on SOLR-6992:
---
Commit 1719261 from [~varunthacker] in branch 'dev/trunk'
[ https://svn.apache.org/r1719261 ]
SOLR-6992: Fix Files UI to show the managed-schema file as well
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch, SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052217#comment-15052217
]
ASF subversion and git services commented on SOLR-6992:
---
Commit 1719263 from [~varunthacker] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1719263 ]
SOLR-6992: Fix Files UI to show the managed-schema file as well (merged trunk
r1719261)
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: Trunk, 5.5
>
> Attachments: SOLR-6992.patch, SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034598#comment-15034598
]
Alexandre Rafalovitch commented on SOLR-6992:
-
So, I guess we are not making this one into 5.4? We should at least fix the
headers for the next time then.
> ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
> ---
>
> Key: SOLR-6992
> URL: https://issues.apache.org/jira/browse/SOLR-6992
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Alexandre Rafalovitch
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: 5.0
>
> Attachments: SOLR-6992.patch
>
>
> When using dynamic schema, the schema file is not shown in the admin UI
> (Files tab) by default. It is hidden because (as per [the section
> comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
> {quote}
> // Make sure that if the schema is managed, we don't allow editing.
> {quote}
> But we don't have editing interface for those files (SOLR-5287 was backed
> out), so the reason is not valid and makes reviewing schema just that bit
> harder.
> The fix is probably just editing out that section, unless there are tests
> specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6992) ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
[
https://issues.apache.org/jira/browse/SOLR-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604862#comment-14604862
]
Alexandre Rafalovitch commented on SOLR-6992:
-
Could someone please review this.
It really present inconsistent Files view in Admin UI when comparing
data-driven and schema.xml style cores.
ShowFileRequestHandler is hiding dynamic schema file even in read-only mode
---
Key: SOLR-6992
URL: https://issues.apache.org/jira/browse/SOLR-6992
Project: Solr
Issue Type: Bug
Affects Versions: 5.0
Reporter: Alexandre Rafalovitch
Priority: Minor
Fix For: 5.0
When using dynamic schema, the schema file is not shown in the admin UI
(Files tab) by default. It is hidden because (as per [the section
comment|https://github.com/apache/lucene-solr/blob/db33df44c037e04fea9ac3e391ef79c0d6ae04f4/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java#L279]):
{quote}
// Make sure that if the schema is managed, we don't allow editing.
{quote}
But we don't have editing interface for those files (SOLR-5287 was backed
out), so the reason is not valid and makes reviewing schema just that bit
harder.
The fix is probably just editing out that section, unless there are tests
specifically for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
