[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098140#comment-15098140
]
Mark Miller commented on SOLR-7183:
---
This test fails a lot on our Jenkins cluster, but it seems unrelated to this,
so I've filed SOLR-8544.
> SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
> ---
>
> Key: SOLR-7183
> URL: https://issues.apache.org/jira/browse/SOLR-7183
> Project: Solr
> Issue Type: Bug
>Reporter: Hoss Man
>Assignee: Gregory Chanan
> Fix For: 5.2
>
> Attachments: SOLR-7183.patch
>
>
> SaslZkACLProviderTest has this blacklist of locales...
> {code}
> // These Locales don't generate dates that are compatibile with Hadoop
> MiniKdc.
> protected final static List brokenLocales =
> Arrays.asList(
> "th_TH_TH_#u-nu-thai",
> "ja_JP_JP_#u-ca-japanese",
> "hi_IN");
> {code}
> ..but this list is incomplete -- notably because it only focuses on one
> specific Thai variant, and then does a string Locale.toString() comparison.
> so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
> other variants that will fail as well
> * if there is a bug in "Hadoop MiniKdc" then that bug should be filed in
> jira, and there should be Solr jira that refers to it -- the Solr jira URL
> needs to be included her in the test case so developers in the future can
> understand the context and have some idea of if/when the third-party lib bug
> is fixed
> * if we need to work around some Locales because of this bug, then Locale
> comparisons need be based on whatever aspects of the Locale are actually
> problematic
> see for example SOLR-6387 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676=1618675=1618676
> Or SOLR-6991 + TIKA-1526 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708=1653707=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037571#comment-15037571
]
Uwe Schindler commented on SOLR-7183:
-
I think we should add a link from this issue to the HadoopMiniKDC issue (if it
exists) and then set this issue to state "pending" or like that.
> SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
> ---
>
> Key: SOLR-7183
> URL: https://issues.apache.org/jira/browse/SOLR-7183
> Project: Solr
> Issue Type: Bug
>Reporter: Hoss Man
>Assignee: Gregory Chanan
> Fix For: 5.2
>
> Attachments: SOLR-7183.patch
>
>
> SaslZkACLProviderTest has this blacklist of locales...
> {code}
> // These Locales don't generate dates that are compatibile with Hadoop
> MiniKdc.
> protected final static List brokenLocales =
> Arrays.asList(
> "th_TH_TH_#u-nu-thai",
> "ja_JP_JP_#u-ca-japanese",
> "hi_IN");
> {code}
> ..but this list is incomplete -- notably because it only focuses on one
> specific Thai variant, and then does a string Locale.toString() comparison.
> so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
> other variants that will fail as well
> * if there is a bug in "Hadoop MiniKdc" then that bug should be filed in
> jira, and there should be Solr jira that refers to it -- the Solr jira URL
> needs to be included her in the test case so developers in the future can
> understand the context and have some idea of if/when the third-party lib bug
> is fixed
> * if we need to work around some Locales because of this bug, then Locale
> comparisons need be based on whatever aspects of the Locale are actually
> problematic
> see for example SOLR-6387 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676=1618675=1618676
> Or SOLR-6991 + TIKA-1526 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708=1653707=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032698#comment-15032698
]
Gregory Chanan commented on SOLR-7183:
--
[~anshumg] should this be marked resolved?
> SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
> ---
>
> Key: SOLR-7183
> URL: https://issues.apache.org/jira/browse/SOLR-7183
> Project: Solr
> Issue Type: Bug
>Reporter: Hoss Man
>Assignee: Gregory Chanan
> Fix For: 5.2
>
> Attachments: SOLR-7183.patch
>
>
> SaslZkACLProviderTest has this blacklist of locales...
> {code}
> // These Locales don't generate dates that are compatibile with Hadoop
> MiniKdc.
> protected final static List brokenLocales =
> Arrays.asList(
> "th_TH_TH_#u-nu-thai",
> "ja_JP_JP_#u-ca-japanese",
> "hi_IN");
> {code}
> ..but this list is incomplete -- notably because it only focuses on one
> specific Thai variant, and then does a string Locale.toString() comparison.
> so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
> other variants that will fail as well
> * if there is a bug in "Hadoop MiniKdc" then that bug should be filed in
> jira, and there should be Solr jira that refers to it -- the Solr jira URL
> needs to be included her in the test case so developers in the future can
> understand the context and have some idea of if/when the third-party lib bug
> is fixed
> * if we need to work around some Locales because of this bug, then Locale
> comparisons need be based on whatever aspects of the Locale are actually
> problematic
> see for example SOLR-6387 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676=1618675=1618676
> Or SOLR-6991 + TIKA-1526 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708=1653707=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908024#comment-14908024
]
Uwe Schindler commented on SOLR-7183:
-
DIRAPI-219 was solved now. Looks like a bugfix relaese was done!?
> SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
> ---
>
> Key: SOLR-7183
> URL: https://issues.apache.org/jira/browse/SOLR-7183
> Project: Solr
> Issue Type: Bug
>Reporter: Hoss Man
>Assignee: Gregory Chanan
> Fix For: 5.2
>
> Attachments: SOLR-7183.patch
>
>
> SaslZkACLProviderTest has this blacklist of locales...
> {code}
> // These Locales don't generate dates that are compatibile with Hadoop
> MiniKdc.
> protected final static List brokenLocales =
> Arrays.asList(
> "th_TH_TH_#u-nu-thai",
> "ja_JP_JP_#u-ca-japanese",
> "hi_IN");
> {code}
> ..but this list is incomplete -- notably because it only focuses on one
> specific Thai variant, and then does a string Locale.toString() comparison.
> so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
> other variants that will fail as well
> * if there is a bug in "Hadoop MiniKdc" then that bug should be filed in
> jira, and there should be Solr jira that refers to it -- the Solr jira URL
> needs to be included her in the test case so developers in the future can
> understand the context and have some idea of if/when the third-party lib bug
> is fixed
> * if we need to work around some Locales because of this bug, then Locale
> comparisons need be based on whatever aspects of the Locale are actually
> problematic
> see for example SOLR-6387 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676=1618675=1618676
> Or SOLR-6991 + TIKA-1526 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708=1653707=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560610#comment-14560610
]
ASF subversion and git services commented on SOLR-7183:
---
Commit 1681928 from [~anshumg] in branch 'dev/branches/lucene_solr_5_2'
[ https://svn.apache.org/r1681928 ]
SOLR-7183: Fix Locale blacklisting for Minikdc based tests.(merge from
branch_5x)
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
Fix For: 5.2
Attachments: SOLR-7183.patch
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560488#comment-14560488
]
ASF subversion and git services commented on SOLR-7183:
---
Commit 1681915 from [~anshumg] in branch 'dev/trunk'
[ https://svn.apache.org/r1681915 ]
SOLR-7183: Fix Locale blacklisting for Minikdc based tests.
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
Attachments: SOLR-7183.patch
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560542#comment-14560542
]
ASF subversion and git services commented on SOLR-7183:
---
Commit 1681919 from [~anshumg] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1681919 ]
SOLR-7183: Fix Locale blacklisting for Minikdc based tests.(merge from trunk)
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
Attachments: SOLR-7183.patch
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560461#comment-14560461
]
Anshum Gupta commented on SOLR-7183:
LGTM. I'll run the tests and commit.
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
Attachments: SOLR-7183.patch
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559980#comment-14559980
]
Anshum Gupta commented on SOLR-7183:
I think it makes sense to just skip kdc dependent tests when we're running with
a blacklisted Locale.
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365468#comment-14365468
]
Shalin Shekhar Mangar commented on SOLR-7183:
-
Also see SOLR-7258 where MessageFormat.format with Number arguments use the
default locale and causes problems.
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7183) SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361411#comment-14361411
]
Gregory Chanan commented on SOLR-7183:
--
DIRAPI-219 may address the underlying issue, I will need to test to verify (and
probably push the dependency upgrade to hadoop as well).
SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
---
Key: SOLR-7183
URL: https://issues.apache.org/jira/browse/SOLR-7183
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Assignee: Gregory Chanan
SaslZkACLProviderTest has this blacklist of locales...
{code}
// These Locales don't generate dates that are compatibile with Hadoop
MiniKdc.
protected final static ListString brokenLocales =
Arrays.asList(
th_TH_TH_#u-nu-thai,
ja_JP_JP_#u-ca-japanese,
hi_IN);
{code}
..but this list is incomplete -- notably because it only focuses on one
specific Thai variant, and then does a string Locale.toString() comparison.
so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
other variants that will fail as well
* if there is a bug in Hadoop MiniKdc then that bug should be filed in
jira, and there should be Solr jira that refers to it -- the Solr jira URL
needs to be included her in the test case so developers in the future can
understand the context and have some idea of if/when the third-party lib bug
is fixed
* if we need to work around some Locales because of this bug, then Locale
comparisons need be based on whatever aspects of the Locale are actually
problematic
see for example SOLR-6387 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676r2=1618675pathrev=1618676
Or SOLR-6991 + TIKA-1526 this commit:
https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708r2=1653707pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
