[jira] [Commented] (SOLR-7278) Make ValueSourceAugmenter easier to extend
[ https://issues.apache.org/jira/browse/SOLR-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372522#comment-14372522 ] ASF subversion and git services commented on SOLR-7278: --- Commit 1668197 from [~ryantxu] in branch 'dev/trunk' [ https://svn.apache.org/r1668197 ] Merged revision(s) 1668195 from lucene/dev/branches/branch_5x: SOLR-7278: oh my... sorry Make ValueSourceAugmenter easier to extend -- Key: SOLR-7278 URL: https://issues.apache.org/jira/browse/SOLR-7278 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assignee: Ryan McKinley Priority: Trivial Fix For: Trunk, 5.1 Attachments: SOLR-7278-ValueSourceAugmenter.patch Right now the ValueSourceAugmenter does some hairy work to get the Value and then applies the change do the SolrDocument inline. Lets move modifying the document to a protected function so subclasses can do something different -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7278) Make ValueSourceAugmenter easier to extend
[ https://issues.apache.org/jira/browse/SOLR-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372521#comment-14372521 ] ASF subversion and git services commented on SOLR-7278: --- Commit 1668195 from [~ryantxu] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1668195 ] SOLR-7278: oh my... sorry Make ValueSourceAugmenter easier to extend -- Key: SOLR-7278 URL: https://issues.apache.org/jira/browse/SOLR-7278 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assignee: Ryan McKinley Priority: Trivial Fix For: Trunk, 5.1 Attachments: SOLR-7278-ValueSourceAugmenter.patch Right now the ValueSourceAugmenter does some hairy work to get the Value and then applies the change do the SolrDocument inline. Lets move modifying the document to a protected function so subclasses can do something different -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7278) Make ValueSourceAugmenter easier to extend
[ https://issues.apache.org/jira/browse/SOLR-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372121#comment-14372121 ] Yonik Seeley commented on SOLR-7278: +1, looks fine. Make ValueSourceAugmenter easier to extend -- Key: SOLR-7278 URL: https://issues.apache.org/jira/browse/SOLR-7278 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assignee: Ryan McKinley Priority: Trivial Fix For: Trunk, 5.1 Attachments: SOLR-7278-ValueSourceAugmenter.patch Right now the ValueSourceAugmenter does some hairy work to get the Value and then applies the change do the SolrDocument inline. Lets move modifying the document to a protected function so subclasses can do something different -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7278) Make ValueSourceAugmenter easier to extend
[ https://issues.apache.org/jira/browse/SOLR-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372128#comment-14372128 ] ASF subversion and git services commented on SOLR-7278: --- Commit 1668149 from [~ryantxu] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1668149 ] SOLR-7278: Make ValueSourceAugmenter easier to extend Make ValueSourceAugmenter easier to extend -- Key: SOLR-7278 URL: https://issues.apache.org/jira/browse/SOLR-7278 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assignee: Ryan McKinley Priority: Trivial Fix For: Trunk, 5.1 Attachments: SOLR-7278-ValueSourceAugmenter.patch Right now the ValueSourceAugmenter does some hairy work to get the Value and then applies the change do the SolrDocument inline. Lets move modifying the document to a protected function so subclasses can do something different -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7278) Make ValueSourceAugmenter easier to extend
[ https://issues.apache.org/jira/browse/SOLR-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372131#comment-14372131 ] ASF subversion and git services commented on SOLR-7278: --- Commit 1668151 from [~ryantxu] in branch 'dev/trunk' [ https://svn.apache.org/r1668151 ] Merged revision(s) 1668149 from lucene/dev/branches/branch_5x: SOLR-7278: Make ValueSourceAugmenter easier to extend Make ValueSourceAugmenter easier to extend -- Key: SOLR-7278 URL: https://issues.apache.org/jira/browse/SOLR-7278 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assignee: Ryan McKinley Priority: Trivial Fix For: Trunk, 5.1 Attachments: SOLR-7278-ValueSourceAugmenter.patch Right now the ValueSourceAugmenter does some hairy work to get the Value and then applies the change do the SolrDocument inline. Lets move modifying the document to a protected function so subclasses can do something different -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
