[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs
[
https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523941#comment-14523941
]
ASF subversion and git services commented on SOLR-7487:
---
Commit 1677232 from [~thelabdude] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1677232 ]
SOLR-7487: update luceneMatchVersion to 5.2.0 so that precommit passes
check-example-lucene-match-version is looking in the wrong place -
luceneMatchVersion incorrect in 5.1 sample configs
-
Key: SOLR-7487
URL: https://issues.apache.org/jira/browse/SOLR-7487
Project: Solr
Issue Type: Bug
Affects Versions: 5.1
Reporter: Hoss Man
Assignee: Timothy Potter
Priority: Blocker
Fix For: 5.2
Attachments: SOLR-7487.patch, SOLR-7487.patch, SOLR-7487.patch,
SOLR-7487.patch
As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the
5.1 sample configs all still lists 5.0.0.
The root cause seems to be because the check-example-lucene-match-version
task in solr/build.xml is looking in the wrong place -- it's still scaning
for instances of luceneMatchVersion in the {{example}} directory instead of
the {{server/solr/configset}}
TODO:
* fix the luceneMatchVersion value in all sample configsets on 5x
* update the check to look in the correct directory
* update the check to fail to be smarter know that we have a more predictable
directory structure
** fail if no subdirs found
** fail if any subdir doesn't contain conf/solrconfig.xml
** fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
** fail if any luceneMatchVersion doesn't have the expected value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs
[
https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523918#comment-14523918
]
ASF subversion and git services commented on SOLR-7487:
---
Commit 1677230 from [~thelabdude] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1677230 ]
SOLR-7487: Fix check-example-lucene-match-version Ant task to check
luceneMatchVersion in solr/server/solr/configsets instead of example and harden
error checking / validation logic.
check-example-lucene-match-version is looking in the wrong place -
luceneMatchVersion incorrect in 5.1 sample configs
-
Key: SOLR-7487
URL: https://issues.apache.org/jira/browse/SOLR-7487
Project: Solr
Issue Type: Bug
Affects Versions: 5.1
Reporter: Hoss Man
Assignee: Timothy Potter
Priority: Blocker
Fix For: 5.2
Attachments: SOLR-7487.patch, SOLR-7487.patch, SOLR-7487.patch,
SOLR-7487.patch
As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the
5.1 sample configs all still lists 5.0.0.
The root cause seems to be because the check-example-lucene-match-version
task in solr/build.xml is looking in the wrong place -- it's still scaning
for instances of luceneMatchVersion in the {{example}} directory instead of
the {{server/solr/configset}}
TODO:
* fix the luceneMatchVersion value in all sample configsets on 5x
* update the check to look in the correct directory
* update the check to fail to be smarter know that we have a more predictable
directory structure
** fail if no subdirs found
** fail if any subdir doesn't contain conf/solrconfig.xml
** fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
** fail if any luceneMatchVersion doesn't have the expected value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs
[
https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523916#comment-14523916
]
ASF subversion and git services commented on SOLR-7487:
---
Commit 1677228 from [~thelabdude] in branch 'dev/trunk'
[ https://svn.apache.org/r1677228 ]
SOLR-7487: Fix check-example-lucene-match-version Ant task to check
luceneMatchVersion in solr/server/solr/configsets instead of example and harden
error checking / validation logic.
check-example-lucene-match-version is looking in the wrong place -
luceneMatchVersion incorrect in 5.1 sample configs
-
Key: SOLR-7487
URL: https://issues.apache.org/jira/browse/SOLR-7487
Project: Solr
Issue Type: Bug
Affects Versions: 5.1
Reporter: Hoss Man
Assignee: Timothy Potter
Priority: Blocker
Fix For: 5.2
Attachments: SOLR-7487.patch, SOLR-7487.patch, SOLR-7487.patch,
SOLR-7487.patch
As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the
5.1 sample configs all still lists 5.0.0.
The root cause seems to be because the check-example-lucene-match-version
task in solr/build.xml is looking in the wrong place -- it's still scaning
for instances of luceneMatchVersion in the {{example}} directory instead of
the {{server/solr/configset}}
TODO:
* fix the luceneMatchVersion value in all sample configsets on 5x
* update the check to look in the correct directory
* update the check to fail to be smarter know that we have a more predictable
directory structure
** fail if no subdirs found
** fail if any subdir doesn't contain conf/solrconfig.xml
** fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
** fail if any luceneMatchVersion doesn't have the expected value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs
[
https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521817#comment-14521817
]
Ryan Ernst commented on SOLR-7487:
--
You probably want to update {{dev-tools/scripts/addVersion.py}} as well so
these get updated when versions are bumped?
check-example-lucene-match-version is looking in the wrong place -
luceneMatchVersion incorrect in 5.1 sample configs
-
Key: SOLR-7487
URL: https://issues.apache.org/jira/browse/SOLR-7487
Project: Solr
Issue Type: Bug
Affects Versions: 5.1
Reporter: Hoss Man
Assignee: Timothy Potter
Priority: Blocker
Fix For: 5.2
Attachments: SOLR-7487.patch
As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the
5.1 sample configs all still lists 5.0.0.
The root cause seems to be because the check-example-lucene-match-version
task in solr/build.xml is looking in the wrong place -- it's still scaning
for instances of luceneMatchVersion in the {{example}} directory instead of
the {{server/solr/configset}}
TODO:
* fix the luceneMatchVersion value in all sample configsets on 5x
* update the check to look in the correct directory
* update the check to fail to be smarter know that we have a more predictable
directory structure
** fail if no subdirs found
** fail if any subdir doesn't contain conf/solrconfig.xml
** fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
** fail if any luceneMatchVersion doesn't have the expected value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs
[
https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521886#comment-14521886
]
Timothy Potter commented on SOLR-7487:
--
Yup, good catch (got hasty), thanks Ryan.
check-example-lucene-match-version is looking in the wrong place -
luceneMatchVersion incorrect in 5.1 sample configs
-
Key: SOLR-7487
URL: https://issues.apache.org/jira/browse/SOLR-7487
Project: Solr
Issue Type: Bug
Affects Versions: 5.1
Reporter: Hoss Man
Assignee: Timothy Potter
Priority: Blocker
Fix For: 5.2
Attachments: SOLR-7487.patch
As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the
5.1 sample configs all still lists 5.0.0.
The root cause seems to be because the check-example-lucene-match-version
task in solr/build.xml is looking in the wrong place -- it's still scaning
for instances of luceneMatchVersion in the {{example}} directory instead of
the {{server/solr/configset}}
TODO:
* fix the luceneMatchVersion value in all sample configsets on 5x
* update the check to look in the correct directory
* update the check to fail to be smarter know that we have a more predictable
directory structure
** fail if no subdirs found
** fail if any subdir doesn't contain conf/solrconfig.xml
** fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
** fail if any luceneMatchVersion doesn't have the expected value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
