[jira] [Commented] (SOLR-7515) Some highlight checkboxes are broken
[ https://issues.apache.org/jira/browse/SOLR-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761814#comment-16761814 ] Matt Pearce commented on SOLR-7515: --- Sorry, I may have simply overlooked the `hl.requireFieldMatch` checkbox. SOLR-13221 is marked as resolved - does that mean the patch is no longer required? Either way, I've updated and created a PR with all the changes in it - I couldn't figure out how to get git or IntelliJ to generate a diff that included both changes, since they were created months apart. > Some highlight checkboxes are broken > > > Key: SOLR-7515 > URL: https://issues.apache.org/jira/browse/SOLR-7515 > Project: Solr > Issue Type: Bug > Components: Admin UI >Reporter: Matt Hilt >Priority: Minor > Attachments: SOLR-7515.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In the query UI, when configuring a highlight enabled search, there are three > checkboxes for additional highlight parameters. When they are checked, they > add the appropriate parameters to the query, e.g. > hl.usePhraseHighligher=true > However, usePhraseHighligher and highlightMultiTerm are true by default > (according to the 5.1 docs). So these checkboxes really don't do anything, > and there is no way to turn off these parameters from the GUI. > The solution is to make the parameters always part of the query (when > highlighting is on), and just toggle the true/false value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7515) Some highlight checkboxes are broken
[ https://issues.apache.org/jira/browse/SOLR-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761230#comment-16761230 ] Erik Hatcher commented on SOLR-7515: The `hl.requireFieldMatch` checkbox must have been added since this issue was created, mentioned in the duplicate SOLR-13221 - noting here as the patch here doesn't include that. > Some highlight checkboxes are broken > > > Key: SOLR-7515 > URL: https://issues.apache.org/jira/browse/SOLR-7515 > Project: Solr > Issue Type: Bug > Components: Admin UI >Reporter: Matt Hilt >Priority: Minor > Attachments: SOLR-7515.patch > > > In the query UI, when configuring a highlight enabled search, there are three > checkboxes for additional highlight parameters. When they are checked, they > add the appropriate parameters to the query, e.g. > hl.usePhraseHighligher=true > However, usePhraseHighligher and highlightMultiTerm are true by default > (according to the 5.1 docs). So these checkboxes really don't do anything, > and there is no way to turn off these parameters from the GUI. > The solution is to make the parameters always part of the query (when > highlighting is on), and just toggle the true/false value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7515) Some highlight checkboxes are broken
[ https://issues.apache.org/jira/browse/SOLR-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391041#comment-16391041 ] Matt Pearce commented on SOLR-7515: --- I've attached a patch which I believe fixes this, working around some Angular quirks by using a string version of "true" rather than the boolean equivalent. > Some highlight checkboxes are broken > > > Key: SOLR-7515 > URL: https://issues.apache.org/jira/browse/SOLR-7515 > Project: Solr > Issue Type: Bug > Components: Admin UI >Reporter: Matt Hilt >Priority: Minor > Attachments: SOLR-7515.patch > > > In the query UI, when configuring a highlight enabled search, there are three > checkboxes for additional highlight parameters. When they are checked, they > add the appropriate parameters to the query, e.g. > hl.usePhraseHighligher=true > However, usePhraseHighligher and highlightMultiTerm are true by default > (according to the 5.1 docs). So these checkboxes really don't do anything, > and there is no way to turn off these parameters from the GUI. > The solution is to make the parameters always part of the query (when > highlighting is on), and just toggle the true/false value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
