[jira] [Commented] (SOLR-7781) FieldFaceting BytesRef reuse bug

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624052#comment-14624052
 ] 

ASF subversion and git services commented on SOLR-7781:
---

Commit 1690542 from [~yo...@apache.org] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1690542 ]

SOLR-7781: change FacetField BytesRef shallow clone to deep clone

 FieldFaceting BytesRef reuse bug
 

 Key: SOLR-7781
 URL: https://issues.apache.org/jira/browse/SOLR-7781
 Project: Solr
  Issue Type: Bug
  Components: Facet Module
Affects Versions: 5.1
Reporter: Yonik Seeley
Assignee: Yonik Seeley
 Fix For: 5.3

 Attachments: SOLR-7781.patch


 FieldFaceting on a string field has
 {code}
 new TermQuery( new Term(field, bytesRef.clone() ) )
 {code}
 The bytesRef needs to be deep copied (and clone() only implements a shallow 
 copy).
 This causes to the query inserted into the filter cache to be changed after 
 the fact, and causes both cache misses and even cache growth way past 
 configured limits due to failures to remove old cache items (SOLR-).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-7781) FieldFaceting BytesRef reuse bug

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624050#comment-14624050
 ] 

ASF subversion and git services commented on SOLR-7781:
---

Commit 1690541 from [~yo...@apache.org] in branch 'dev/trunk'
[ https://svn.apache.org/r1690541 ]

SOLR-7781: change FacetField BytesRef shallow clone to deep clone

 FieldFaceting BytesRef reuse bug
 

 Key: SOLR-7781
 URL: https://issues.apache.org/jira/browse/SOLR-7781
 Project: Solr
  Issue Type: Bug
  Components: Facet Module
Affects Versions: 5.1
Reporter: Yonik Seeley
Assignee: Yonik Seeley
 Fix For: 5.3

 Attachments: SOLR-7781.patch


 FieldFaceting on a string field has
 {code}
 new TermQuery( new Term(field, bytesRef.clone() ) )
 {code}
 The bytesRef needs to be deep copied (and clone() only implements a shallow 
 copy).
 This causes to the query inserted into the filter cache to be changed after 
 the fact, and causes both cache misses and even cache growth way past 
 configured limits due to failures to remove old cache items (SOLR-).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org