[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660274#comment-14660274 ] Tomás Fernández Löbbe commented on SOLR-7875: - If we leave the unset value as null (instead of nanoTime() + nanoTime() + Long.MAX_VALUE) and we do a null check in the shouldExit() method there is already a big improvement. Still not as good as without the ExitableDirectoryReader wrapper: || ||Solr-5_3_0-Not-Exitable-1 || Solr-5_3_0-Not-Exitable-2 || Solr-5_3_0-Exitable-1 ||Solr-5_3_0-Exitable-2 || Solr-5_3_0-branch5-1 || Solr-5_3_0-branch5-2 || | Average | 395 | 393 | 442 | 440 | 2603 | 2595 | p10 | 95 | 90 | 105 | 103 | 558 | 551 | p50 | 380 | 378 | 426 | 423 | 2520 | 2507 | p75 | 581 | 579| 646 | 645 | 3839 | 3839 | p90 | 707 | 706| 789 | 788 | 4710 | 4698 | p95 | 782 | 778| 870 | 870 | 5234 | 5232 | p99| 989 | 984| 1104 | 1105 | 6671 | 6700 This is with a test that runs 3k boolean queries with filters on double fields (more details in the email thread linked in the description of the ticket). * Solr-5_3_0-Not-Exitable-# is a snapshot of 5x branch that completely skips the ExitableDirectoryReader wrapping * Solr-5_3_0-Exitable-# is the same snapshot but with the patch that does the null checks. * Solr-5_3_0-branch5-# is the same snapshot but without any changes. Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660828#comment-14660828 ] ASF subversion and git services commented on SOLR-7875: --- Commit 1694574 from [~tomasflobbe] in branch 'dev/trunk' [ https://svn.apache.org/r1694574 ] SOLR-7875: Speedup SolrQueryTimeoutImpl Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Assignee: Tomás Fernández Löbbe Fix For: 5.3 Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660834#comment-14660834 ] ASF subversion and git services commented on SOLR-7875: --- Commit 1694576 from [~tomasflobbe] in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1694576 ] SOLR-7875: Speedup SolrQueryTimeoutImpl Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Assignee: Tomás Fernández Löbbe Fix For: 5.3 Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660833#comment-14660833 ] ASF subversion and git services commented on SOLR-7875: --- Commit 1694575 from [~tomasflobbe] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694575 ] SOLR-7875: Speedup SolrQueryTimeoutImpl Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Assignee: Tomás Fernández Löbbe Fix For: 5.3 Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660328#comment-14660328 ] Tomás Fernández Löbbe commented on SOLR-7875: - thanks for the review. I'll commit this and merge to the 5.3 branch. bq. Also, the only way to work without the wrapping would involve maintaining 2 readers in SolrIndexSearcher. Let's discuss that in SOLR-7876 Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660406#comment-14660406 ] Steve Rowe commented on SOLR-7875: -- +1, LGTM, thanks Tomás. Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Assignee: Tomás Fernández Löbbe Fix For: 5.3 Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
[ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660318#comment-14660318 ] Anshum Gupta commented on SOLR-7875: LGTM. This is a low hanging change that gets us a good improvement. I think it makes sense for this to go into 5.3. P.S.: Also, the only way to work without the wrapping would involve maintaining 2 readers in SolrIndexSearcher. Speedup SolrQueryTimeoutImpl Key: SOLR-7875 URL: https://issues.apache.org/jira/browse/SOLR-7875 Project: Solr Issue Type: Improvement Affects Versions: 5.0, 5.1, 5.2, 5.2.1 Reporter: Tomás Fernández Löbbe Attachments: SOLR-7875.patch SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many terms, where shouldExit() is called many times. See http://search-lucene.com/m/l6pAi1HLrodLhNUd -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
