[jira] [Commented] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646715#comment-16646715 ] Isabelle Giguere commented on SOLR-7913: Solr 7.5.0: Since Solr 7.1, requestParsers param enableStreamBody allows control over stream.body support, but stream.body still cannot be used with the MLT Qparser. Current behavior insists on looking for a doc id. SOLR-7913_tag_7.5.0.patch : Clean patch to allow stream.body im MLT QParser (no trace of SOLR-8604 as previously) Patch based on revision 61870, tag 7.5.0, latest release Notes: New class org.apache.solr.client.solrj.request.ContentStreamQueryRequest should override SolrRequest.getContentWriter(String) instead of SolrRequest.getContentStreams() Changes in org.apache.solr.request.json.RequestUtil allow stream.body on an MLT Qparser request, but test TestRemoteStreaming.testNoUrlAccess fails (meaning the test query doesn't fail), so is ignored for now. There should be a better fix, that would consider MLT QParser, Json requests, and still pass test TestRemoteStreaming.testNoUrlAccess - Set a contentType on MLT QParser requests with stream.body, and check for that contentType along with "/json" in RequestUtil ? - Require param 'json' on all Json requests ? Meaning the query at line 178 in TestJsonRequest.doJsonRequest(Client, boolean) would not be allowed There could be a more streamlined solution, closer to how requestParsers param enableStreamBody is supported elsewhere in the code. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Priority: Major > Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch, > SOLR-7913_fixTests.patch, SOLR-7913_tag_7.5.0.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095452#comment-16095452 ] Isabelle Giguere commented on SOLR-7913: One more note about the patch for Solr 6.6.0, that I just attached: CloudMLTQParser contains the changes done in the patch for SOLR-8604. If, for some strange reason, you don't want support for the "collection" parameter in MLT queries, just ignore in patch SOLR-7913 the changes to method CloudMLTQParser.getDocument(String,String), so that you keep the previous version, with just one parameter. If you do want support for the "collection" parameter in MLT queries, then you need to apply SOLR-8604 too. It's easier to weed out SOLR-8604 from SOLR-7913 than the reverse ! [~upayavira] : this patch is not as messy as the previous, I did not incorporate the useless layout changes. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178757#comment-15178757 ] Upayavira commented on SOLR-7913: - [~smolloy] Looking at this patch, there's quite a lot of reformatting in it, which makes it hard to distinguish between substantive changes and layout changes. Could you provide a patch that is purely substantive changes? Whilst I won't (yet) promise to commit it, I'd certainly like to see if we can get it to that point. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913.patch, SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
