[jira] [Commented] (SOLR-7984) totally bogus and missleading "no default request handler is registered" logged by RequestHandlers

2016-02-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153433#comment-15153433
 ] 

ASF subversion and git services commented on SOLR-7984:
---

Commit 2977efa922b92500cef424139306fc04e08b65a7 in lucene-solr's branch 
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2977efa ]

updatd the test in according with SOLR-7984


> totally bogus and missleading "no default request handler is registered" 
> logged by RequestHandlers 
> ---
>
> Key: SOLR-7984
> URL: https://issues.apache.org/jira/browse/SOLR-7984
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.1
>Reporter: Hoss Man
>Assignee: Noble Paul
> Fix For: 5.4, master
>
> Attachments: SOLR-7988.patch
>
>
> As noted on the user list by Scott Hollenbeck the following warning can be 
> logged by solr...
> bq. no default request handler is registered (either '/select' or 'standard')
> ...even if there is both a handler named "standard" and a handler (in his 
> case named "pinkPony") defined as default="true".
> The code in question appears to be total nonsense...
> {code}
> if(!handlers.alias( "/select","")){
>   if(!handlers.alias( "standard","")){
> log.warn("no default request handler is registered (either '/select' 
> or 'standard')");
>   }
> }
> {code}
> * PluginBag.alias is not documented, but appears to be a mutating operation 
> that _adds_ an alias if and only if the first arg is aname of something that 
> exists, and the second arg is a name that does not already exist -- returning 
> true if the alias is added
> * if an alias already exists with the (default) name "" (which 
> initHandlersFromConfig takes care of registring before this code) then 
> neither of these can be made the new default.
> * just because neither of these aren't made the default here, doesn't mean 
> there isn't already a default handler -- it actually means the exact oposite
> * if the goal was to log an error when there is no default, then that should 
> have just been checked directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-7984) totally bogus and missleading "no default request handler is registered" logged by RequestHandlers

2015-09-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727482#comment-14727482
 ] 

ASF subversion and git services commented on SOLR-7984:
---

Commit 1700841 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1700841 ]

SOLR-7984: wrong and misleading error message 'no default request handler is 
registered'

> totally bogus and missleading "no default request handler is registered" 
> logged by RequestHandlers 
> ---
>
> Key: SOLR-7984
> URL: https://issues.apache.org/jira/browse/SOLR-7984
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.1
>Reporter: Hoss Man
>Assignee: Noble Paul
> Fix For: Trunk, 5.4
>
> Attachments: SOLR-7988.patch
>
>
> As noted on the user list by Scott Hollenbeck the following warning can be 
> logged by solr...
> bq. no default request handler is registered (either '/select' or 'standard')
> ...even if there is both a handler named "standard" and a handler (in his 
> case named "pinkPony") defined as default="true".
> The code in question appears to be total nonsense...
> {code}
> if(!handlers.alias( "/select","")){
>   if(!handlers.alias( "standard","")){
> log.warn("no default request handler is registered (either '/select' 
> or 'standard')");
>   }
> }
> {code}
> * PluginBag.alias is not documented, but appears to be a mutating operation 
> that _adds_ an alias if and only if the first arg is aname of something that 
> exists, and the second arg is a name that does not already exist -- returning 
> true if the alias is added
> * if an alias already exists with the (default) name "" (which 
> initHandlersFromConfig takes care of registring before this code) then 
> neither of these can be made the new default.
> * just because neither of these aren't made the default here, doesn't mean 
> there isn't already a default handler -- it actually means the exact oposite
> * if the goal was to log an error when there is no default, then that should 
> have just been checked directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-7984) totally bogus and missleading "no default request handler is registered" logged by RequestHandlers

2015-09-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727480#comment-14727480
 ] 

ASF subversion and git services commented on SOLR-7984:
---

Commit 1700840 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1700840 ]

SOLR-7984: wrong and misleading error message 'no default request handler is 
registered'

> totally bogus and missleading "no default request handler is registered" 
> logged by RequestHandlers 
> ---
>
> Key: SOLR-7984
> URL: https://issues.apache.org/jira/browse/SOLR-7984
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.1
>Reporter: Hoss Man
>Assignee: Noble Paul
> Attachments: SOLR-7988.patch
>
>
> As noted on the user list by Scott Hollenbeck the following warning can be 
> logged by solr...
> bq. no default request handler is registered (either '/select' or 'standard')
> ...even if there is both a handler named "standard" and a handler (in his 
> case named "pinkPony") defined as default="true".
> The code in question appears to be total nonsense...
> {code}
> if(!handlers.alias( "/select","")){
>   if(!handlers.alias( "standard","")){
> log.warn("no default request handler is registered (either '/select' 
> or 'standard')");
>   }
> }
> {code}
> * PluginBag.alias is not documented, but appears to be a mutating operation 
> that _adds_ an alias if and only if the first arg is aname of something that 
> exists, and the second arg is a name that does not already exist -- returning 
> true if the alias is added
> * if an alias already exists with the (default) name "" (which 
> initHandlersFromConfig takes care of registring before this code) then 
> neither of these can be made the new default.
> * just because neither of these aren't made the default here, doesn't mean 
> there isn't already a default handler -- it actually means the exact oposite
> * if the goal was to log an error when there is no default, then that should 
> have just been checked directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-7984) totally bogus and missleading "no default request handler is registered" logged by RequestHandlers

2015-08-31 Thread Noble Paul (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723552#comment-14723552
 ] 

Noble Paul commented on SOLR-7984:
--

The objective was to have the exact same behavior. But turns out that it doesn't

> totally bogus and missleading "no default request handler is registered" 
> logged by RequestHandlers 
> ---
>
> Key: SOLR-7984
> URL: https://issues.apache.org/jira/browse/SOLR-7984
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.1
>Reporter: Hoss Man
>Assignee: Noble Paul
>
> As noted on the user list by Scott Hollenbeck the following warning can be 
> logged by solr...
> bq. no default request handler is registered (either '/select' or 'standard')
> ...even if there is both a handler named "standard" and a handler (in his 
> case named "pinkPony") defined as default="true".
> The code in question appears to be total nonsense...
> {code}
> if(!handlers.alias( "/select","")){
>   if(!handlers.alias( "standard","")){
> log.warn("no default request handler is registered (either '/select' 
> or 'standard')");
>   }
> }
> {code}
> * PluginBag.alias is not documented, but appears to be a mutating operation 
> that _adds_ an alias if and only if the first arg is aname of something that 
> exists, and the second arg is a name that does not already exist -- returning 
> true if the alias is added
> * if an alias already exists with the (default) name "" (which 
> initHandlersFromConfig takes care of registring before this code) then 
> neither of these can be made the new default.
> * just because neither of these aren't made the default here, doesn't mean 
> there isn't already a default handler -- it actually means the exact oposite
> * if the goal was to log an error when there is no default, then that should 
> have just been checked directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org