RE: [jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2016-04-11 Thread Edwards, Joshua 
Hey, guys -

I re-based this pull request and integrated the changes that I saw since last 
time I submitted it.  It should be a pretty straight-forward piece of 
functionality to add, so if a committer could check it out and add it (or give 
me feedback on why it can't be added), I'd greatly appreciate it, so that I 
don't have to support the functionality locally.

Thanks,
Josh

-Original Message-
From: ASF GitHub Bot (JIRA) [mailto:j...@apache.org] 
Sent: Monday, April 11, 2016 12:24 PM
To: dev@lucene.apache.org
Subject: [jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to 
break when one word matches


[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235406#comment-15235406
 ] 

ASF GitHub Bot commented on SOLR-8010:
--

GitHub user Admje14 opened a pull request:

https://github.com/apache/lucene-solr/pull/28

SOLR-8010 Adding the ability to optionally enable breaking words wher…

…e one side is a word but the other is not.  Integrated with re-based trunk 
to re-submit the pull request.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Admje14/lucene-solr-1 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/28.patch

To close this pull request, make a commit to your master/trunk branch with (at 
least) the following in the commit message:

This closes #28


commit 292a1ba07a4c42893acedc85c0755fe0e3167a76
Author: Josh Edwards <joshua.edwa...@capitalone.com>
Date:   2016-04-11T16:19:28Z

SOLR-8010 Adding the ability to optionally enable breaking words where one 
side is a word but the other is not.  Integrated with re-based trunk to 
re-submit the pull request.




> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides-trunk.patch, 
> WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional 
commands, e-mail: dev-h...@lucene.apache.org




The information contained in this e-mail is confidential and/or proprietary to 
Capital One and/or its affiliates and may only be used solely in performance of 
work or services for Capital One. The information transmitted herewith is 
intended only for use by the individual or entity to which it is addressed. If 
the reader of this message is not the intended recipient, you are hereby 
notified that any review, retransmission, dissemination, distribution, copying 
or other use of, or taking of any action in reliance upon this information is 
strictly prohibited. If you have received this communication in error, please 
contact the sender and delete the material from your computer.

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2016-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235406#comment-15235406
 ] 

ASF GitHub Bot commented on SOLR-8010:
--

GitHub user Admje14 opened a pull request:

https://github.com/apache/lucene-solr/pull/28

SOLR-8010 Adding the ability to optionally enable breaking words wher…

…e one side is a word but the other is not.  Integrated with re-based trunk 
to re-submit the pull request.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Admje14/lucene-solr-1 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #28


commit 292a1ba07a4c42893acedc85c0755fe0e3167a76
Author: Josh Edwards 
Date:   2016-04-11T16:19:28Z

SOLR-8010 Adding the ability to optionally enable breaking words where one 
side is a word but the other is not.  Integrated with re-based trunk to 
re-submit the pull request.




> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides-trunk.patch, 
> WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2015-10-14 Thread Joshua Edwards (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957716#comment-14957716
 ] 

Joshua Edwards commented on SOLR-8010:
--

Ishan -

Thanks for the advice.  I've updated the JIRA with a patch for trunk, as well 
as creating a Pull Request for trunk so that anyone looking to integrate the 
changes can do so in whichever way they find easier.

> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides-trunk.patch, 
> WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2015-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957708#comment-14957708
 ] 

ASF GitHub Bot commented on SOLR-8010:
--

GitHub user Admje14 opened a pull request:

https://github.com/apache/lucene-solr/pull/205

JIRA: SOLR-8010 Ability to breaking words when one side matches

JIRA: SOLR-8010 Adding the ability to optionally enable breaking words 
where one side is a word but the other is not.  This allows a suggestion of a 
word that may not yet be in the dictionary, but would resolve to a word through 
various filters (specifically synonym lists).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Admje14/lucene-solr trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #205


commit 3951332ef23439b6e832cb045be05f82dfdab44d
Author: Josh Edwards 
Date:   2015-10-01T14:48:24Z

JIRA: SOLR-8010 Adding the ability to optionally enable breaking words 
where one side is a word but the other is not (this time in trunk).




> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2015-09-29 Thread Ishan Chattopadhyaya (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935867#comment-14935867
 ] 

Ishan Chattopadhyaya commented on SOLR-8010:


Joshua, can you please update the patch to trunk? All development usually 
happens using trunk, and I'm sure doing it will make work easy for whoever can 
review and commit this. Thanks.

> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2015-09-04 Thread Joshua Edwards (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730942#comment-14730942
 ] 

Joshua Edwards commented on SOLR-8010:
--

Attached a patch file, as well as creating a pull request to the lucene_4_10 
branch.  The changes should be able to be easily integrated into trunk as well 
(though I have not done that since we are currently using 4_10_X).

> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8010) Allow WordBreakSolrSpellChecker to break when one word matches

2015-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730940#comment-14730940
 ] 

ASF GitHub Bot commented on SOLR-8010:
--

GitHub user Admje14 opened a pull request:

https://github.com/apache/lucene-solr/pull/200

JIRA: SOLR-8010 - Adding the ability to configure an option to break …

…words when the right or left side of a break is a word, but not both.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Admje14/lucene-solr lucene_solr_4_10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #200


commit 26aacab65676d7d301527d70426f982cc376a2c4
Author: Josh Edwards 
Date:   2015-09-04T15:15:51Z

JIRA: SOLR-8010 - Adding the ability to configure an option to break words 
when the right or left side of a break is a word, but not both.




> Allow WordBreakSolrSpellChecker to break when one word matches
> --
>
> Key: SOLR-8010
> URL: https://issues.apache.org/jira/browse/SOLR-8010
> Project: Solr
>  Issue Type: Improvement
>  Components: spellchecker
>Affects Versions: 4.10.4, 5.3
>Reporter: Joshua Edwards
> Attachments: WordBreakDontRequireWordOnBothSides.patch
>
>
> The WordBreakSolrSpellChecker only works if both words that are being broken 
> are in the dictionary.  This prevents the spell checker from breaking in 
> other valid use cases - such as when one of the words has a synonym that is 
> in the dictionary, or when one of the words is misspelled.  I would like to 
> enable (via configuration) the option to break when one of the two words is 
> in the dictionary, but the other is not.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org