[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253082#comment-15253082
]
Anshum Gupta commented on SOLR-8145:
branch_5x:
{code}
commit 9b6773120cee43e762e254216ca03eafa75e
Author: thelabdude
Date: Wed Mar 2 11:22:27 2016 -0700
SOLR-8145: Fix position of OOM killer script when starting Solr in the
background
{code}
branch_5_5
{code}
commit 851a6029e889860951fdb480bf2d658c89639862
Author: thelabdude
Date: Wed Mar 2 11:22:27 2016 -0700
SOLR-8145: Fix position of OOM killer script when starting Solr in the
background
{code}
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0, 5.5.1
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210400#comment-15210400
]
Nim Lhûg commented on SOLR-8145:
Any chance this can be fixed in 5.5.1?
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208792#comment-15208792
]
Shawn Heisey commented on SOLR-8145:
There's a bonus to this bugfix. It also removes the following warning logged
by Jetty when Solr starts:
{noformat}
WARNING: System properties and/or JVM args set. Consider using --dry-run or
--exec
{noformat}
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187188#comment-15187188
]
Timothy Potter commented on SOLR-8145:
--
btw - I was concerned I introduced this bug originally so wanted to track down
the change that introduced this, looks like here ->
https://github.com/apache/lucene-solr/commit/83969f44a0e9d4f282fa96f94870a039f9307287#diff-eb1341c1a8dc785e1d27d5a9d2c7a2e4
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177941#comment-15177941
]
ASF subversion and git services commented on SOLR-8145:
---
Commit cc8af0d3e8e9bbd933947dae7307d0b09eb146da in lucene-solr's branch
refs/heads/branch_6_0 from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc8af0d ]
SOLR-8145: Fix position of OOM killer script when starting Solr in the
background
(cherry picked from commit e1033d9)
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177942#comment-15177942
]
ASF subversion and git services commented on SOLR-8145:
---
Commit b21927818c30ea2d3defab3d94c19225dc2452c8 in lucene-solr's branch
refs/heads/branch_6_0 from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b219278 ]
SOLR-8145: mention fix in solr/CHANGES.txt
(cherry picked from commit ddd019f)
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176823#comment-15176823
]
Scott Blum commented on SOLR-8145:
--
We always run solr in foreground, because we handle app process management at a
higher level. When we call bin/solr we already have a pidfile setup, stderr
and stdout piped, etc-- so it's vital we run it in foreground to get the `exec`
and maintain process identity. But we still need oom killer, so that it will
die fast and our process watcher will restart it.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176812#comment-15176812
]
Shawn Heisey commented on SOLR-8145:
bq. Are people running SolrCloud in production in foreground mode?
I think this is commonly used when users create a service for Windows, but
there isn't an OOM killer script for Windows.
I think that the only time somebody would run in foreground mode on *NIX is
when they are troubleshooting, mostly to see the console logging. I think that
running the OOM killer even in foreground mode makes sense.
A separate question (probably requiring a new issue): Regardless of
foreground/background, should there be an environment variable that can be set
to disable the OOM killer? Like foreground mode, this would be for
troubleshooting.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176719#comment-15176719
]
Timothy Potter commented on SOLR-8145:
--
bq. BTW: why is there no oomkiller when run in foreground?
I don't even think we should support a foreground mode as it doesn't seem to
add any value to me and you have to pass a special flag to activate it. Are
people running SolrCloud in production in foreground mode? The OOM killer is
really so that you don't have a zombie node that OOM'd in your cluster. That
said, if you think the OOM killer is needed in fg mode for some reason, then
open a new JIRA (this one is done) and post a patch please.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176680#comment-15176680
]
Scott Blum commented on SOLR-8145:
--
BTW: why is there no oomkiller when run in foreground?
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Fix For: 6.0
>
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176212#comment-15176212
]
ASF subversion and git services commented on SOLR-8145:
---
Commit ddd019fac0d9eff352a4a17a62d9a9654f7bdc86 in lucene-solr's branch
refs/heads/branch_6x from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ddd019f ]
SOLR-8145: mention fix in solr/CHANGES.txt
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176206#comment-15176206
]
ASF subversion and git services commented on SOLR-8145:
---
Commit b17c57f072b65106f2689d2f9ea6a5ca14e492e0 in lucene-solr's branch
refs/heads/master from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b17c57f ]
SOLR-8145: mention fix in solr/CHANGES.txt
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176191#comment-15176191
]
ASF subversion and git services commented on SOLR-8145:
---
Commit e1033d965414b34b990070bb87c509364a7f4194 in lucene-solr's branch
refs/heads/branch_6x from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e1033d9 ]
SOLR-8145: Fix position of OOM killer script when starting Solr in the
background
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176157#comment-15176157
]
ASF subversion and git services commented on SOLR-8145:
---
Commit 80801a2738c10ace30eca549fe5daadb88989c32 in lucene-solr's branch
refs/heads/master from [~thelabdude]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=80801a2 ]
SOLR-8145: Fix position of OOM killer script when starting Solr in the
background
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172602#comment-15172602
]
Timothy Potter commented on SOLR-8145:
--
thanks for the patch, I'll get this committed soon
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Assignee: Timothy Potter
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169579#comment-15169579
]
Scott Blum commented on SOLR-8145:
--
I've always just given this special handling in my own installation. My
bin/solr script is edited to use a specific env var:
{code}
diff --git a/solr/bin/solr b/solr/bin/solr
index 85cd550..0e383b5 100755
--- a/solr/bin/solr
+++ b/solr/bin/solr
@@ -1315,7 +1315,8 @@ function launch_solr() {
if [ "$run_in_foreground" == "true" ]; then
echo -e "\nStarting Solr$IN_CLOUD_MODE on port $SOLR_PORT from
$SOLR_SERVER_DIR\n"
-exec "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar
"${SOLR_JETTY_CONFIG[@]}"
+# scottb: OOMKILLER needs super special handling
+exec "$JAVA" "${SOLR_START_OPTS[@]}" "${OOMKILLER:=-Dno.oom.killer}"
$SOLR_ADDL_ARGS -jar start.jar "${SOLR_JETTY_CONFIG[@]}"
else
# run Solr in the background
nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
{code}
Then I just setup OOMKILLER in the calling script to be something like
{code}
'-XX:OnOutOfMemoryError=exec ' + os.path.abspath('killjava.sh')
{code}
At that point, you can get by with a super simple killjava.sh:
{code}
#!/bin/bash
kill -9 $PPID
{code}
The current scheme seems super complicated.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169372#comment-15169372
]
Shawn Heisey commented on SOLR-8145:
Just noticed this because of the comment today. Don't know how I missed it
before.
This could explain SOLR-8539 and other similar problems.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8145) bin/solr script oom_killer arg incorrect
[
https://issues.apache.org/jira/browse/SOLR-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169299#comment-15169299
]
jmlucjav commented on SOLR-8145:
I was going to submit a PR when I found this.
Something like this, so trivial and so important for a robust production system
should have been merged already, please make it into 6.0 at least.
I verified it works on Linux/Windows with jdk8.
> bin/solr script oom_killer arg incorrect
>
>
> Key: SOLR-8145
> URL: https://issues.apache.org/jira/browse/SOLR-8145
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Nate Dire
>Priority: Minor
> Attachments: SOLR-8145.patch, SOLR-8145.patch, SOLR-8145.patch
>
>
> I noticed the oom_killer script wasn't working in our 5.2 deployment.
> In the {{bin/solr}} script, the {{OnOutOfMemoryError}} option is being passed
> as an arg to the jar rather than to the JVM. I moved it ahead of {{-jar}}
> and verified it shows up in the JVM args in the UI.
> {noformat}
># run Solr in the background
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
> "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
> $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
> {noformat}
> Also, I'm not sure what the {{SOLR_PORT}} and {{SOLR_LOGS_DIR}} args are
> doing--they don't appear to be positional arguments to the jar.
> Attaching a patch against 5.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
