[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042651#comment-15042651 ] David Smiley commented on SOLR-8260: bq. will update. Looking forward to that still ;-) > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010636#comment-15010636 ] Alan Woodward commented on SOLR-8260: - Passing the exception itself to the logger generally ends up with a stacktrace being written out, which I don't think would be particularly useful here. But I like the idea of replacing e.getMessage() with e.toString(), will update. Thanks! > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[
https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009440#comment-15009440
]
David Smiley commented on SOLR-8260:
I just reviewed this patch. One thing I'm seeing here that I _usually_
consider to be a (minor) error is this pattern:
{code:java}
catch (IOException e) {
logger.error("Couldn't persist core properties to {}: {}", propfile,
e.getMessage());
}
{code}
Two things:
* I almost always pass the exception (variable {{e}} here) to the logger. Or
in other cases involving throwing different exceptions, the parallel is
forgetting to pass the exception as the cause. Was not doing this intentional?
* To put the details of the exception in the logged string, I suggest
e.toString() as it includes the class as well as the message. Forgetting to do
this can be confusing, like for example if you get a FileNotFoundException
where the class name itself is key to understanding what the problem is, just
as much as the file name (in the message) is.
> Use NIO2 APIs in core discovery
> ---
>
> Key: SOLR-8260
> URL: https://issues.apache.org/jira/browse/SOLR-8260
> Project: Solr
> Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Fix For: 5.4
>
> Attachments: SOLR-8260.patch
>
>
> CorePropertiesLocator currently does all its file system interaction using
> java.io.File and friends, which have all sorts of drawbacks with regard to
> error handling and reporting. We've been on java 7 for a while now, so we
> should use the nio2 Path APIs instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002074#comment-15002074 ] Kevin Risden commented on SOLR-8260: [~romseygeek] I see that you are going through and fixing a bunch to nio from java.io. Is there a JIRA outlining what still needs to be done? > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002079#comment-15002079 ] Alan Woodward commented on SOLR-8260: - There isn't, but an overarching JIRA ticket isn't a bad idea. Will open one up! > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002454#comment-15002454 ] Shawn Heisey commented on SOLR-8260: I added the same exclusions found in the forbiddenapi config for Lucene to Solr, and started going through the tagged classes in trunk to change to NIO2. I don't think I've touched anything for core discovery yet, so I'm hoping the commits here won't overlap. > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002477#comment-15002477 ] Kevin Risden commented on SOLR-8260: Probably makes sense to look over at SOLR-8282 that [~romseygeek] created. > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997021#comment-14997021 ] ASF subversion and git services commented on SOLR-8260: --- Commit 1713498 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1713498 ] SOLR-8260: Use nio2 API in core discovery > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996994#comment-14996994 ] ASF subversion and git services commented on SOLR-8260: --- Commit 1713490 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1713490 ] SOLR-8260: Use nio2 API in core discovery > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997043#comment-14997043 ] Uwe Schindler commented on SOLR-8260: - Thanks Alan! I like this very much. We should on working to disallow java.io.File throughout Solr! :-) > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997049#comment-14997049 ] Alan Woodward commented on SOLR-8260: - bq. We should on working to disallow java.io.File throughout Solr! That would be great, but I think it might take a while! > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997303#comment-14997303 ] Shawn Heisey commented on SOLR-8260: bq. We should on working to disallow java.io.File throughout Solr! I thought this had already been added to the forbidden apis config in the build system, but it seems that was only for Lucene. I'm guessing that if we move it from the lucene config to the base config, Solr will pick it up as well. > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997538#comment-14997538 ] ASF subversion and git services commented on SOLR-8260: --- Commit 1713564 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1713564 ] SOLR-8260: Remove morphlines test setup with wrongly configured core discovery roots > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997535#comment-14997535 ] ASF subversion and git services commented on SOLR-8260: --- Commit 1713563 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1713563 ] SOLR-8260: Remove morphlines test setup with wrongly configured core discovery roots > Use NIO2 APIs in core discovery > --- > > Key: SOLR-8260 > URL: https://issues.apache.org/jira/browse/SOLR-8260 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 5.4 > > Attachments: SOLR-8260.patch > > > CorePropertiesLocator currently does all its file system interaction using > java.io.File and friends, which have all sorts of drawbacks with regard to > error handling and reporting. We've been on java 7 for a while now, so we > should use the nio2 Path APIs instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
