[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147490#comment-15147490 ] Cassandra Targett commented on SOLR-8318: - Just FYI, the CHANGES.txt entry for this patch incorrectly references SOLR-8313 instead of SOLR-8318. The commit had the issue right, but CHANGES.txt does not. > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Fix For: 5.5, master > > Attachments: SOLR-8318.patch, sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044240#comment-15044240 ] ASF subversion and git services commented on SOLR-8318: --- Commit 1718236 from [~erickoerickson] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718236 ] SOLR-8318: SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries. Thanks Tom > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: SOLR-8318.patch, sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044184#comment-15044184 ] ASF subversion and git services commented on SOLR-8318: --- Commit 1718233 from [~erickoerickson] in branch 'dev/trunk' [ https://svn.apache.org/r1718233 ] SOLR-8318: SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries. Thanks Tom > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: SOLR-8318.patch, sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037191#comment-15037191 ] Erick Erickson commented on SOLR-8318: -- OK. LGTM then. I'll check this in in a day or so unless someone objects. > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034166#comment-15034166 ] Tom Hill commented on SOLR-8318: To answer my Nov 19th comment: I don't think I need to do anything with setRewriteMethod for fuzzy queries. QueryParserBase has a newPrefixQuery() and a newFuzzyQuery(), and it does call setRewriteMethod in newPrefixQuery, but not in newFuzzyQuery. > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034150#comment-15034150 ] Tom Hill commented on SOLR-8318: Right. The SimpleQueryParser has implementations of newFuzzyQuery and newPrefixQuery that just loop through the weights, and build a Boolean query. The existing implementation for SimpleQParser in SimpleQParserPlugin does override newPrefixQuery to use the multi-term analysis chain. It does not call the base class implementation. (the base class is basically a loop and a new. I looked at using a lambda to share a bit more code, but I found that more confusing). The problem I was trying to fix is that the existing implementation does not override newFuzzyQuery to use the muti-term analysis chain for fuzzy queries. So I basically duplicated what had been done for newPrefixQuery in SimpleQParser. > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033939#comment-15033939 ] Erick Erickson commented on SOLR-8318: -- Hmmm, I'm a bit puzzled here. The base class SimpleQueryParser already _has_ a newFuzzyQuery method that this patch overrides. I'm out of my familiarity with the code, so my question is whether we should override this method in the plugin or is the real problem in the base class' implementation of newFuzzyQuery? The tests in this patch certainly fail with the new overridden method commented out though I put some debugging in and the superclass' method is never called in our regular tests so maybe this is really straight bug with SimpleQueryParser? > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Assignee: Erick Erickson >Priority: Trivial > Attachments: sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8318) SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries
[ https://issues.apache.org/jira/browse/SOLR-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014551#comment-15014551 ] Tom Hill commented on SOLR-8318: In newPrefixQuery() in SimpleQParserPlugin, new queries are created like this prefix = sf.getType().getPrefixQuery(qParser, sf, term); Which adds a rewrite method: query.setRewriteMethod(sf.getType().getRewriteMethod(parser, sf)); Is that relevant for fuzzy queries? Or can I just do: fuzzy = new FuzzyQuery(new Term(entry.getKey(), text), fuzziness); > SimpleQueryParser doesn't use MultiTermAnalysis for Fuzzy Queries > - > > Key: SOLR-8318 > URL: https://issues.apache.org/jira/browse/SOLR-8318 > Project: Solr > Issue Type: Bug > Components: query parsers >Affects Versions: 5.3 >Reporter: Tom Hill >Priority: Trivial > Attachments: sqp_fuzzy_multiterm.patch > > > Fuzzy queries in SimpleQParserPlugin don't seem to use the multi-term > analysis chain. Prefix queries do, and SolrQueryParser does use multi-term > analysis for fuzzy queries, so it seems like SimpleQParserPlugin should as > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
