[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[ https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034585#comment-15034585 ] ASF subversion and git services commented on SOLR-8338: --- Commit 1717534 from [~cpoerschke] in branch 'dev/trunk' [ https://svn.apache.org/r1717534 ] SOLR-8338: in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent > in OverseerTest replace strings such as "collection1" and "state" > - > > Key: SOLR-8338 > URL: https://issues.apache.org/jira/browse/SOLR-8338 > Project: Solr > Issue Type: Test >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-8338.patch > > > replace with variable or enum equivalent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[ https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034601#comment-15034601 ] ASF subversion and git services commented on SOLR-8338: --- Commit 1717538 from [~cpoerschke] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717538 ] SOLR-8338: in OverseerTest replace strings such as "collection1" and "state" with variable or enum equivalent (merge in revision 1717526 from trunk) > in OverseerTest replace strings such as "collection1" and "state" > - > > Key: SOLR-8338 > URL: https://issues.apache.org/jira/browse/SOLR-8338 > Project: Solr > Issue Type: Test >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-8338.patch > > > replace with variable or enum equivalent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[
https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034587#comment-15034587
]
Christine Poerschke commented on SOLR-8338:
---
[ https://svn.apache.org/r1717526 ] was the actual commit but I mistakenly put
$\{message\} as a commit message for it.
> in OverseerTest replace strings such as "collection1" and "state"
> -
>
> Key: SOLR-8338
> URL: https://issues.apache.org/jira/browse/SOLR-8338
> Project: Solr
> Issue Type: Test
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-8338.patch
>
>
> replace with variable or enum equivalent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[
https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026549#comment-15026549
]
Christine Poerschke commented on SOLR-8338:
---
Thanks for the review Ishan. I wasn't aware of
{{SolrTestCaseJ4.DEFAULT_TEST_CORENAME}} until now. How about adding a
{{SolrTestCaseJ4.DEFAULT_TEST_COLLECTION_NAME}} and then using that instead of
the current {{"collection1"}}?
{code}
public abstract class SolrTestCaseJ4 extends LuceneTestCase {
- public static final String DEFAULT_TEST_CORENAME = "collection1";
+ public static final String DEFAULT_TEST_COLLECTION_NAME = "collection1";
+ public static final String DEFAULT_TEST_CORENAME =
DEFAULT_TEST_COLLECTION_NAME;
{code}
> in OverseerTest replace strings such as "collection1" and "state"
> -
>
> Key: SOLR-8338
> URL: https://issues.apache.org/jira/browse/SOLR-8338
> Project: Solr
> Issue Type: Test
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-8338.patch
>
>
> replace with variable or enum equivalent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[ https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026614#comment-15026614 ] Ishan Chattopadhyaya commented on SOLR-8338: Sounds good! > in OverseerTest replace strings such as "collection1" and "state" > - > > Key: SOLR-8338 > URL: https://issues.apache.org/jira/browse/SOLR-8338 > Project: Solr > Issue Type: Test >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-8338.patch > > > replace with variable or enum equivalent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8338) in OverseerTest replace strings such as "collection1" and "state"
[ https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025597#comment-15025597 ] Ishan Chattopadhyaya commented on SOLR-8338: +1, LGTM. Though, just a thought, should we use SolrTestCaseJ4.DEFAULT_TEST_CORENAME for "collection1"? > in OverseerTest replace strings such as "collection1" and "state" > - > > Key: SOLR-8338 > URL: https://issues.apache.org/jira/browse/SOLR-8338 > Project: Solr > Issue Type: Test >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-8338.patch > > > replace with variable or enum equivalent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
