[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2017-01-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844131#comment-15844131
 ] 

ASF subversion and git services commented on SOLR-8491:
---

Commit 7957fd65ab63add133b01a615dad7a36b1c2976a in lucene-solr's branch 
refs/heads/branch_6_4 from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7957fd6 ]

SOLR-8491: solr.cmd SOLR_SSL_OPTS is overwritten


> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 5.3, 5.4, 5.5, 6.0, 6.1, 6.2, 6.3, 6.4
> Environment: Windows
>Reporter: Sam Yi
>Assignee: Kevin Risden
> Fix For: 6.4.1, 6.5, master (7.0)
>
> Attachments: SOLR-8491.patch
>
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2017-01-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844130#comment-15844130
 ] 

ASF subversion and git services commented on SOLR-8491:
---

Commit 71a198ce309e35c8b31bf472b3d111dbaed276bf in lucene-solr's branch 
refs/heads/branch_6x from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71a198c ]

SOLR-8491: solr.cmd SOLR_SSL_OPTS is overwritten


> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 5.3, 5.4, 5.5, 6.0, 6.1, 6.2, 6.3, 6.4
> Environment: Windows
>Reporter: Sam Yi
>Assignee: Kevin Risden
> Fix For: 6.4.1, 6.5, master (7.0)
>
> Attachments: SOLR-8491.patch
>
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2017-01-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844129#comment-15844129
 ] 

ASF subversion and git services commented on SOLR-8491:
---

Commit bb5bf3fbf733b2dcea1163cad7a70a6437ece93f in lucene-solr's branch 
refs/heads/master from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bb5bf3f ]

SOLR-8491: solr.cmd SOLR_SSL_OPTS is overwritten


> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 5.3, 5.4, 5.5, 6.0, 6.1, 6.2, 6.3, 6.4
> Environment: Windows
>Reporter: Sam Yi
>Assignee: Kevin Risden
> Fix For: 6.4.1, 6.5, master (7.0)
>
> Attachments: SOLR-8491.patch
>
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2017-01-28 Thread Kevin Risden (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844113#comment-15844113
 ] 

Kevin Risden commented on SOLR-8491:


I tested the attached patch and it works as expected now. I'll commit in a 
little bit.

> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 5.3, 5.4, 5.5, 6.0, 6.1, 6.2, 6.3, 6.4
> Environment: Windows
>Reporter: Sam Yi
>Assignee: Kevin Risden
> Fix For: 6.4.1, 6.5, master (7.0)
>
> Attachments: SOLR-8491.patch
>
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2017-01-27 Thread Kevin Risden (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843436#comment-15843436
 ] 

Kevin Risden commented on SOLR-8491:


I'll submit a patch for this in a few minutes. I hope to test this this 
afternoon. It would be great to get into 6.4.1.

> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 6.0
> Environment: Windows
>Reporter: Sam Yi
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2016-11-07 Thread Marcel Berteler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644255#comment-15644255
 ] 

Marcel Berteler commented on SOLR-8491:
---

@sam Yi already mentioned the fix:

line 49 and 51: change 

{code:xml}
%SOLR_SSL_OPTS% 
{code}

to 

{code:xml}
!SOLR_SSL_OPTS!
{code}

Can this please be fixed? Without applying this fix, the only way to get SSL to 
work is by editing the xml files in the etc folder, which is clearly not the 
best solution.

> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Improvement
>  Components: scripts and tools
>Affects Versions: 5.2, 6.0
> Environment: Windows
>Reporter: Sam Yi
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8491) solr.cmd SOLR_SSL_OPTS is overwritten

2016-01-06 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/SOLR-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085197#comment-15085197
 ] 

Jan Høydahl commented on SOLR-8491:
---

Please feel free to submit a patch if you have a working solution.

> solr.cmd SOLR_SSL_OPTS is overwritten
> -
>
> Key: SOLR-8491
> URL: https://issues.apache.org/jira/browse/SOLR-8491
> Project: Solr
>  Issue Type: Bug
>  Components: scripts and tools
>Affects Versions: 5.2, Trunk
> Environment: Windows
>Reporter: Sam Yi
>
> In solr.cmd, the SOLR_SSL_OPTS variable is assigned within a block, but then 
> assigned again later in the same block, using {{%SOLR_SSL_OPTS%}} to attempt 
> to append to itself.  However, since we're still inside the same block for 
> this 2nd assignment, {{%SOLR_SSL_OPTS%}} resolves to nothing, so everything 
> in the first assignment (the solr.jetty opts) becomes overwritten.
> I was able to work around this by using {code}!SOLR_SSL_OPTS!{code} instead 
> of {{%SOLR_SSL_OPTS%}} in the 2nd assignments (in both the {{IF}} and 
> {{ELSE}} blocks), since delayed expension is enabled.
> Here's the full block for reference, from commit 
> d4e3f50a6f6bc7b96fa6317f028ae26be25c8928, lines 43-55:
> {code}IF DEFINED SOLR_SSL_KEY_STORE (
>   set "SOLR_JETTY_CONFIG=--module=https"
>   set SOLR_URL_SCHEME=https
>   set "SCRIPT_ERROR=Solr server directory %SOLR_SERVER_DIR% not found!"
>   set "SOLR_SSL_OPTS=-Dsolr.jetty.keystore=%SOLR_SSL_KEY_STORE% 
> -Dsolr.jetty.keystore.password=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Dsolr.jetty.truststore=%SOLR_SSL_TRUST_STORE% 
> -Dsolr.jetty.truststore.password=%SOLR_SSL_TRUST_STORE_PASSWORD% 
> -Dsolr.jetty.ssl.needClientAuth=%SOLR_SSL_NEED_CLIENT_AUTH% 
> -Dsolr.jetty.ssl.wantClientAuth=%SOLR_SSL_WANT_CLIENT_AUTH%"
>   IF DEFINED SOLR_SSL_CLIENT_KEY_STORE  (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_CLIENT_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_CLIENT_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_CLIENT_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_CLIENT_TRUST_STORE_PASSWORD%"
>   ) ELSE (
> set "SOLR_SSL_OPTS=%SOLR_SSL_OPTS% 
> -Djavax.net.ssl.keyStore=%SOLR_SSL_KEY_STORE% 
> -Djavax.net.ssl.keyStorePassword=%SOLR_SSL_KEY_STORE_PASSWORD% 
> -Djavax.net.ssl.trustStore=%SOLR_SSL_TRUST_STORE% 
> -Djavax.net.ssl.trustStorePassword=%SOLR_SSL_TRUST_STORE_PASSWORD%"
>   )
> ) ELSE (
>   set SOLR_SSL_OPTS=
> )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org