[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121667#comment-15121667 ] Joel Bernstein commented on SOLR-8602: -- I think the error handling in ResultSetImpl constructor is correct. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121784#comment-15121784 ] ASF subversion and git services commented on SOLR-8602: --- Commit 79e384bac5604fe999bd7293ea568b8ad7a014c7 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=79e384b ] SOLR-8602: Implement ResultSetImpl.wasNull() > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121754#comment-15121754 ] Joel Bernstein commented on SOLR-8602: -- Currently the result set tests are only testing queries with a limit clause. I'm going to have to leave it that way for now because the the /export handler doesn't handle null values at all currently. There is an open ticket for this (SOLR-8285). When I work on SOLR-8285 I'll rework the JDBC tests to reflect the different null handling behaviors of the /select handler and the /export handler. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121365#comment-15121365 ] Joel Bernstein commented on SOLR-8602: -- I was just reviewing the exception handling in ResultSetImpl constructor. It looks ok but wanted to check to make sure the underlying error was being thrown properly in the driver. For example did the DBVisualizer debug panel display the message about the numWorkers error. The way this works is that the SolrStream recognizes errors coming from the server through a flag in the Tuple. If it sees this flag it throws an Exception with the message. This should have been thrown on the first call to read() with the numWorker error. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121375#comment-15121375 ] Joel Bernstein commented on SOLR-8602: -- Doing some more review. That particular exception would have been thrown during the open() call on the server. This should have caused the first Tuple read in the jdbc driver to throw an exception with the correct message from the server. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121417#comment-15121417 ] Kevin Risden commented on SOLR-8602: The issue was that there was no exception added to the RuntimeException. It was missing the argument after the message. I updated the patch to include adding the exception to the RunTimeException. I am uploading a new patch with the exception handling being better. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121356#comment-15121356 ] Joel Bernstein commented on SOLR-8602: -- There are lot's of inconsistencies between limited and unlimited queries. For example limited queries can return any stored field and unlimited queries can only return docValues fields. The reason these inconsistencies exist is that the /export handler has much tighter restrictions then the /select handler. For the early SQL releases we can just document these inconsistencies. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121460#comment-15121460 ] Joel Bernstein commented on SOLR-8602: -- What was the change in this patch? > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121497#comment-15121497 ] Kevin Risden commented on SOLR-8602: H guess I had changed it already. I also consolidated the try/catch in the constructor so it will throw the same error if either the first tuple or the metadata tuple fails to be read. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121492#comment-15121492 ] Kevin Risden commented on SOLR-8602: For reference, on MySQL "select id, bad from test" results in an invalid field bad error. This means that limit statements are doing the wrong thing right now. I will file a JIRA for this issue. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121468#comment-15121468 ] Kevin Risden commented on SOLR-8602: changed new RuntimeException(MESSAGE) to new RuntimeException(MESSAGE, ERROR) in ResultSetImpl. This propagates the error up the client instead of swallowing why stream.read failed. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121489#comment-15121489 ] Joel Bernstein commented on SOLR-8602: -- The code I was reviewing already was doing that in the constructor. Was there another place? > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121563#comment-15121563 ] Joel Bernstein commented on SOLR-8602: -- Ok, I'll review. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121776#comment-15121776 ] Joel Bernstein commented on SOLR-8602: -- Planning on committing this shortly. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120391#comment-15120391 ] Joel Bernstein commented on SOLR-8602: -- Latest patch is looking good. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120582#comment-15120582 ] Joel Bernstein commented on SOLR-8602: -- Alright I found the bug. I'll work with your latest patch and add the bug fix. We'll fix this bug as part of this ticket. Good job turning up this bug. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120491#comment-15120491 ] Kevin Risden commented on SOLR-8602: sounds good to me. The last attached patch 21KB ~6pm works correctly. It has tests for missing column. I'll create a beef up jdbc jira issue and can move the work there. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120526#comment-15120526 ] Joel Bernstein commented on SOLR-8602: -- >From what I can see the meta data Tuple should work OK in parallel mode. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120447#comment-15120447 ] Kevin Risden commented on SOLR-8602: I want to add a few more test cases: * testing with facet instead of map_reduce on the connection * testing with a column that doesn't exist like missingcol and see if that comes back with all nulls (not sure how something like mysql handles this) > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120467#comment-15120467 ] Joel Bernstein commented on SOLR-8602: -- If we want to see how the /export handler behaves in the test case we leave the limit clause off the SQL statement and it will switch to the /export handler. I'm planning on committing the patch as is though so no need to put more work into this now. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120561#comment-15120561 ] Joel Bernstein commented on SOLR-8602: -- This was on a simple select no limit? > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120578#comment-15120578 ] Joel Bernstein commented on SOLR-8602: -- I've got it reproducing. I'll figure out what the problem is. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120505#comment-15120505 ] Kevin Risden commented on SOLR-8602: Created SOLR-8608 and linked appropriate JIRAs. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120429#comment-15120429 ] Joel Bernstein commented on SOLR-8602: -- I believe in the case of the /export handler numerics will never be null. This is because numerics are read from NumericDocValues which I believe treats nulls as 0. But as you proven with the test case the /select handler will return null values for numerics. I was surprised to see that you could put a null value in an int field and that would behave properly. I'm assuming the field is not added to the document if the field value is null. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120482#comment-15120482 ] Joel Bernstein commented on SOLR-8602: -- Ok, I'll work with the new patch. The facet / map_reduce flag will only come into play with Select DISTINCT and GROUP BY aggregations. I think the thing to do with this is to add a jira ticket called something like "Beef up Jdbc tests". In that ticket we can add more tests for aggregations and randomize the facet / map_reduce flag. This also something that can be done outside the DBVisualizer work so we can close out SOLR-8502 and declare victory. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120522#comment-15120522 ] Joel Bernstein commented on SOLR-8602: -- I'm not in a hurry. Let me know if you want me to take a look. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120568#comment-15120568 ] Joel Bernstein commented on SOLR-8602: -- I'll take you're last patch and change numWorkers=2 and see what happens. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120565#comment-15120565 ] Joel Bernstein commented on SOLR-8602: -- Weird from a code review I don't see how you would be getting that bug. Can you post the exact test that was failing? > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120719#comment-15120719 ] Kevin Risden commented on SOLR-8602: It looks good except that lines 372 and 373 are commented out. Those 2 lines are tests for a sql statement without a limit. "missingcol" isn't a real column in the schema, but is part of the select statement. This may or may not be valid SQL, but I thought it was. If those tests are run, then the following error occurs at the client: {code} java.sql.SQLException: java.lang.RuntimeException: Couldn't get the first tuple at __randomizedtesting.SeedInfo.seed([26B9AF1BDBAE7536:81FD17BFB615668F]:0) at org.apache.solr.client.solrj.io.sql.StatementImpl.executeQuery(StatementImpl.java:78) at org.apache.solr.client.solrj.io.sql.JdbcTest.testJDBCMethods(JdbcTest.java:400) at org.apache.solr.client.solrj.io.sql.JdbcTest.testDriverMetadata(JdbcTest.java:372) at org.apache.solr.client.solrj.io.sql.JdbcTest.doTest(JdbcTest.java:353) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:483) at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1764) at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:871) at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:907) at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:921) at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:965) at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:940) at com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50) at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46) at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:49) at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:65) at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:367) at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:809) at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:460) at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:880) at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:781) at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:816) at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:827) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42) at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:54) at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120608#comment-15120608 ] Joel Bernstein commented on SOLR-8602: -- [~risdenk], let me know if you want to work some with this patch or if you think it's ready to go. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120721#comment-15120721 ] Kevin Risden commented on SOLR-8602: If this is a valid SQL statement then it needs to work for both limit and non limit statements. If it is NOT valid then it needs to not work for both limit and non limit statements. Currently it is handled differently between limit and non limit statements which is weird to me. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120480#comment-15120480 ] Kevin Risden commented on SOLR-8602: Looks like with aggregationMode=map_reduce and workers=2 then metadata tuple isn't present. If you want to commit it as is that is fine just need to figure out why this is happening. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120559#comment-15120559 ] Joel Bernstein commented on SOLR-8602: -- This sounds like a you've found a bug. The SQLHandler should not be getting tripped up like that. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org