[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169418#comment-15169418
 ] 

ASF subversion and git services commented on SOLR-8734:
---

Commit 55b3614fd37eeb1cf6ac2d2ef6c902d18e42d135 in lucene-solr's branch 
refs/heads/branch_5_5 from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=55b3614 ]

SOLR-8734: fix (maxMergeDocs|mergeFactor) deprecation warnings: in 
solrconfig.xml  may not be combined with 
 and  on their own or combined 
with  is a warning.

(Resolved conflict for solr/CHANGES.txt file.)


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169420#comment-15169420
 ] 

ASF subversion and git services commented on SOLR-8734:
---

Commit c7214a2ba5f96492e5c4cd6a558734217afe5089 in lucene-solr's branch 
refs/heads/branch_5_5 from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7214a2 ]

Merge 5.5.1 changes sections from SOLR-8737 and SOLR-8734 tickets.


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169394#comment-15169394
 ] 

ASF subversion and git services commented on SOLR-8734:
---

Commit b1c06eed306366c54cccd71166a80fb4bb1d0235 in lucene-solr's branch 
refs/heads/branch_5x from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b1c06ee ]

SOLR-8734: fix (maxMergeDocs|mergeFactor) deprecation warnings: in 
solrconfig.xml  may not be combined with 
 and  on their own or combined 
with  is a warning.

(Resolved conflict for solr/CHANGES.txt file.)


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169338#comment-15169338
 ] 

ASF subversion and git services commented on SOLR-8734:
---

Commit 0ed625b107264f2ed079b9e07e4f885b7398a6c4 in lucene-solr's branch 
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ed625b ]

SOLR-8734: fix (maxMergeDocs|mergeFactor) deprecation warnings: in 
solrconfig.xml  may not be combined with 
 and  on their own or combined 
with  is a warning.


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[Markus Jelsma (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167343#comment-15167343
 ] 

Markus Jelsma commented on SOLR-8734:
-

Hello these configurations have neither  nor  
configurated.


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[Christine Poerschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167071#comment-15167071
 ] 

Christine Poerschke commented on SOLR-8734:
---

bq. ... to detect the existence of  element in the .xml, and not 
compare the value to the default. ...

If I understood you right this means to distinguish
{code}
...
-1
...
...
{code}
from
{code}
...
{code}
where -1 is the default value for the  element. The motivation 
perhaps being that when SOLR-8668 removes  (and ) 
element support the {{-1}} likely would remain 
behind as a zombie element?

Might we go even further than detecting the existence of a deprecated 
 element and detect any and all unsupported elements? Unsupported 
elements could be simple typos on part of the user e.g. {{}} 
instead of {{}} or they could be misplaced elements e.g. 
[test-files/solr/collection1/conf/solrconfig-spellcheckcomponent.xml|https://github.com/apache/lucene-solr/blob/master/solr/core/src/test-files/solr/collection1/conf/solrconfig-spellcheckcomponent.xml#L34]
 seems to have {{indexConfig/query/maxWarmingSearchers}} when possibly 
{{query/maxWarmingSearchers}} was intended (SOLR-8682 exists for that).


> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

[Shai Erera (JIRA)]

[ 
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167049#comment-15167049
 ] 

Shai Erera commented on SOLR-8734:
--

Patch looks good. Even while working on the previous issue I thought that we 
should be able to detect the existence of {{}} element in the 
.xml, and not compare the value to the default. What happens if someone 
includes both {{}} and {{}} set to the default 
value? Would we also fail?

> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 5.5, master
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5,  is deprecated, 
> configure it on the relevant  instead.
> ...
> bq. On my development machine for all cores. None of the cores has either 
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a  element 
> (for which deprecated warnings would appear separately) or that the 
> solrconfig.xml has no  element?
> ...
> bq. If either is the case then yes based on the code 
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless 
> though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org