[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966182#comment-15966182
]
Peter Ciuffetti commented on SOLR-8769:
---
It would appear the original fetch is also hardwired to 'id' and does not use
the name established by uniqueKey:
https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L180
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: 5.5.1, 6.0
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253079#comment-15253079
]
Anshum Gupta commented on SOLR-8769:
branch_5x
{code}
commit 8dc61cecdc933b52a8ec15eb34756e50ee2378ab
Author: anshum
Date: Thu Mar 3 15:27:04 2016 -0800
SOLR-8769: Fix document exclusion in mlt query parser in Cloud mode for
schemas that have non-'id' unique field
{code}
branch_5_5
{code}
commit 66f47a53f904bab2d845a1a3baf2e0090830cfc7
Author: anshum
Date: Thu Mar 3 15:27:04 2016 -0800
SOLR-8769: Fix document exclusion in mlt query parser in Cloud mode for
schemas that have non-'id' unique field
{code}
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: master, 6.0, 5.5.1
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179108#comment-15179108
]
ASF subversion and git services commented on SOLR-8769:
---
Commit 18874ababc73404356bd24fef2687d33f9489887 in lucene-solr's branch
refs/heads/branch_6_0 from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=18874ab ]
SOLR-8769: Fix document exclusion in mlt query parser in Cloud mode for schemas
that have non-'id' unique field
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: master, 6.0
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179007#comment-15179007
]
Anshum Gupta commented on SOLR-8769:
I'm waiting to hear back from Nick before I port this for the 6.0 release.
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: master, 6.0
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178866#comment-15178866
]
ASF subversion and git services commented on SOLR-8769:
---
Commit ba039f7c8c28518053776fe9952e5cb93c5b3f75 in lucene-solr's branch
refs/heads/branch_6x from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ba039f7 ]
SOLR-8769: Fix document exclusion in mlt query parser in Cloud mode for schemas
that have non-'id' unique field
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: master, 6.0
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8769) CloudMLTQParser does not use uniqueKey field name for exclusion
[
https://issues.apache.org/jira/browse/SOLR-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178861#comment-15178861
]
Anshum Gupta commented on SOLR-8769:
Thanks for pointing this out [~ehatcher]. I committed this but forgot to
specify the JIRA#.
I tried to amend the commit message but for some reason that isn't working.
Until that happens, thought I'll update the JIRA manually.
Here's the commit hash: 44d8ee9115ebcfdaba03238031b68a58dbcc4cd6
> CloudMLTQParser does not use uniqueKey field name for exclusion
> ---
>
> Key: SOLR-8769
> URL: https://issues.apache.org/jira/browse/SOLR-8769
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
> Fix For: master, 6.0
>
>
> Using the {{\{!mlt}}} query parser in cloud mode on a schema with a non-"id"
> uniqueKey, the main "like this" document won't be excluded properly due to
> this code:
> {code}
> realMLTQuery.add(createIdQuery("id", id), BooleanClause.Occur.MUST_NOT);
> {code}
> See also
> https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/solr/core/src/java/org/apache/solr/search/mlt/CloudMLTQParser.java#L166
> Like SimpleMLTQParser, it needs to use the uniqueKey field with this type of
> code: {{req.getSchema().getUniqueKeyField().getName()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
