[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253073#comment-15253073
]
Anshum Gupta commented on SOLR-8779:
branch_5x
{code}
commit 1ce5e533c551bf04fd256cd945be2cb9a261f069
Author: Varun Thacker
Date: Fri Mar 4 18:08:53 2016 +0530
SOLR-8779: Fix missing InterruptedException handling in ZkStateReader
{code}
branch_5_5
{code}
commit 6024572a53fc3af8fbb2f3d0cf51cf46d7406350
Author: Varun Thacker
Date: Fri Mar 4 18:08:53 2016 +0530
SOLR-8779: Fix missing InterruptedException handling in ZkStateReader
{code}
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 6.0, 5.5.1
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179962#comment-15179962
]
ASF subversion and git services commented on SOLR-8779:
---
Commit 45ddc181486c15022577b23f37e6bded1dadeef7 in lucene-solr's branch
refs/heads/branch_6_0 from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=45ddc18 ]
SOLR-8779: Fix missing InterruptedException handling in ZkStateReader
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179960#comment-15179960
]
ASF subversion and git services commented on SOLR-8779:
---
Commit 1cbf22569a38add32eae22b38d5f02257ada3fed in lucene-solr's branch
refs/heads/branch_6x from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1cbf225 ]
SOLR-8779: Fix missing InterruptedException handling in ZkStateReader
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179958#comment-15179958
]
ASF subversion and git services commented on SOLR-8779:
---
Commit 21bf9c6e8045adce3301a7a92766f9c43a49ba71 in lucene-solr's branch
refs/heads/master from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21bf9c6 ]
SOLR-8779: Fix missing InterruptedException handling in ZkStateReader
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179931#comment-15179931
]
Nicholas Knize commented on SOLR-8779:
--
bq. this is a bug . It's fine if I commit it to the 6_0 branch as well?
+1
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179835#comment-15179835
]
Varun Thacker commented on SOLR-8779:
-
Thanks Scott for the review!
I'll commit this soon.
Hi [~nknize] , this is a bug . It's fine if I commit it to the 6_0 branch as
well?
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8779) Fix missing InterruptedException handling in ZkStateReader
[
https://issues.apache.org/jira/browse/SOLR-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178019#comment-15178019
]
Scott Blum commented on SOLR-8779:
--
LGTM
> Fix missing InterruptedException handling in ZkStateReader
> --
>
> Key: SOLR-8779
> URL: https://issues.apache.org/jira/browse/SOLR-8779
> Project: Solr
> Issue Type: Bug
>Reporter: Varun Thacker
> Fix For: 6.0
>
> Attachments: SOLR-8779.patch
>
>
> I was debugging a zk session expired issue and saw this stack-trace
> {code}
> ERROR - 2016-03-03 06:55:53.873; [ ] org.apache.solr.common.SolrException;
> OverseerAutoReplicaFailoverThread had an error in its thread work
> loop.:org.apache.solr.common.SolrException: Error reading cluster properties
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
> at
> org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
> at
> org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
> at
> org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
> ... 3 more
> {code}
> So I audited ZKStateReader and found a couple of places where an
> InterruptedException was caught but the interrupt flag wasn't set back.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
