[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252753#comment-15252753 ] ASF subversion and git services commented on SOLR-8837: --- Commit 55ac1ab95819f307f8056f8ddffbdd349ea51247 in lucene-solr's branch refs/heads/branch_5_5 from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=55ac1ab ] SOLR-8837: Fix duplicate election node detection > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 6.0, 5.5.1 > > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252651#comment-15252651 ] ASF subversion and git services commented on SOLR-8837: --- Commit 0b7b28a04157f4a74020ea79a29ad74c280f137f in lucene-solr's branch refs/heads/branch_5x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b7b28a ] SOLR-8837: Fix duplicate election node detection > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 6.0, 5.5.1 > > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204748#comment-15204748 ] ASF subversion and git services commented on SOLR-8837: --- Commit 9a4c1dd15c80ec3265b8be5dc716672ec9a9973d in lucene-solr's branch refs/heads/branch_6_0 from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a4c1dd ] SOLR-8837: Fix duplicate election node detection > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204716#comment-15204716 ] ASF subversion and git services commented on SOLR-8837: --- Commit 451ff488afc4707cb8555c5629bcf0c9ebef210f in lucene-solr's branch refs/heads/branch_6x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=451ff48 ] SOLR-8837: Fix duplicate election node detection > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204714#comment-15204714 ] ASF subversion and git services commented on SOLR-8837: --- Commit 04bd5860710ca5ab309d2e8b2e8fb36d3bf962bc in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=04bd586 ] SOLR-8837: Fix duplicate election node detection > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204489#comment-15204489 ] Alan Woodward commented on SOLR-8837: - Thanks Scott, I'll commit this fix. Looks like the bug crept in with SOLR-8697, so it hasn't actually been released. > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward > Attachments: SOLR-8837.patch > > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192317#comment-15192317 ] Alan Woodward commented on SOLR-8837: - We can fix this by fixing the duplicate-detection logic, but I'm not sure we shouldn't just remove this entirely. I guess it could prevent an election delay in the case that a session gets interrupted and the ephemeral nodes from the previous session hang around up to the session timeout, but it seems just as likely to cause problems to me. > Duplicate leader elector node detection is broken > - > > Key: SOLR-8837 > URL: https://issues.apache.org/jira/browse/SOLR-8837 > Project: Solr > Issue Type: Bug >Affects Versions: master, 6.0 >Reporter: Alan Woodward > > LeaderElector.checkIfIAmLeader checks to see if it has duplicate > registrations in under its election node, but it does this by prefix > checking, which means that if core_node1 registers itself after core_node11, > it will think it's a duplicate, and delete the core_node11 node. > This is causing regular failures in UnloadDistributedZkTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
