[jira] [Commented] (SOLR-8855) The HDFS BlockDirectory should not clean up it's cache on shutdown.
[ https://issues.apache.org/jira/browse/SOLR-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1541#comment-1541 ] ASF subversion and git services commented on SOLR-8855: --- Commit d9c3c7e6f0692319ae7ef5e52bc47e76360d17d9 in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d9c3c7e ] SOLR-8855: The HDFS BlockDirectory should not clean up it's cache on shutdown. > The HDFS BlockDirectory should not clean up it's cache on shutdown. > --- > > Key: SOLR-8855 > URL: https://issues.apache.org/jira/browse/SOLR-8855 > Project: Solr > Issue Type: Improvement >Reporter: Mark Miller >Assignee: Mark Miller > Fix For: master, 6.1 > > Attachments: SOLR-8855.patch > > > The cache cleanup is done for early close and the global cache. On shutdown > it just burns time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8855) The HDFS BlockDirectory should not clean up it's cache on shutdown.
[ https://issues.apache.org/jira/browse/SOLR-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207243#comment-15207243 ] ASF subversion and git services commented on SOLR-8855: --- Commit 9aeb745a7daf84a8365e3d823ea314d9d371ae9b in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9aeb745 ] SOLR-8855: The HDFS BlockDirectory should not clean up it's cache on shutdown. > The HDFS BlockDirectory should not clean up it's cache on shutdown. > --- > > Key: SOLR-8855 > URL: https://issues.apache.org/jira/browse/SOLR-8855 > Project: Solr > Issue Type: Improvement >Reporter: Mark Miller >Assignee: Mark Miller > Fix For: master, 6.1 > > Attachments: SOLR-8855.patch > > > The cache cleanup is done for early close and the global cache. On shutdown > it just burns time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8855) The HDFS BlockDirectory should not clean up it's cache on shutdown.
[ https://issues.apache.org/jira/browse/SOLR-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204727#comment-15204727 ] Mark Miller commented on SOLR-8855: --- bq. Is this safe? It looks like we'd be dropping data that is still in the cache but hasn't been written yet. Not sure I understand that - this stops dropping from the cache, it does not add it. bq. Why does the core container need to be volatile? Because it is set in init - and we don't really know when an external user may call that or in what thread. Technically, if that is to be thread safe, it should be set in the constructor and be finally or be volatile. Given volatile reads without updates are basically as fast as regular reads, just better to be airtight IMO. > The HDFS BlockDirectory should not clean up it's cache on shutdown. > --- > > Key: SOLR-8855 > URL: https://issues.apache.org/jira/browse/SOLR-8855 > Project: Solr > Issue Type: Improvement >Reporter: Mark Miller >Assignee: Mark Miller > Fix For: master, 6.1 > > Attachments: SOLR-8855.patch > > > The cache cleanup is done for early close and the global cache. On shutdown > it just burns time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8855) The HDFS BlockDirectory should not clean up it's cache on shutdown.
[ https://issues.apache.org/jira/browse/SOLR-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204703#comment-15204703 ] Mike Drob commented on SOLR-8855: - Is this safe? It looks like we'd be dropping data that is still in the cache but hasn't been written yet. Why does the core container need to be volatile? > The HDFS BlockDirectory should not clean up it's cache on shutdown. > --- > > Key: SOLR-8855 > URL: https://issues.apache.org/jira/browse/SOLR-8855 > Project: Solr > Issue Type: Improvement >Reporter: Mark Miller >Assignee: Mark Miller > Fix For: master, 6.1 > > Attachments: SOLR-8855.patch > > > The cache cleanup is done for early close and the global cache. On shutdown > it just burns time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
