[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293905#comment-15293905
]
ASF subversion and git services commented on SOLR-8992:
---
Commit 2c6f0282b4a29c69c5a5182d8babc52298d0f807 in lucene-solr's branch
refs/heads/branch_6_0 from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2c6f028 ]
SOLR-8992: branch_6_0: restore missing TestFieldCollectionResource tests
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Fix For: 6.0.1, 6.1, master (7.0)
>
> Attachments:
> SOLR-8992-branch_6_0-missing-TestFieldCollectionResource-tests.patch,
> SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268538#comment-15268538
]
ASF subversion and git services commented on SOLR-8992:
---
Commit f837216b3bd06c6e914206562b3c8c4cfdf8c1bd in lucene-solr's branch
refs/heads/branch_6_0 from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f837216 ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Fix For: master, 6.1
>
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266596#comment-15266596
]
Noble Paul commented on SOLR-8992:
--
will do that
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Fix For: master, 6.1
>
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266582#comment-15266582
]
Steve Rowe commented on SOLR-8992:
--
I think this should be backported to branch_6_0 for a 6.0.1 release.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Fix For: master, 6.1
>
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265812#comment-15265812
]
Yonik Seeley commented on SOLR-8992:
Has this issue been completed?
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262007#comment-15262007
]
ASF subversion and git services commented on SOLR-8992:
---
Commit 7fefc35dcfb84c74fec2ea1a8abd6dea1289bd18 in lucene-solr's branch
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7fefc35 ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262009#comment-15262009
]
ASF subversion and git services commented on SOLR-8992:
---
Commit 6c459779c58a49b685fe84fede737a40769d2d88 in lucene-solr's branch
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c45977 ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0 added
back another test and fixed test errors
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262008#comment-15262008
]
ASF subversion and git services commented on SOLR-8992:
---
Commit 6b7e965b85873ffa11d9b1c443748257c8767659 in lucene-solr's branch
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6b7e965 ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253747#comment-15253747
]
Noble Paul commented on SOLR-8992:
--
Yeah, I need to clean it up
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253469#comment-15253469
]
ASF subversion and git services commented on SOLR-8992:
---
Commit 827c670d189f9da56259b541db9b94113d3ca9a0 in lucene-solr's branch
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=827c670 ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0 added
back another test and fixed test errors
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253302#comment-15253302
]
Steve Rowe commented on SOLR-8992:
--
+1 to the latest patch. It did take me a while to grok the default case in
SchemaHandler.handleGET() though - the local variable names (realName,
fieldName, name, parts) are confusing. I suggest rethinking them so it's
clearer what's going on.
Noble, if you can't fix the SchemaTest failures right away, we should revert
your e8cc19e commit until a fix is in place.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252954#comment-15252954
]
Hoss Man commented on SOLR-8992:
every jenkins build that makes it far enough to run the solrj tests is failin
on this test...
ant test -Dtestcase=SchemaTest -Dtests.method=testSchemaRequestAccuracy
-Dtests.seed=B07EE1D8472F7C65 -Dtests.slow=true -Dtests.locale=es-VE
-Dtests.timezone=Europe/Nicosia -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
...taht seed (along with every other seed i tried) is failing reliably for me...
{noformat}
java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to
org.apache.solr.common.util.NamedList
at
__randomizedtesting.SeedInfo.seed([B07EE1D8472F7C65:3782EE7649D781E2]:0)
at
org.apache.solr.client.solrj.response.schema.SchemaResponse.setResponse(SchemaResponse.java:252)
at
org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:149)
at
org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:166)
at
org.apache.solr.client.solrj.request.SchemaTest.testSchemaRequestAccuracy(SchemaTest.java:123)
{noformat}
the problem seems to be e8cc19eb885c46d25b56fdd681825712516050c9, revert to the
previous SHA (2ee8426) and it passes
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch, SOLR-8992.patch, SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252206#comment-15252206
]
Steve Rowe commented on SOLR-8992:
--
Noble,
Looks like you didn't put back the ability to use
{{schema/fields/_fieldname_=true}}? When I put back this test
you removed under SOLR-8736, it fails with error {{No such path
/schema/fields/some_crazy_name_i}}:
{code:java|title=TestFieldResource.java}
public void testGetFieldIncludeDynamic() throws Exception {
assertQ("/schema/fields/some_crazy_name_i?indent=on=xml=true",
"/response/lst[@name='field']/str[@name='name'] = 'some_crazy_name_i'",
"/response/lst[@name='field']/str[@name='dynamicBase'] = '*_i'");
}
{code}
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252074#comment-15252074
]
Steve Rowe commented on SOLR-8992:
--
Crap, my misunderstanding about {{it.fun}} needing a null check - those lambdas
will never be null, but they may *return* null. Sorry for the noise.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252072#comment-15252072
]
Steve Rowe commented on SOLR-8992:
--
{quote}
bq. but you don't guard against that in SchemaProps.toMap(), so NPEs are
waiting to happen.
I think I have copied the code verbatim and it is guarded against NPEs
{code:java}
Object val = it.fun.apply(this);
if (val != null) topLevel.put(it.name, val);
{code}
{quote}
Which code are you talking about copying verbatim? The code below looks
completely new to me? And {{it.fun}} is never checked for null.
{code:java}@Override
public Map toMap() {
Map topLevel = new LinkedHashMap<>();
Stream.of(Handler.values())
.filter(it -> name == null || it.name.equals(name))
.forEach(it -> {
Object val = it.fun.apply(this);
if (val != null) topLevel.put(it.name, val);
});
return topLevel;
}
}
{code}
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252061#comment-15252061
]
Noble Paul commented on SOLR-8992:
--
bq. but you don't guard against that in SchemaProps.toMap(), so NPEs are
waiting to happen.
I think I have copied the code verbatim and it is guarded against NPEs
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252053#comment-15252053
]
Steve Rowe commented on SOLR-8992:
--
bq. did we ever guarantee the order?
No. But it will cost you nearly nothing to leave things the way they were.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252052#comment-15252052
]
Noble Paul commented on SOLR-8992:
--
bq.In the previous IndexSchema.getNamedPropertyValues(), fields were output
before dynamicFields,
did we ever guarantee the order?
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252049#comment-15252049
]
Steve Rowe commented on SOLR-8992:
--
Thanks for the patch Noble.
A few things I noticed:
# Two {{SchemaProps.Handler}} enum values ({{SOLR_QUERY_PARSER}} and
{{SIMILARITY}}) can have null lambdas (when they are not explicitly configured
in the schema), but you don't guard against that in {{SchemaProps.toMap()}}, so
NPEs are waiting to happen. There are no tests for these cases but there
should be.
# In the previous {{IndexSchema.getNamedPropertyValues()}}, {{fields}} were
output before {{dynamicFields}}, but the way you iterate your new
{{SchemaProps.Handler}} enum in {{SchemaProps.toMap()}}, {{DYNAMIC_FIELDS}}
will be called before {{FIELDS}}; as a result, the way whole schema output is
ordered will change. I think that's bad.
# In the {{SchemaProps}} ctor there is repeated field list extraction code (for
{{source.fl}}, {{dest.fl}} and {{fl}} params) that could be pulled out into a
method and called from each of those places, e.g. here's the {{fl}} version:
{code:java}
String[] fields = flParam.trim().split("[,\\s]+");
if (fields.length > 0)
requestedFields = new LinkedHashSet<>(Stream.of(fields)
.filter(it -> !it.trim().isEmpty())
.collect(Collectors.toList()));
{code}
# There are a couple new unused imports in {{IndexSchema.java}}:
{{com.google.common.base.Functions}} and {{org.apache.solr.common.util.Pair}}.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252027#comment-15252027
]
ASF subversion and git services commented on SOLR-8992:
---
Commit e8cc19eb885c46d25b56fdd681825712516050c9 in lucene-solr's branch
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e8cc19e ]
SOLR-8992: Restore Schema API GET method functionality removed in 6.0
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
> Attachments: SOLR-8992.patch
>
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242938#comment-15242938
]
Steve Rowe commented on SOLR-8992:
--
I think asking which of these is "essential" is the wrong question.
I think it's bad that we advertized these query parameters - and still do in
the ref guide to become 6.0's! - and then just dropped them. I vote for
putting them all back.
I'm ambivalent about the removed output information (identified with "The
following information is no longer output" above). +0 to not restore it.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242935#comment-15242935
]
Noble Paul commented on SOLR-8992:
--
which of these are essential and must be restored ?
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242931#comment-15242931
]
Noble Paul commented on SOLR-8992:
--
{{TestBulkSchemaConcurrent}} is a what you are looking for
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>Assignee: Noble Paul
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8992) Restore Schema API GET method functionality removed by SOLR-8736
[
https://issues.apache.org/jira/browse/SOLR-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242397#comment-15242397
]
Steve Rowe commented on SOLR-8992:
--
Also, {{TestCloudManagedSchemaConcurrent}} was {{@Ignored}} under SOLR-8736,
but no test was substituted. I haven't looked into whether the bulk schema API
has concurrent cloud tests.
> Restore Schema API GET method functionality removed by SOLR-8736
>
>
> Key: SOLR-8992
> URL: https://issues.apache.org/jira/browse/SOLR-8992
> Project: Solr
> Issue Type: Bug
>Reporter: Steve Rowe
>
> The following schema API GET functionality was removed under SOLR-8736; some
> of this functionality should be restored:
> * {{schema/copyfields}}:
> ** The following information is no longer output:
> *** {{destDynamicBase}}: the matching dynamic field pattern for the
> destination
> *** {{sourceDynamicBase}}: the matching dynamic field pattern for the source
> ** The following request parameters are no longer supported:
> *** {{dest.fl}}: include only copyFields that have one of these as a
> destination
> *** {{source.fl}}: include only copyFields that have one of these as a source
> * {{schema/dynamicfields}}:
> ** The following request parameters are no longer supported:
> *** {{fl}}: a comma and/or space separated list of dynamic field patterns to
> include
> * {{schema/fields}} and {{schema/fields/_fieldname_}}:
> ** The following information is no longer output:
> *** {{dynamicBase}}: the matching dynamic field pattern, if the
> {{includeDynamic}} param is given (see below)
> ** The following request parameters are no longer supported:
> *** {{fl}}: (only supported without {{/_fieldname_}}): a comma and/or space
> separated list of fields to include
> *** {{includeDynamic}}: output the matching dynamic field pattern as
> {{dynamicBase}}, if {{_fieldname_}}, or field(s) listed in {{fl}} param, are
> not explicitly declared in the schema
> * {{schema/fieldtypes}} and {{schema/fieldtypes/_typename_}}:
> ** The following information is no longer output:
> *** {{fields}}: the fields with the given field type
> *** {{dynamicFields}}: the dynamic fields with the given field type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
