[jira] [Commented] (SOLR-9020) Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
[ https://issues.apache.org/jira/browse/SOLR-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250583#comment-15250583 ] ASF subversion and git services commented on SOLR-9020: --- Commit d914ec4a67c42466f19e46169754965a7d5af35c in lucene-solr's branch refs/heads/branch_6x from [~risdenk] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d914ec4 ] SOLR-9020: Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods > Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper > errors for traversal methods > > > Key: SOLR-9020 > URL: https://issues.apache.org/jira/browse/SOLR-9020 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master, 6.0 >Reporter: Kevin Risden >Assignee: Kevin Risden > Attachments: SOLR-9020.patch > > > There are 4 methods related to fetch in StatementImpl and 4 methods related > to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that > don't make sense with the fetch direction. It would make sense to implement > them to support more SQL clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9020) Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
[ https://issues.apache.org/jira/browse/SOLR-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250575#comment-15250575 ] ASF subversion and git services commented on SOLR-9020: --- Commit a9a842f05dcebb6b86a6f47354aa760a83763e6c in lucene-solr's branch refs/heads/master from [~risdenk] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a9a842f ] SOLR-9020: Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods > Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper > errors for traversal methods > > > Key: SOLR-9020 > URL: https://issues.apache.org/jira/browse/SOLR-9020 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master, 6.0 >Reporter: Kevin Risden >Assignee: Kevin Risden > Attachments: SOLR-9020.patch > > > There are 4 methods related to fetch in StatementImpl and 4 methods related > to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that > don't make sense with the fetch direction. It would make sense to implement > them to support more SQL clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9020) Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
[ https://issues.apache.org/jira/browse/SOLR-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250548#comment-15250548 ] Joel Bernstein commented on SOLR-9020: -- Looks good to me. > Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper > errors for traversal methods > > > Key: SOLR-9020 > URL: https://issues.apache.org/jira/browse/SOLR-9020 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master, 6.0 >Reporter: Kevin Risden >Assignee: Kevin Risden > Attachments: SOLR-9020.patch > > > There are 4 methods related to fetch in StatementImpl and 4 methods related > to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that > don't make sense with the fetch direction. It would make sense to implement > them to support more SQL clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9020) Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
[ https://issues.apache.org/jira/browse/SOLR-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250534#comment-15250534 ] Kevin Risden commented on SOLR-9020: This should be good to go. [~joel.bernstein] - Can you take a look? > Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper > errors for traversal methods > > > Key: SOLR-9020 > URL: https://issues.apache.org/jira/browse/SOLR-9020 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master, 6.0 >Reporter: Kevin Risden >Assignee: Kevin Risden > Attachments: SOLR-9020.patch > > > There are 4 methods related to fetch in StatementImpl and 4 methods related > to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that > don't make sense with the fetch direction. It would make sense to implement > them to support more SQL clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9020) Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
[ https://issues.apache.org/jira/browse/SOLR-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250482#comment-15250482 ] Kevin Risden commented on SOLR-9020: As part of this found that there is a SQLFeatureNotSupportedException that can be thrown for some methods. I'm going to create a separate JIRA to audit the SQL classes and replace the UnsupportedOperationExceptions with SQLFeatureNotSupportedException where applicable. > Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper > errors for traversal methods > > > Key: SOLR-9020 > URL: https://issues.apache.org/jira/browse/SOLR-9020 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master, 6.0 >Reporter: Kevin Risden > Attachments: SOLR-9020.patch > > > There are 4 methods related to fetch in StatementImpl and 4 methods related > to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that > don't make sense with the fetch direction. It would make sense to implement > them to support more SQL clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
