[
https://issues.apache.org/jira/browse/SOLR-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267215#comment-15267215
]
David Smiley commented on SOLR-9055:
Thanks for contributing, [~hgadre]. I suggest renaming this to: Make
collection backup/restore extensible
Does this API enable the possibility of a hard-link based copy (applicable for
both backup & restore). It doesn't seem so but I'm unsure?
I have a general question about HDFS; I have no real experience with it: I
wonder if Java's NIO file abstractions could be used so we don't have to have
separate code? If so it would be wonderful -- simpler and less code to
maintain. See https://github.com/damiencarol/jsr203-hadoop What do you think?
Nitpick: In your editor, if it has this feature (IntelliJ does), configure it
to strip trailing whitespace _only on Modified Lines_. IntelliJ:
Editor/General/Other "Strip trailing spaces on Save".
Before committing to this API, it would be good to have it implement something
useful (HDFS or whatever), otherwise we very well may miss problems with the
API -- we probably will. I'm not saying this issue needs to implement HDFS,
but at least the proposed patch might have an implementation specific part in
some separate files that wouldn't be committed with this issue. I suppose this
isn't strictly required but it would help.
> Cleanup backup/restore implementation
> -
>
> Key: SOLR-9055
> URL: https://issues.apache.org/jira/browse/SOLR-9055
> Project: Solr
> Issue Type: Task
>Reporter: Hrishikesh Gadre
> Attachments: SOLR-9055.patch
>
>
> SOLR-5750 implemented backup/restore API for Solr. This JIRA is to track the
> code cleanup/refactoring. Specifically following improvements should be made,
> - Add Solr/Lucene version to check the compatibility between the backup
> version and the version of Solr on which it is being restored.
> - Add a backup implementation version to check the compatibility between the
> "restore" implementation and backup format.
> - Introduce a Strategy interface to define how the Solr index data is backed
> up (e.g. using file copy approach).
> - Introduce a Repository interface to define the file-system used to store
> the backup data. (currently works only with local file system but can be
> extended). This should be enhanced to introduce support for "registering"
> repositories (e.g. HDFS, S3 etc.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
