[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275942#comment-15275942
 ] 

ASF subversion and git services commented on SOLR-9071:
---

Commit 07b0dc86eb12612c88c7f135c0c40d5533d677f5 in lucene-solr's branch 
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=07b0dc8 ]

SOLR-9071: simplify hashcode() , equals() and implement toString()


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 6.1, master
>
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275938#comment-15275938
 ] 

ASF subversion and git services commented on SOLR-9071:
---

Commit f9eb4febc4b1ff948453eec23a445588fe0febf5 in lucene-solr's branch 
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f9eb4fe ]

SOLR-9071: simplify hashcode() , equals() and implement toString()


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 6.1, master
>
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-08 Thread Scott Blum (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275731#comment-15275731
 ] 

Scott Blum commented on SOLR-9071:
--

{code}
return Objects.hash(left, right);
{code}


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 6.1, master
>
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275498#comment-15275498
 ] 

ASF subversion and git services commented on SOLR-9071:
---

Commit 2bc376c7f54bf93a6564d210a46a4bae52ddf0b7 in lucene-solr's branch 
refs/heads/branch_6x from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2bc376c ]

SOLR-9071: rename the getters in org.apache.solr.common.util.Pair class


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275497#comment-15275497
 ] 

ASF subversion and git services commented on SOLR-9071:
---

Commit d57e0de5ea992417d97da6b39d26809b5b23adc4 in lucene-solr's branch 
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d57e0de ]

SOLR-9071: rename the getters in org.apache.solr.common.util.Pair class


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-06 Thread Christine Poerschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274182#comment-15274182
 ] 

Christine Poerschke commented on SOLR-9071:
---

Yes, so sounds like upgrading to 3.x could/would happen only when/after 
ZooKeeper depends on 3.x also, at some point in the future.

> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-06 Thread Shawn Heisey (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274176#comment-15274176
 ] 

Shawn Heisey commented on SOLR-9071:


I did some experimentation where I tried to upgrade to 3.4.

I fixed all resulting issues in *our* codebase -- Solr will compile ... but 
Zookeeper depends on the 2.x version, so SolrCloud doesn't work if you 
*upgrade* commons-lang.

I'm sure that both jars will coexist because of the package name change ... but 
including both would add 2.4MB (the size of the lang3 jar) to the download size 
of Solr.  That's is an insane thing to do if the primary motivation is "get rid 
of a few dozen lines of java code."


> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-06 Thread Noble Paul (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273801#comment-15273801
 ] 

Noble Paul commented on SOLR-9071:
--

We don't use commons lang3 or above. Our version is 2.6. Probably, we should 
move to 3.4, the latest

> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9071) rename the getters in org.apache.solr.common.util.Pair class

2016-05-05 Thread Erick Erickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272604#comment-15272604
 ] 

Erick Erickson commented on SOLR-9071:
--

Noble:

There was a note I saw go by (not on this patch) asking if it would be better 
just to switch to the Apache commons pair class and remove the solr.common.util 
one

http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/Pair.html

Haven't looked personally, so don't know which makes more sense. 

> rename the getters in org.apache.solr.common.util.Pair class
> 
>
> Key: SOLR-9071
> URL: https://issues.apache.org/jira/browse/SOLR-9071
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Attachments: SOLR-9071.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org