[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796136#comment-16796136 ] Kevin Risden commented on SOLR-9079: On current master there are 63 usages of org.apache.commons.lang. 2 are in lucene in javadoc. There is a really old patch from 2016 on SOLR-9459 to upgrade to lang3. git grep -F org.apache.commons.lang. | wc -l 63 > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759122#comment-16759122 ] Kevin Risden commented on SOLR-9079: It looks like Hadoop 3 doesn't rely on commons-lang anymore and only commons-lang3. I don't know if there is anything else in Solr that relies on commons-lang. Might be worth trying to remove and see what if anything breaks? > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759112#comment-16759112 ] Kevin Risden commented on SOLR-9079: Would be good to look at this again on master/8.x since SOLR-9515 upgraded Hadoop to Hadoop 3. There has been a lot of improvements on the Hadoop 3.x side in regards to dependency versions. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275309#comment-15275309 ] Mark Miller commented on SOLR-9079: --- I don't see commons-lang causing bloat or dependency hell. If we are going to use third party libraries at all, it seems like a simple one. Sure, if we are not taking advantage of a library, better to not depend on it, but I don't see a reason to try and save hundred's of K or even MB's here and there. I don't really like the idea of making our own Util versions to avoid dependencies either. We are not a library, we are a search server, and and the core dependencies are not that large at all in this age. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274706#comment-15274706 ] Mike Drob commented on SOLR-9079: - The arguments about developer effort to upgrade versions and ensure compatibility make sense to me. That seems more important than a couple of megabytes here or there. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274688#comment-15274688 ] Erick Erickson commented on SOLR-9079: -- +a lot, I hadn't thought sideways at the problem. The argument that "some other dependency includes it so we might as well use it" is not something I can subscribe to., it just means those other projects should see if they can get rid of those dependencies too ;) Smart-aleckness aside, I think there are very sound reasons to remove dependencies if we can. The point of third-party dependencies it to reduce the work developers need to do. Including a dependency requires ongoing work to maintain it (witness this discussion and Shawn's efforts to see about upgrading). So moving from some dependency to core Java seems like a total win to me. Of course "It Depends"(tm) on how much effort it would take to remove the dependencies. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274614#comment-15274614 ] Alan Woodward commented on SOLR-9079: - Depends if they're compile-time or runtime dependencies, I guess. I think it's worth exploring, anyway. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274593#comment-15274593 ] Mike Drob commented on SOLR-9079: - Is there a benefit to removing commons-lang or guava when we still transitively depend on them? > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274569#comment-15274569 ] Alan Woodward commented on SOLR-9079: - I'd actually go the other way, and try and remove commons-lang entirely. Guava too, and commons-configuration if we can. We're on Java 8 now, lots of the things that these libraries were introduced to fix are part of the core language. And the few methods that we do need, we can fork and include in a Utils package. Importing jars for the sake of a couple of classes just bloats the distribution and leads to dependency hell. > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9079) Upgrade commons-lang to version 3.x
[ https://issues.apache.org/jira/browse/SOLR-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274248#comment-15274248 ] Shawn Heisey commented on SOLR-9079: Finished checking the dependencies on all the non-lucene_solr jars in WEB-INF/lib, using maven central. Other dependencies (besides zookeeper) which depend on commons-lang 2.x: commons-configuration (we're using a release that's over 7 years old!) hadoop-common hadoop-hdfs > Upgrade commons-lang to version 3.x > --- > > Key: SOLR-9079 > URL: https://issues.apache.org/jira/browse/SOLR-9079 > Project: Solr > Issue Type: Wish >Reporter: Christine Poerschke >Priority: Minor > > Current version used is [/commons-lang/commons-lang = > 2.6|https://github.com/apache/lucene-solr/blob/master/lucene/ivy-versions.properties#L68] > and a key motivation would be to have > [commons.lang3|http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/package-summary.html] > APIs available e.g. > [org.apache.commons.lang3.tuple.Pair|http://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/tuple/Pair.html] > as an alternative to > [org.apache.solr.common.util.Pair|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Pair.java] > variant. > [This|http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e] > dev list posting reports on exploring use of 3.4 instead of 2.6 and > concludes with the discovery of an optional zookeeper dependency on > commons-lang-2.4 version. > So upgrading commons-lang can't happen anytime soon but this ticket here to > track motivations and findings so far for future reference. > selected links into other relevant dev list threads: > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CA9C1B04B-EA67-4F2F-A9F3-B24A2AFB8598%40gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdSrZXDJk7VwuVzxDeqdocagS33Fx%2BstYD3yTx5--WXiA%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3CCAN4YXvdWmCDSzXV40-wz1sr766GSwONGFem7UutkdXnsy0%2BXrg%40mail.gmail.com%3E > * > http://mail-archives.apache.org/mod_mbox/lucene-dev/201605.mbox/%3cc6c4e67c-9506-cb1f-1ca5-cfa6fc880...@elyograg.org%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
