[jira] [Commented] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
[ https://issues.apache.org/jira/browse/SOLR-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798848#comment-15798848 ] ASF subversion and git services commented on SOLR-9820: --- Commit 37859a35df3b9324017afdb2ed0870a1c6c6f30e in lucene-solr's branch refs/heads/branch_6x from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=37859a3 ] SOLR-9820: change PerSegmentSingleValuedFaceting.(contains|ignoreCase) from default to private visibility. (Jonny Marks via Christine Poerschke) > PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields > private > > > Key: SOLR-9820 > URL: https://issues.apache.org/jira/browse/SOLR-9820 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9820.patch > > > This patch marks the "contains" and "ignoreCase" fields in > PerSegmentSingleValuedFaceting private (they are currently public). > A separate patch will follow where I propose to replace them with a > customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
[ https://issues.apache.org/jira/browse/SOLR-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798748#comment-15798748 ] ASF subversion and git services commented on SOLR-9820: --- Commit 2f62facc0b93095d0be616a5cbda7d0f9ae20747 in lucene-solr's branch refs/heads/master from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2f62fac ] SOLR-9820: change PerSegmentSingleValuedFaceting.(contains|ignoreCase) from default to private visibility. (Jonny Marks via Christine Poerschke) > PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields > private > > > Key: SOLR-9820 > URL: https://issues.apache.org/jira/browse/SOLR-9820 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9820.patch > > > This patch marks the "contains" and "ignoreCase" fields in > PerSegmentSingleValuedFaceting private (they are currently public). > A separate patch will follow where I propose to replace them with a > customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
[ https://issues.apache.org/jira/browse/SOLR-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715884#comment-15715884 ] David Smiley commented on SOLR-9820: They are currently so-called package-protected, not public. What is the motivation here? I think you might potentially get interest in this getting committed if you morph this issue to include the follow-on stuff you speak of. But as-is; it's too boring to commit (speaking for myself). > PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields > private > > > Key: SOLR-9820 > URL: https://issues.apache.org/jira/browse/SOLR-9820 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9820.patch > > > This patch marks the "contains" and "ignoreCase" fields in > PerSegmentSingleValuedFaceting private (they are currently public). > A separate patch will follow where I propose to replace them with a > customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
