[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829494#comment-15829494
]
ASF subversion and git services commented on SOLR-9885:
---
Commit 88a88a0aa736926a7db4c21ebf11086344b236fa in lucene-solr's branch
refs/heads/branch_6x from markrmiller
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=88a88a0 ]
SOLR-9885: Allow pre-startup Solr log management in Solr bin scripts to be
disabled.
# Conflicts:
# solr/CHANGES.txt
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.3
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Fix For: master (7.0), 6.5
>
> Attachments: SOLR-9885.patch, SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like
> {{SOLR_LOG_PRESTART_ROTATION}} (with default {{true}}), that makes the
> execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829493#comment-15829493
]
ASF subversion and git services commented on SOLR-9885:
---
Commit 075aec91cd2c10e3f9a62adcf0feadc705c205ec in lucene-solr's branch
refs/heads/master from markrmiller
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=075aec9 ]
SOLR-9885: Allow pre-startup Solr log management in Solr bin scripts to be
disabled.
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.3
>Reporter: Mano Kovacs
>Assignee: Mark Miller
> Attachments: SOLR-9885.patch, SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like
> {{SOLR_LOG_PRESTART_ROTATION}} (with default {{true}}), that makes the
> execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828964#comment-15828964
]
Mark Miller commented on SOLR-9885:
---
I'll test it on windows. Thought it would be quick but forgot my SSD died a
while back and I lost my virtual box files. Now I've re created everything, so
I'll review and check Windows.
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.3
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like
> {{SOLR_LOG_PRESTART_ROTATION}} (with default {{true}}), that makes the
> execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819584#comment-15819584
]
Mano Kovacs commented on SOLR-9885:
---
[~janhoy], thanks for the review! I did test on Linux, but I did not have
chance to test it on Windows. I relied on other if-conditions in the cmd. Could
someone verify the change on Windows?
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.3
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like
> {{SOLR_LOG_PRESTART_ROTATION}} (with default {{true}}), that makes the
> execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799353#comment-15799353
]
Jan Høydahl commented on SOLR-9885:
---
Looks good to me. Have you tested for both Linux and Windows?
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.3
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like
> {{SOLR_LOG_PRESTART_ROTATION}} (with default {{true}}), that makes the
> execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798128#comment-15798128
]
Mano Kovacs commented on SOLR-9885:
---
[~janhoy], thank you for the feedback. Yes, more descriptive name would be more
appropriate. I update the documentation as well and submit a new patch.
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like {{SOLR_LOG_ROTATION}} (with
> default {{true}}), that makes the execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797911#comment-15797911
]
Jan Høydahl commented on SOLR-9885:
---
Makes sense
But perhaps document better what SOLR_LOG_ROTATION=false actually does, it now
sounds as if log rotation will be disabled if set to false, but it only affects
pre-start custom rotation, not the solr.log rotation or gc-log rotation!
Perhaps a better name would be SOLR_LOG_PRESTART_ROTATION or similar?
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like {{SOLR_LOG_ROTATION}} (with
> default {{true}}), that makes the execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793100#comment-15793100
]
Mano Kovacs commented on SOLR-9885:
---
Any review would be greatly appreciated!
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
> Attachments: SOLR-9885.patch, SOLR-9885.patch
>
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like {{SOLR_LOG_ROTATION}} (with
> default {{true}}), that makes the execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9885) Make log management configurable
[
https://issues.apache.org/jira/browse/SOLR-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770268#comment-15770268
]
Mark Miller commented on SOLR-9885:
---
+1
> Make log management configurable
>
>
> Key: SOLR-9885
> URL: https://issues.apache.org/jira/browse/SOLR-9885
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Mano Kovacs
>
> There is log rotation and log archiver in solr starter script, which is
> failing if solr is deployed with custom log configuration (different log
> filename). Also inconvenient if using custom log rotation/management.
> https://github.com/apache/lucene-solr/blob/master/solr/bin/solr#L1464
> Proposing an environment setting, something like {{SOLR_LOG_ROTATION}} (with
> default {{true}}), that makes the execution of the four lines configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
