[jira] [Commented] (SOLR-9939) Ping handler logs each request twice
[
https://issues.apache.org/jira/browse/SOLR-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812733#comment-15812733
]
Mikhail Khludnev commented on SOLR-9939:
well, yes. But proper testing is challenging.
> Ping handler logs each request twice
>
>
> Key: SOLR-9939
> URL: https://issues.apache.org/jira/browse/SOLR-9939
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.4
>Reporter: Shawn Heisey
>Priority: Minor
> Attachments: SOLR-9939.patch, SOLR-9939.patch
>
>
> Requests to the ping handler are being logged twice. The first line has
> "hits" and the second one doesn't, but other than that they have the same
> info.
> These lines are from a 5.3.2-SNAPSHOT version. In the IRC channel,
> [~ctargett] confirmed that this also happens in 6.4-SNAPSHOT.
> {noformat}
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> hits=400271103 status=0 QTime=4
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> status=0 QTime=4
> {noformat}
> Unless there's a good reason to have it that I'm not aware of, the second log
> should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9939) Ping handler logs each request twice
[
https://issues.apache.org/jira/browse/SOLR-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809946#comment-15809946
]
Trey Cahill commented on SOLR-9939:
---
[~mkhludnev] good call on clearing rsp.getToLog(); uploaded a patch that does
just that. Ends up being much cleaner.
> Ping handler logs each request twice
>
>
> Key: SOLR-9939
> URL: https://issues.apache.org/jira/browse/SOLR-9939
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.4
>Reporter: Shawn Heisey
>Priority: Minor
> Attachments: SOLR-9939.patch, SOLR-9939.patch
>
>
> Requests to the ping handler are being logged twice. The first line has
> "hits" and the second one doesn't, but other than that they have the same
> info.
> These lines are from a 5.3.2-SNAPSHOT version. In the IRC channel,
> [~ctargett] confirmed that this also happens in 6.4-SNAPSHOT.
> {noformat}
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> hits=400271103 status=0 QTime=4
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> status=0 QTime=4
> {noformat}
> Unless there's a good reason to have it that I'm not aware of, the second log
> should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9939) Ping handler logs each request twice
[
https://issues.apache.org/jira/browse/SOLR-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808095#comment-15808095
]
Mikhail Khludnev commented on SOLR-9939:
wow.. PingRequestHandler makes reentrant call core.execute() (and I can only
guess why). Since SolrQueryResponse is instantiated by PingRequestHandler can't
logging be suppressed by clearing rsp.getToLog() or so..
> Ping handler logs each request twice
>
>
> Key: SOLR-9939
> URL: https://issues.apache.org/jira/browse/SOLR-9939
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.4
>Reporter: Shawn Heisey
>Priority: Minor
> Attachments: SOLR-9939.patch
>
>
> Requests to the ping handler are being logged twice. The first line has
> "hits" and the second one doesn't, but other than that they have the same
> info.
> These lines are from a 5.3.2-SNAPSHOT version. In the IRC channel,
> [~ctargett] confirmed that this also happens in 6.4-SNAPSHOT.
> {noformat}
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> hits=400271103 status=0 QTime=4
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> status=0 QTime=4
> {noformat}
> Unless there's a good reason to have it that I'm not aware of, the second log
> should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9939) Ping handler logs each request twice
[
https://issues.apache.org/jira/browse/SOLR-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808037#comment-15808037
]
Trey Cahill commented on SOLR-9939:
---
The uploaded patch will filter the second request logging line from the Ping
request.
Looking at the thread dump
https://gist.github.com/cahilltr/e957857b7893c871022551f0e4daab28, it looks
like SolrCore.execute() is called twice, which has request logging code in it
(https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2327).
Not sure if this is intended or filtering the second log message is sufficient.
> Ping handler logs each request twice
>
>
> Key: SOLR-9939
> URL: https://issues.apache.org/jira/browse/SOLR-9939
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.4
>Reporter: Shawn Heisey
>Priority: Minor
> Attachments: SOLR-9939.patch
>
>
> Requests to the ping handler are being logged twice. The first line has
> "hits" and the second one doesn't, but other than that they have the same
> info.
> These lines are from a 5.3.2-SNAPSHOT version. In the IRC channel,
> [~ctargett] confirmed that this also happens in 6.4-SNAPSHOT.
> {noformat}
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> hits=400271103 status=0 QTime=4
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> status=0 QTime=4
> {noformat}
> Unless there's a good reason to have it that I'm not aware of, the second log
> should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9939) Ping handler logs each request twice
[
https://issues.apache.org/jira/browse/SOLR-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805862#comment-15805862
]
Shawn Heisey commented on SOLR-9939:
When I have some time I can look for the problem and try to fix it, but if
anybody else wants the issue, feel free to take it.
> Ping handler logs each request twice
>
>
> Key: SOLR-9939
> URL: https://issues.apache.org/jira/browse/SOLR-9939
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 6.4
>Reporter: Shawn Heisey
>Priority: Minor
>
> Requests to the ping handler are being logged twice. The first line has
> "hits" and the second one doesn't, but other than that they have the same
> info.
> These lines are from a 5.3.2-SNAPSHOT version. In the IRC channel,
> [~ctargett] confirmed that this also happens in 6.4-SNAPSHOT.
> {noformat}
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> hits=400271103 status=0 QTime=4
> 2017-01-06 14:16:37.253 INFO (qtp1510067370-186262) [ x:sparkmain]
> or.ap.so.co.So.Request [sparkmain] webapp=/solr path=/admin/ping params={}
> status=0 QTime=4
> {noformat}
> Unless there's a good reason to have it that I'm not aware of, the second log
> should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
