[jira] [Updated] (LUCENE-3021) randomize skipInterval in tests

2011-04-11 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3021:


Attachment: LUCENE-3021.patch

just a really quick patch, i hit lots of problems with Standard with this 
(maybe just bad asserts? havent even looked).


 randomize skipInterval in tests
 ---

 Key: LUCENE-3021
 URL: https://issues.apache.org/jira/browse/LUCENE-3021
 Project: Lucene - Java
  Issue Type: Test
Reporter: Robert Muir
 Attachments: LUCENE-3021.patch


 we probably don't test the multi-level skipping very well, but skipInterval 
 etc is now private to the codec, so for better test coverage we should 
 parameterize it to the postings writers, and randomize it via mockrandomcodec.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-3021) randomize skipInterval in tests

2011-04-11 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3021:


Attachment: LUCENE-3021.patch

oh duh, i sometimes created skipInterval=1

everything seems fine now with -Dtests.codec=MockRandom

 randomize skipInterval in tests
 ---

 Key: LUCENE-3021
 URL: https://issues.apache.org/jira/browse/LUCENE-3021
 Project: Lucene - Java
  Issue Type: Test
Reporter: Robert Muir
 Attachments: LUCENE-3021.patch, LUCENE-3021.patch


 we probably don't test the multi-level skipping very well, but skipInterval 
 etc is now private to the codec, so for better test coverage we should 
 parameterize it to the postings writers, and randomize it via mockrandomcodec.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org