[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0

2011-08-17 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3374:


Attachment: LUCENE-3374.patch

updated patch: I fixed TestCrash, because this crazy test does evil things that 
violate the assert (the assert itself looks good and I think we want it 
enabled).

So I added expert 'maybeWrap' booleans so that crazy tests like this can 
intentionally not use NRTCachingDir.

But, there are more problems in other tests (FNFEs). I wired the boolean with a 
nocommit to true in the patch so that these occur every time. might be a real 
bug in here...

 move nrtcachingdir to core in 4.0
 -

 Key: LUCENE-3374
 URL: https://issues.apache.org/jira/browse/LUCENE-3374
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-3374.patch, LUCENE-3374.patch


 in 4.0 with the IOContext changes this implementation is clean and I think we 
 should move it to core and use it in our tests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0

2011-08-17 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3374:


Attachment: LUCENE-3374.patch

patch fixing the fails.

This directory was *seriously screwed* if you use compound file format. 

There's one fail left in TestFSDir, havent looked yet, might be a false one. 

But we should backport this compound file stuff to 3.x ... maybe make a 
standalone test for it there.

 move nrtcachingdir to core in 4.0
 -

 Key: LUCENE-3374
 URL: https://issues.apache.org/jira/browse/LUCENE-3374
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-3374.patch, LUCENE-3374.patch, LUCENE-3374.patch


 in 4.0 with the IOContext changes this implementation is clean and I think we 
 should move it to core and use it in our tests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0

2011-08-17 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3374:


Attachment: LUCENE-3374.patch

ok, all tests pass. The last bugs were stupid (see my comments in the patch), 
but these are also bugs in FileSwitchDirectory.

I'm gonna open a separate issue to turn on FileSwitchDirectory in tests and 
lets fix this stuff there too.

 move nrtcachingdir to core in 4.0
 -

 Key: LUCENE-3374
 URL: https://issues.apache.org/jira/browse/LUCENE-3374
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-3374.patch, LUCENE-3374.patch, LUCENE-3374.patch, 
 LUCENE-3374.patch


 in 4.0 with the IOContext changes this implementation is clean and I think we 
 should move it to core and use it in our tests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0

2011-08-15 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-3374:


Attachment: LUCENE-3374.patch

 move nrtcachingdir to core in 4.0
 -

 Key: LUCENE-3374
 URL: https://issues.apache.org/jira/browse/LUCENE-3374
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-3374.patch


 in 4.0 with the IOContext changes this implementation is clean and I think we 
 should move it to core and use it in our tests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org