[jira] [Updated] (LUCENE-4224) Simplify MultiValuedCase in TermsIncludingScoreQuery

2012-07-23 Thread Martijn van Groningen (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn van Groningen updated LUCENE-4224:
--

Affects Version/s: 4.0-ALPHA
Fix Version/s: 4.0

 Simplify MultiValuedCase in TermsIncludingScoreQuery
 

 Key: LUCENE-4224
 URL: https://issues.apache.org/jira/browse/LUCENE-4224
 Project: Lucene - Core
  Issue Type: Task
Affects Versions: 4.0-ALPHA
Reporter: Robert Muir
Assignee: Martijn van Groningen
 Fix For: 4.0

 Attachments: LUCENE-4224.patch, LUCENE-4224.patch


 While looking at LUCENE-4214, i was trying to wrap my head around what this 
 is doing... 
 I think the code specialization in the multivalued scorer doesn't buy us any 
 additional speed? At least according to my benchmarks?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4224) Simplify MultiValuedCase in TermsIncludingScoreQuery

2012-07-20 Thread Martijn van Groningen (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn van Groningen updated LUCENE-4224:
--

Attachment: LUCENE-4224.patch

Attached a new patch.
* Added a Scorer that scores in order.
* Existing throw a UOE in the advance() method.

 Simplify MultiValuedCase in TermsIncludingScoreQuery
 

 Key: LUCENE-4224
 URL: https://issues.apache.org/jira/browse/LUCENE-4224
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
Assignee: Martijn van Groningen
 Attachments: LUCENE-4224.patch, LUCENE-4224.patch


 While looking at LUCENE-4214, i was trying to wrap my head around what this 
 is doing... 
 I think the code specialization in the multivalued scorer doesn't buy us any 
 additional speed? At least according to my benchmarks?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4224) Simplify MultiValuedCase in TermsIncludingScoreQuery

2012-07-16 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-4224:


Attachment: LUCENE-4224.patch

Here's the patch.

Note that, both these scorers return docids out of order i think? I don't think 
the single-valued one should implement advance(), it should throw UOE?

 Simplify MultiValuedCase in TermsIncludingScoreQuery
 

 Key: LUCENE-4224
 URL: https://issues.apache.org/jira/browse/LUCENE-4224
 Project: Lucene - Java
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-4224.patch


 While looking at LUCENE-4214, i was trying to wrap my head around what this 
 is doing... 
 I think the code specialization in the multivalued scorer doesn't buy us any 
 additional speed? At least according to my benchmarks?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org