[jira] [Updated] (LUCENE-4670) Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new formats easier

2013-01-09 Thread Adrien Grand (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-4670:
-

Attachment: LUCENE-4670.patch

Patch, with new assertions in AssertingCodec to make sure that there is a 
finish call for every start call. Tests passed with -Dtest.codec=Asserting.

 Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
 formats easier
 --

 Key: LUCENE-4670
 URL: https://issues.apache.org/jira/browse/LUCENE-4670
 Project: Lucene - Core
  Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
 Fix For: 4.1

 Attachments: LUCENE-4670.patch


 This is especially useful to LUCENE-4599 where actions have to be taken after 
 a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4670) Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new formats easier

2013-01-09 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-4670:


Attachment: LUCENE-4670.patch

i think this looks better?

I can go either way on whether or not the finish() methods should be abstract 
though (versus having a no-op impl).


 Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
 formats easier
 --

 Key: LUCENE-4670
 URL: https://issues.apache.org/jira/browse/LUCENE-4670
 Project: Lucene - Core
  Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
 Fix For: 4.1

 Attachments: LUCENE-4670.patch, LUCENE-4670.patch


 This is especially useful to LUCENE-4599 where actions have to be taken after 
 a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4670) Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new formats easier

2013-01-09 Thread Adrien Grand (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-4670:
-

Attachment: LUCENE-4670.patch

New patch with stored fields.

 Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
 formats easier
 --

 Key: LUCENE-4670
 URL: https://issues.apache.org/jira/browse/LUCENE-4670
 Project: Lucene - Core
  Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
 Fix For: 4.1

 Attachments: LUCENE-4670.patch, LUCENE-4670.patch, LUCENE-4670.patch


 This is especially useful to LUCENE-4599 where actions have to be taken after 
 a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (LUCENE-4670) Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new formats easier

2013-01-09 Thread Adrien Grand (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-4670:
-

Attachment: LUCENE-4670.patch

New patch with state machine for stored fields.

 Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
 formats easier
 --

 Key: LUCENE-4670
 URL: https://issues.apache.org/jira/browse/LUCENE-4670
 Project: Lucene - Core
  Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
 Fix For: 4.1

 Attachments: LUCENE-4670.patch, LUCENE-4670.patch, LUCENE-4670.patch, 
 LUCENE-4670.patch


 This is especially useful to LUCENE-4599 where actions have to be taken after 
 a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org